shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-01-18 10:04:20 +03:00
Code Releases Activity

cov: check closedir result

Browse Source 
Log problems around failing closedir().
This commit is contained in:
Zdenek Kabelac 2018-10-15 16:19:49 +02:00
parent 668c9d0762
commit f1ac130dc1
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tools/pvscan.c
View File

@ -229,7 +229,8 @@ static void _online_pvid_file_remove_devno(int major, int minor)
break; break;
} }
} }
closedir(dir); if (closedir(dir))
log_sys_debug("closedir", _pvs_online_dir);
} }
static void _online_pvid_files_remove(void) static void _online_pvid_files_remove(void)
@ -249,7 +250,8 @@ static void _online_pvid_files_remove(void)
snprintf(path, sizeof(path), "%s/%s", _pvs_online_dir, de->d_name); snprintf(path, sizeof(path), "%s/%s", _pvs_online_dir, de->d_name);
unlink(path); unlink(path);
} }
closedir(dir); if (closedir(dir))
log_sys_debug("closedir", _pvs_online_dir);
} }
static void _online_pvid_file_create(struct device *dev) static void _online_pvid_file_create(struct device *dev)
@ -338,10 +340,12 @@ static int _online_pvid_files_missing(void)
while ((de = readdir(dir))) { while ((de = readdir(dir))) {
if (de->d_name[0] == '.') if (de->d_name[0] == '.')
continue; continue;
closedir(dir); if (closedir(dir))
log_sys_debug("closedir", _pvs_online_dir);
return 0; return 0;
} }
closedir(dir); if (closedir(dir))
log_sys_debug("closedir", _pvs_online_dir);
return 1; return 1;
} }