From f28fd56f764cfd1f38fa6bc975cef056391d73fc Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Tue, 24 Jul 2007 14:16:48 +0000 Subject: [PATCH] libdevmapper, dmeventd: be paranoid about detecting write failure * dmeventd/dmeventd.c (_set_oom_adj): When writing to /proc/self/oom_adj, detect failure even if it's hidden behind ferror. [Using dm_fclose's extra ferror test here is probably not needed, since the amount written is nowhere near BUFSIZ, but use it regardless, for consistency. ] * lib/fs/libdevmapper.c (do_suspend): Detect fclose failure when writing to suspend. --- WHATS_NEW_DM | 1 + daemons/dmeventd/dmeventd.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/WHATS_NEW_DM b/WHATS_NEW_DM index d5c294f46..0f1b4d081 100644 --- a/WHATS_NEW_DM +++ b/WHATS_NEW_DM @@ -1,6 +1,7 @@ Version 1.02.22 - ================================ dm_fclose: new function + libdevmapper, dmeventd: be paranoid about detecting write failure Version 1.02.21 - 13th July 2007 ================================ diff --git a/daemons/dmeventd/dmeventd.c b/daemons/dmeventd/dmeventd.c index 324ee54e0..4bcd4247b 100644 --- a/daemons/dmeventd/dmeventd.c +++ b/daemons/dmeventd/dmeventd.c @@ -1579,7 +1579,7 @@ static int _set_oom_adj(int val) } fprintf(fp, "%i", val); - if (fclose(fp)) + if (dm_fclose(fp)) perror(OOM_ADJ_FILE ": fclose failed"); return 1;