From f380cd7d9867fe00340ccfb61f642c0745d2b7a1 Mon Sep 17 00:00:00 2001 From: Zdenek Kabelac Date: Mon, 27 Feb 2012 11:45:05 +0000 Subject: [PATCH] Use unsigned type for bitmask Using report_type_t for bitmask is not correct, since we have not defined types for all bit combinations - so switching to unsigned type, since values of report_type_t enum are unsigned. --- WHATS_NEW | 1 + lib/report/properties.c | 4 ++-- lib/report/properties.h | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/WHATS_NEW b/WHATS_NEW index 1f2e2b3c7..bf6a05dbd 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,5 +1,6 @@ Version 2.02.94 - ==================================== + Use unsigned type for bitmask instead of enum type for lvm properties. Add missing cleanup of excl_uuid hash on some exit paths of clvmd. Check for existance of vg_name in _format1/_pool_vg_read(). Fix missing break in _format_pvsegs (2.02.92). diff --git a/lib/report/properties.c b/lib/report/properties.c index b2f6d7b36..0855f955e 100644 --- a/lib/report/properties.c +++ b/lib/report/properties.c @@ -315,7 +315,7 @@ struct lvm_property_type _properties[] = { static int _get_property(const void *obj, struct lvm_property_type *prop, - report_type_t type) + unsigned type) { struct lvm_property_type *p; @@ -343,7 +343,7 @@ static int _get_property(const void *obj, struct lvm_property_type *prop, } static int _set_property(void *obj, struct lvm_property_type *prop, - report_type_t type) + unsigned type) { struct lvm_property_type *p; diff --git a/lib/report/properties.h b/lib/report/properties.h index f363362c7..aefd3f589 100644 --- a/lib/report/properties.h +++ b/lib/report/properties.h @@ -20,7 +20,7 @@ #include "report.h" struct lvm_property_type { - report_type_t type; + unsigned type; const char *id; unsigned is_settable:1; unsigned is_string:1;