shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-01-03 05:18:29 +03:00
Code Releases Activity

. update documentation for --poll in the vgchange and lvchange man pages

Browse Source 
. add high-level --poll FIXMEs to vgchange.c and lvchange.c
This commit is contained in:
Mike Snitzer 2010-01-06 19:08:58 +00:00
parent 03984e05a3
commit f407c8afd0
4 changed files with 26 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
man/lvchange.8.in
View File

@ -64,12 +64,12 @@ the failure is handled according to
set in \fBlvm.conf\fP.
.TP
.I \-\-poll y|n
Controls whether or not a logical volume's progress is polled. It may
not be appropriate to immediately poll the progress of a logical
volume's transformation when it is activated (for example, when merging
a snapshot into the root FS). The progress polling of an incomplete
pvmove or lvconvert can be deferred using \fB--poll n\fP and restarted
using \fB--poll y\fP.
Without polling a logical volume's backgrounded transformation process
will never complete. If there is an incomplete pvmove or lvconvert (for
example, on rebooting after a crash), use \fB--poll y\fP to restart the
process from its last checkpoint. However, it may not be appropriate to
immediately poll a logical volume when it is activated, use \fB--poll
n\fP to defer and then \fB--poll y\fP to restart the process.
.TP
.I \-\-noudevsync
Disable udev synchronisation. The

12
man/vgchange.8.in
View File

@ -89,12 +89,12 @@ set in
.BR lvm.conf (5).
.TP
.BR \-\-poll " " { y | n }
Controls whether or not a logical volume's progress is polled. It may
not be appropriate to immediately poll the progress of a logical
volume's transformation when it is activated (for example, when merging
a snapshot into the root FS). The progress polling of an incomplete
pvmove or lvconvert can be deferred using \fB--poll n\fP and restarted
using \fB--poll y\fP.
Without polling a logical volume's backgrounded transformation process
will never complete. If there is an incomplete pvmove or lvconvert (for
example, on rebooting after a crash), use \fB--poll y\fP to restart the
process from its last checkpoint. However, it may not be appropriate to
immediately poll a logical volume when it is activated, use \fB--poll
n\fP to defer and then \fB--poll y\fP to restart the process.
.TP
.BR \-\-noudevsync
Disable udev synchronisation. The

7
tools/lvchange.c
View File

@ -596,6 +596,13 @@ static int lvchange_single(struct cmd_context *cmd, struct logical_volume *lv,
(is_static() || arg_count(cmd, ignoremonitoring_ARG)) ?
DMEVENTD_MONITOR_IGNORE : DEFAULT_DMEVENTD_MONITOR));
/*
* FIXME: DEFAULT_BACKGROUND_POLLING should be "unspecified".
* If --poll is explicitly provided use it; otherwise polling
* should only be started if the LV is not already active. So:
* 1) change the activation code to say if the LV was actually activated
* 2) make polling of an LV tightly coupled with LV activation
*/
init_background_polling(arg_int_value(cmd, poll_ARG,
DEFAULT_BACKGROUND_POLLING));

7
tools/vgchange.c
View File

@ -548,6 +548,13 @@ static int vgchange_single(struct cmd_context *cmd, const char *vg_name,
(is_static() || arg_count(cmd, ignoremonitoring_ARG)) ?
DMEVENTD_MONITOR_IGNORE : DEFAULT_DMEVENTD_MONITOR));
/*
* FIXME: DEFAULT_BACKGROUND_POLLING should be "unspecified".
* If --poll is explicitly provided use it; otherwise polling
* should only be started if the LV is not already active. So:
* 1) change the activation code to say if the LV was actually activated
* 2) make polling of an LV tightly coupled with LV activation
*/
init_background_polling(arg_int_value(cmd, poll_ARG,
DEFAULT_BACKGROUND_POLLING));