From f50a76379a377e649898d179b5e5fab0a283d2fe Mon Sep 17 00:00:00 2001 From: Zdenek Kabelac Date: Fri, 17 Jun 2011 14:27:34 +0000 Subject: [PATCH] Remove test for status flag As the ACTIVATE_EXCL could be set only in clvmd code - there is no use for this test in lv_add_mirrors() function only called from tools context. FIXME: Add cluster test case for this. --- WHATS_NEW | 1 + lib/metadata/mirror.c | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/WHATS_NEW b/WHATS_NEW index ba7eaab83..e76b3d52e 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,5 +1,6 @@ Version 2.02.86 - ================================= + Remove useless test of ACTIVATE_EXCL in lv_add_mirrors() clustered code path. Use lv_activate_opts struct instead of MERGING status flag. Use lv_activate_opts struct instead of ACTIVATE_EXCL status flag. Add lv_activate_opts structure for activation (replacing activation flags). diff --git a/lib/metadata/mirror.c b/lib/metadata/mirror.c index 3a02178b2..0f4b0535b 100644 --- a/lib/metadata/mirror.c +++ b/lib/metadata/mirror.c @@ -2021,8 +2021,7 @@ int lv_add_mirrors(struct cmd_context *cmd, struct logical_volume *lv, if (vg_is_clustered(lv->vg)) { /* FIXME: review check of lv_is_active_remotely */ - if (!(lv->status & ACTIVATE_EXCL) && - !cluster_mirror_is_available(lv)) { + if (!cluster_mirror_is_available(lv)) { log_error("Shared cluster mirrors are not available."); return 0; }