shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

lvmcache: fix memleaks on list removal

Browse Source 
Free members released from the list.
This commit is contained in:
David Teigland 2024-04-03 17:54:48 -05:00 committed by Zdenek Kabelac
parent 0168de83de
commit f59ec61fa7
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lib/cache/lvmcache.c vendored
View File

@ -897,8 +897,10 @@ next:
} }
/* Remove dev_mpath from altdevs. */ /* Remove dev_mpath from altdevs. */
if ((devl = device_list_find_dev(&altdevs, dev_mpath))) if ((devl = device_list_find_dev(&altdevs, dev_mpath))) {
dm_list_del(&devl->list); dm_list_del(&devl->list);
free(devl);
}
/* Remove info from lvmcache that came from the component dev. */ /* Remove info from lvmcache that came from the component dev. */
log_debug("Ignoring multipath component %s with PVID %s (dropping info)", dev_name(dev_drop), pvid); log_debug("Ignoring multipath component %s with PVID %s (dropping info)", dev_name(dev_drop), pvid);
@ -935,6 +937,7 @@ next:
log_debug("Ignoring multipath component %s with PVID %s (dropping duplicate)", dev_name(dev_drop), pvid); log_debug("Ignoring multipath component %s with PVID %s (dropping duplicate)", dev_name(dev_drop), pvid);
dm_list_del(&devl->list); dm_list_del(&devl->list);
free(devl);
cmd->filter->wipe(cmd, cmd->filter, dev_drop, NULL); cmd->filter->wipe(cmd, cmd->filter, dev_drop, NULL);
dev_drop->flags &= ~DEV_SCAN_FOUND_LABEL; dev_drop->flags &= ~DEV_SCAN_FOUND_LABEL;
@ -964,8 +967,10 @@ next:
} }
/* Remove dev_md from altdevs. */ /* Remove dev_md from altdevs. */
if ((devl = device_list_find_dev(&altdevs, dev_md))) if ((devl = device_list_find_dev(&altdevs, dev_md))) {
dm_list_del(&devl->list); dm_list_del(&devl->list);
free(devl);
}
/* Remove info from lvmcache that came from the component dev. */ /* Remove info from lvmcache that came from the component dev. */
log_debug("Ignoring md component %s with PVID %s (dropping info)", dev_name(dev_drop), pvid); log_debug("Ignoring md component %s with PVID %s (dropping info)", dev_name(dev_drop), pvid);
@ -992,8 +997,10 @@ next:
} }
/* Remove dev_md from altdevs. */ /* Remove dev_md from altdevs. */
if ((devl = device_list_find_dev(&altdevs, dev_md))) if ((devl = device_list_find_dev(&altdevs, dev_md))) {
dm_list_del(&devl->list); dm_list_del(&devl->list);
free(devl);
}
} }
if (info && !dev_md) { if (info && !dev_md) {
@ -1021,6 +1028,7 @@ next:
log_debug("Ignoring md component %s with PVID %s (dropping duplicate)", dev_name(dev_drop), pvid); log_debug("Ignoring md component %s with PVID %s (dropping duplicate)", dev_name(dev_drop), pvid);
dm_list_del(&devl->list); dm_list_del(&devl->list);
free(devl);
cmd->filter->wipe(cmd, cmd->filter, dev_drop, NULL); cmd->filter->wipe(cmd, cmd->filter, dev_drop, NULL);
dev_drop->flags &= ~DEV_SCAN_FOUND_LABEL; dev_drop->flags &= ~DEV_SCAN_FOUND_LABEL;