shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

dev-cache: ensure list has elements

Browse Source 
When updating DM cache, check whether the list even has entries
before comparing it with old cached instance.
This commit is contained in:
Zdenek Kabelac 2024-10-24 22:55:24 +02:00
parent 87f68f443c
commit f61572eef2
1 changed files with 19 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
lib/device/dev-cache.c
View File

@ -1325,23 +1325,26 @@ int dm_devs_cache_update(void)
if (_cache.dm_devs) { if (_cache.dm_devs) {
/* Compare existing cached list with a new one. /* Compare existing cached list with a new one.
* When there is any mismatch, just rebuild whole cache */ * When there is any mismatch, just rebuild whole cache */
l = dm_list_first(dm_devs_new); if ((l = dm_list_first(dm_devs_new))) {
dm_list_iterate_items(dm_dev, _cache.dm_devs) { dm_list_iterate_items(dm_dev, _cache.dm_devs) {
dm_dev_new = dm_list_item(l, struct dm_active_device); dm_dev_new = dm_list_item(l, struct dm_active_device);
if ((dm_dev->devno != dm_dev_new->devno) || if ((dm_dev->devno != dm_dev_new->devno) ||
strcmp(dm_dev->uuid, dm_dev_new->uuid)) { strcmp(dm_dev->uuid, dm_dev_new->uuid)) {
log_debug_cache("Mismatching UUID or devno found %s %lu %s %lu", log_debug_cache("Mismatching UUID or devno found %s %lu %s %lu",
dm_dev->uuid, dm_dev->devno, dm_dev->uuid, dm_dev->devno,
dm_dev_new->uuid, dm_dev_new->devno); dm_dev_new->uuid, dm_dev_new->devno);
cache_changed = 1; cache_changed = 1;
break; break;
}
if (!(l = dm_list_next(dm_devs_new, l))) {
if (dm_list_next(_cache.dm_devs, &dm_dev->list))
cache_changed = 1; /* old cached list still with entries */
break;
}
} }
if (!(l = dm_list_next(dm_devs_new, l))) { } else
if (dm_list_next(_cache.dm_devs, &dm_dev->list)) cache_changed = 1;
cache_changed = 1; /* old cached list still with entries */
break;
}
}
if (!cache_changed) { if (!cache_changed) {
log_debug_cache("Preserving DM cache."); log_debug_cache("Preserving DM cache.");
dm_device_list_destroy(&dm_devs_new); dm_device_list_destroy(&dm_devs_new);