shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-30 17:18:21 +03:00
Code Releases Activity

dmfilemapd: fix off-by-one in fd comparison (coverity)

Browse Source 
The function _filemap_monitor_check_file_unlinked() attempts to
test whether a fd value should be closed by comparison to zero:

        if ((fd > 0) && close(fd))
                log_error("Error closing fd %d", fd);

The test should be '>=' since 0 is a valid file descriptor.
This commit is contained in:
Bryn M. Reeves 2017-03-29 17:25:20 +01:00
parent 8658bbe3ee
commit f66bc3dab0
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
daemons/dmfilemapd/dmfilemapd.c
View File

@ -603,7 +603,7 @@ check_unlinked:
else
same = _filemap_monitor_check_same_file(fm->fd, fd);
if ((fd > 0) && close(fd))
if ((fd >= 0) && close(fd))
log_error("Error closing fd %d", fd);
if (same < 0)