mirror of
git://sourceware.org/git/lvm2.git
synced 2024-12-21 13:34:40 +03:00
Revert unsuccessful table load preparation in combined "create, load and resume" scenario.
There was missing "revert" call in _create_and_load_v4 fn while the preparation for table load ends up with failure in create/load/resume sequence. Otherwise we could end up with a device being created, but not table-loaded nor resumed. Even though the table is not loaded and the device is not resumed at this stage, we still need to synchronize with udev when calling the revert "remove" ioctl - there's still a remove uevent generated! The "revert" code does exactly that.
This commit is contained in:
parent
111c120e00
commit
f89f7955fc
@ -1655,14 +1655,16 @@ static int _create_and_load_v4(struct dm_task *dmt)
|
||||
if (!(task = dm_task_create(DM_DEVICE_RELOAD))) {
|
||||
log_error("Failed to create device-mapper task struct");
|
||||
_udev_complete(dmt);
|
||||
return 0;
|
||||
r = 0;
|
||||
goto revert;
|
||||
}
|
||||
|
||||
/* Copy across relevant fields */
|
||||
if (dmt->dev_name && !dm_task_set_name(task, dmt->dev_name)) {
|
||||
dm_task_destroy(task);
|
||||
_udev_complete(dmt);
|
||||
return 0;
|
||||
r = 0;
|
||||
goto revert;
|
||||
}
|
||||
|
||||
task->read_only = dmt->read_only;
|
||||
|
Loading…
Reference in New Issue
Block a user