shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

Disallow the creation of mirrors (mirror or raid1 segtype) with only one leg.

Browse Source 
If you specify the segment type (e.g. --type mirror) and the mirrors argument
as zero, it would result in a mirrored LV with only one image.  While the device
may be valid in theory, it should not be allowed in practice.  It also makes it
difficult on the conversion tools, since they react badly to single-image
mirrors.
This commit is contained in:
Jonathan Earl Brassow 2011-09-22 15:36:21 +00:00
parent 40c85cf1d7
commit f989a55539
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
WHATS_NEW
View File

@ -1,5 +1,6 @@
Version 2.02.89 -
==================================
Disallow the creation of mirrors (mirror or raid1 segtype) with only one leg.
Cleanup restart clvmd code (no memory allocation, debug print passed args).
Add all exclusive locks to clvmd restart option args.
Always send the whole clvmd packet header in refresh commands.

7
tools/lvcreate.c
View File

@ -618,8 +618,13 @@ static int _lvcreate_params(struct lvcreate_params *lp,
if (arg_count(cmd, mirrors_ARG)) {
lp->mirrors = arg_uint_value(cmd, mirrors_ARG, 0) + 1;
if (lp->mirrors == 1)
if (lp->mirrors == 1) {
if (segtype_is_mirrored(lp->segtype)) {
log_error("Image count for segtype \"%s\" cannot be 0.", lp->segtype->name);
return 0;
}
log_print("Redundant mirrors argument: default is 0");
}
if (arg_sign_value(cmd, mirrors_ARG, 0) == SIGN_MINUS) {
log_error("Mirrors argument may not be negative");
return 0;