shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

cov: mask false positive

Browse Source 
This code is somewhat complex and involves recursion and pointer
shuffling which confuses coverity here.

Let's add masking comment for this warning as there is no double
free in this code.
This commit is contained in:
Zdenek Kabelac 2024-04-09 18:34:01 +02:00
parent 2b9c3f8dc9
commit fa62397ff8
2 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
device_mapper/ioctl/libdm-iface.c
View File

@ -1697,6 +1697,7 @@ static int _create_and_load_v4(struct dm_task *dmt)
dmt->uuid = NULL; dmt->uuid = NULL;
free(dmt->mangled_uuid); free(dmt->mangled_uuid);
dmt->mangled_uuid = NULL; dmt->mangled_uuid = NULL;
/* coverity[double_free] recursive function call */
_dm_task_free_targets(dmt); _dm_task_free_targets(dmt);
if (dm_task_run(dmt)) if (dm_task_run(dmt))
@ -1708,6 +1709,7 @@ static int _create_and_load_v4(struct dm_task *dmt)
dmt->uuid = NULL; dmt->uuid = NULL;
free(dmt->mangled_uuid); free(dmt->mangled_uuid);
dmt->mangled_uuid = NULL; dmt->mangled_uuid = NULL;
/* coverity[double_free] recursive function call */
_dm_task_free_targets(dmt); _dm_task_free_targets(dmt);
/* /*

2
libdm/ioctl/libdm-iface.c
View File

@ -1560,6 +1560,7 @@ static int _create_and_load_v4(struct dm_task *dmt)
dmt->uuid = NULL; dmt->uuid = NULL;
dm_free(dmt->mangled_uuid); dm_free(dmt->mangled_uuid);
dmt->mangled_uuid = NULL; dmt->mangled_uuid = NULL;
/* coverity[double_free] recursive function call */
_dm_task_free_targets(dmt); _dm_task_free_targets(dmt);
if (dm_task_run(dmt)) if (dm_task_run(dmt))
@ -1571,6 +1572,7 @@ static int _create_and_load_v4(struct dm_task *dmt)
dmt->uuid = NULL; dmt->uuid = NULL;
dm_free(dmt->mangled_uuid); dm_free(dmt->mangled_uuid);
dmt->mangled_uuid = NULL; dmt->mangled_uuid = NULL;
/* coverity[double_free] recursive function call */
_dm_task_free_targets(dmt); _dm_task_free_targets(dmt);
/* /*