shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-01-02 01:18:26 +03:00
Code Releases Activity

metadata: add "Failed to write VG <vg_name>." on failed vg_write and revert previous patch

Browse Source 
Better than previous patch which changed log_warn to log_error -
we can have multiple MDAs and if one of them fails to be written,
we can still continue with other MDAs if we're in a mode where
we can handle missing PVs - so keep the log_warn for single
failed MDA write as it was before.

However, add log_error with "Failed to write VG <vg_name>." in
case we're not handling missing PVs or no MDA was written at all
during VG write process. This also prevents an internal error in
which the vg_write fails and we're not issuing any other log_error
in vg_write caller or above, so we end up with:
  "Internal error: Failed command did not use log_error".
This commit is contained in:
Peter Rajnoha 2015-01-09 14:04:44 +01:00
parent db7351d313
commit fb7e2ff493
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/metadata/metadata.c
View File

@ -2795,7 +2795,7 @@ int vg_write(struct volume_group *vg)
} }
if (!mda->ops->vg_write(vg->fid, vg, mda)) { if (!mda->ops->vg_write(vg->fid, vg, mda)) {
if (vg->cmd->handles_missing_pvs) { if (vg->cmd->handles_missing_pvs) {
log_error("Failed to write an MDA of VG %s.", vg->name); log_warn("WARNING: Failed to write an MDA of VG %s.", vg->name);
mda->status |= MDA_FAILED; mda->status |= MDA_FAILED;
} else { } else {
stack; stack;
@ -2807,6 +2807,7 @@ int vg_write(struct volume_group *vg)
} }
if (revert || !wrote) { if (revert || !wrote) {
log_error("Failed to write VG %s.", vg->name);
dm_list_uniterate(mdah, &vg->fid->metadata_areas_in_use, &mda->list) { dm_list_uniterate(mdah, &vg->fid->metadata_areas_in_use, &mda->list) {
mda = dm_list_item(mdah, struct metadata_area); mda = dm_list_item(mdah, struct metadata_area);