From fba54ae55e888d290f8783d813bbecf3f1cfdd61 Mon Sep 17 00:00:00 2001 From: Zdenek Kabelac Date: Mon, 22 Feb 2016 10:49:45 +0100 Subject: [PATCH] cleanup: libdm clang warnings Add some extra clang pointer validation so we do not try deref NULL. --- libdm/libdm-stats.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libdm/libdm-stats.c b/libdm/libdm-stats.c index d32e4ea0a..1eeca0657 100644 --- a/libdm/libdm-stats.c +++ b/libdm/libdm-stats.c @@ -963,7 +963,9 @@ static void _stats_walk_next(const struct dm_stats *dms, int region, if (!dms || !dms->regions) return; - cur = &dms->regions[*cur_r]; + if (!(cur = &dms->regions[*cur_r])) + return; + present = _stats_region_present(cur); if (region && present) @@ -1314,7 +1316,7 @@ static int _dm_stats_populate_region(struct dm_stats *dms, uint64_t region_id, if (!_stats_bound(dms)) return_0; - if (!_stats_parse_region(dms, resp, region, region->timescale)) { + if (!region || !_stats_parse_region(dms, resp, region, region->timescale)) { log_error("Could not parse @stats_print message response."); return 0; }