shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

Never ever use uninitialised descriptors if pipe() fails

Browse Source 
(because of maximum open count fd exceeded or so).

Better return busy message, so even clients fail in more controlled way.

Without patch,  clvmd crashes with various strange backtraces
if under heavy load of connection requests.

https://bugzilla.redhat.com/show_bug.cgi?id=698393
https://bugzilla.redhat.com/show_bug.cgi?id=697945

(It still can OOM but that's different issue.)
This commit is contained in:
Milan Broz 2011-08-11 12:57:10 +00:00
parent 3041b72f06
commit fc438d74b7
2 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
WHATS_NEW
View File

@ -1,5 +1,6 @@
Version 2.02.87 - Version 2.02.87 -
=============================== ===============================
If pipe in clvmd fails, return busy instead of using uninitialised descriptors.
Add dmeventd monitoring shared library for RAID. Add dmeventd monitoring shared library for RAID.
Add RAID metadata devices to considered devices in _add_lv_to_dtree. Add RAID metadata devices to considered devices in _add_lv_to_dtree.
Fix renaming of RAID logical volumes. Fix renaming of RAID logical volumes.

14
daemons/clvmd/clvmd.c
View File

@ -1263,9 +1263,19 @@ static int read_from_local_sock(struct local_client *thisfd)
} }
/* Create a pipe and add the reading end to our FD list */ /* Create a pipe and add the reading end to our FD list */
if (pipe(comms_pipe)) if (pipe(comms_pipe)) {
struct clvm_header reply;
DEBUGLOG("creating pipe failed: %s\n", strerror(errno)); DEBUGLOG("creating pipe failed: %s\n", strerror(errno));
reply.cmd = CLVMD_CMD_REPLY;
reply.status = EBUSY;
reply.arglen = 0;
reply.flags = 0;
send_message(&reply, sizeof(reply), our_csid,
thisfd->fd,
"Error sending EBUSY reply to local user");
return len;
}
newfd = malloc(sizeof(struct local_client)); newfd = malloc(sizeof(struct local_client));
if (!newfd) { if (!newfd) {
struct clvm_header reply; struct clvm_header reply;