shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

Add more verbose messages while checking volume_list and hosttags settings.

Browse Source 
This should bring less confusion when there are some settings left and
people just forgot about it and then they run into problems. These messages
should give them a hint of what's really going on.
This commit is contained in:
Peter Rajnoha 2010-07-12 11:37:49 +00:00
parent a93fb6299f
commit fefa43235f
2 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
WHATS_NEW
View File

@ -1,5 +1,6 @@
Version 2.02.71 -
===============================
Add more verbose messages while checking volume_list and hosttags settings.
Add log_error when strdup fails in {vg|lv}_change_tag().
Remove unnecessary includes in liblvm files.
Use __attribute__ consistently throughout.

13
lib/activate/activate.c
View File

@ -262,6 +262,9 @@ static int _passes_activation_filter(struct cmd_context *cmd,
char path[PATH_MAX];
if (!(cn = find_config_tree_node(cmd, "activation/volume_list"))) {
log_verbose("activation/volume_list configuration setting "
"not defined, checking host tags only");
/* If no host tags defined, activate */
if (dm_list_empty(&cmd->tags))
return 1;
@ -271,11 +274,18 @@ static int _passes_activation_filter(struct cmd_context *cmd,
str_list_match_list(&cmd->tags, &lv->vg->tags))
return 1;
log_verbose("No host tag matches %s/%s",
lv->vg->name, lv->name);
/* Don't activate */
return 0;
}
for (cv = cn->v; cv; cv = cv->next) {
log_verbose("activation/volume_list configuration setting "
"defined, checking the list to match %s/%s",
lv->vg->name, lv->name);
if (cv->type != CFG_STRING) {
log_error("Ignoring invalid string in config file "
"activation/volume_list");
@ -330,6 +340,9 @@ static int _passes_activation_filter(struct cmd_context *cmd,
return 1;
}
log_verbose("No item supplied in activation/volume_list configuration "
"setting matches %s/%s", lv->vg->name, lv->name);
return 0;
}