shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-03-11 20:58:50 +03:00
Code Releases Activity

thin: show message on error path

Browse Source 
Add missing log_error and show proper reason for failure
when autoextend is set to 0.

Add missing log_error when checked LV is not locally active.
This commit is contained in:
Zdenek Kabelac 2015-09-14 12:58:21 +02:00
parent c356991fa8
commit ffeeb5c1e7
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lib/metadata/lv_manip.c
View File

@ -4405,8 +4405,11 @@ static int _adjust_policy_params(struct cmd_context *cmd,
policy_amount = policy_amount =
find_config_tree_int(cmd, activation_thin_pool_autoextend_percent_CFG, find_config_tree_int(cmd, activation_thin_pool_autoextend_percent_CFG,
lv_config_profile(lv)); lv_config_profile(lv));
if (!policy_amount && policy_threshold < DM_PERCENT_100) if (!policy_amount && policy_threshold < DM_PERCENT_100) {
return 0; log_error("Can't extend thin pool %s, autoextend is set to 0%%.",
display_lvname(lv));
return 0;
}
} else { } else {
policy_threshold = policy_threshold =
find_config_tree_int(cmd, activation_snapshot_autoextend_threshold_CFG, NULL) * DM_PERCENT_1; find_config_tree_int(cmd, activation_snapshot_autoextend_threshold_CFG, NULL) * DM_PERCENT_1;
@ -4417,6 +4420,12 @@ static int _adjust_policy_params(struct cmd_context *cmd,
if (policy_threshold >= DM_PERCENT_100) if (policy_threshold >= DM_PERCENT_100)
return 1; /* nothing to do */ return 1; /* nothing to do */
if (!lv_is_active_locally(lv)) {
log_error("Can't read state of locally inactive LV %s.",
display_lvname(lv));
return 0;
}
if (lv_is_thin_pool(lv)) { if (lv_is_thin_pool(lv)) {
if (!lv_thin_pool_percent(lv, 1, &percent)) if (!lv_thin_pool_percent(lv, 1, &percent))
return_0; return_0;