11 Commits

Author	SHA1	Message	Date
Peter Rajnoha	023cf21848	coverity: fix possible invalid dereferences ... lib/format1/import-export.c:167: var_deref_op: Dereferencing null pointer "vg->lvm1_system_id" lib/cache/lvmetad.c:1023: var_deref_op: Dereferencing null pointer "this" daemons/lvmlockd/lvmlockd-core.c:2659: check_after_deref: Null-checking "act" suggests that it may be null, but it has already been dereferenced on all paths leading to the check /daemons/lvmetad/lvmetad-core.c:1024: check_after_deref: Null-checking "pvmeta" suggests that it may be null, but it has already been dereferenced on all paths leading to the check	2015-07-09 12:07:41 +02:00
David Teigland	903569d533	lvmlockd: remove log_error instances for normal conditions ... There are a number of log_error instances that are replaced by log_debug because they are not errors.	2015-07-08 15:25:14 -05:00
David Teigland	de13abdfdf	lvmlockd: fix unreachable code	2015-07-08 11:02:11 -05:00
David Teigland	2566bdfbc3	lvmlockctl: fix uninitialized names ... When formatting and printing info from lvmlockd. Also fix some new line problems.	2015-07-08 10:58:56 -05:00
Peter Rajnoha	3ec4813ba2	coverity: fix missing initialization ... ... Using uninitialized value "lockd_state" when calling "lockd_vg" (even though lockd_vg assigns 0 to the lockd_state, but it looks at previous state of lockd_state just before that so we need to have that properly initialized!) libdm/libdm-report.c:2934: uninit_use_in_call: Using uninitialized value "tm". Field "tm.tm_gmtoff" is uninitialized when calling "_get_final_time". daemons/lvmlockd/lvmlockctl.c:273: uninit_use_in_call: Using uninitialized element of array "r_name" when calling "format_info_r_action". (just added FIXME as this looks unfinished?)	2015-07-08 14:53:30 +02:00
Peter Rajnoha	71f4fbfbde	coverity: fix uninitialized values and other reported problems ... daemons/lvmlockd/lvmlockd-core.c:5709: error[uninitStructMember]: Uninitialized struct member: ds..... daemons/lvmlockd/lvmlockd-core.c:799: error[uninitstring]: Dangerous usage of 'version' (strncpy doesn't always null-terminate it) daemons/lvmlockd/lvmlockd-core.c:646: error[memleakOnRealloc]: Common realloc mistake: 'pollfd' nulled but not freed upon failure	2015-07-08 14:19:51 +02:00
Peter Rajnoha	16e9b32c2f	coverity: fix resource leaks ... lib/log/log.c:115: leaked_storage: Variable "st" going out of scope leaks the storage it points to daemons/lvmpolld/lvmpolld-core.c:573: leaked_storage: Variable "cmdargv" going out of scope leaks the storage it points to daemons/lvmlockd/lvmlockd-core.c:5341: leaked_handle: Handle variable "fd" going out of scope leaks the handle daemons/lvmlockd/lvmlockctl.c:575: overwrite_var: Overwriting "able_vg_name" in "able_vg_name = strdup(optarg)" leaks the storage that "able_vg_name" points to daemons/lvmlockd/lvmlockctl.c:571: overwrite_var: Overwriting "able_vg_name" in "able_vg_name = strdup(optarg)" leaks the storage that "able_vg_name" points to daemons/lvmlockd/lvmlockctl.c:385: leaked_handle: Handle variable "s" going out of scope leaks the handle	2015-07-08 13:56:06 +02:00
Alasdair G Kergon	dfe3eb12d0	include: Standardise around new tool.h.	2015-07-06 17:30:18 +01:00
David Teigland	d3605b81f3	configure: enable building lvmlockd without sanlock or dlm	2015-07-06 11:09:58 -05:00
Alasdair G Kergon	36ce97c625	pre-release	2015-07-03 16:34:40 +01:00
David Teigland	fe70b03de2	Add lvmlockd	2015-07-02 15:42:26 -05:00