shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-22 17:35:59 +03:00
Code Releases Activity
15,356 Commits 425 Branches 667 Tags 54 MiB
0a31fb4aa3
Commit Graph

82 Commits

Author SHA1 Message Date
Zdenek Kabelac
d90a647802 activation: separate reporting of error and monitoring status 
Avoid using same return code for reporting 2 different things
and stricly report error code by return value and add new
parameter for reporting monitoring status.

This makes easier to recognize which error we got from dm_event
and continue only with  ENOENT.
 2018-02-12 22:14:59 +01:00
Zdenek Kabelac
0bf836aa14 tidy: prefer not using else after return 
clang-tidy: avoid using  'else' after return - give more readable code,
and also saves indention level.
 2017-07-20 11:18:29 +02:00
Zdenek Kabelac
cd468b6218 dmeventd: debug only subsystemd with # sign 
Reword the logging logic and try to restore previous logging
behavior for 'standalone' running daemon while preserving
debuggable feautures it has gained.

So actual rules:

dmeventd without any '-d' option will syslog all messages
from dmeventd.c it dmeventd plugins.

log_notice()==log_verbose()
log_info()==log_very_verbose()
But to show also log_debug() used has to give '-ddd'.

When user specified '-d, -dd, -ddd, -dddd' it
will also enable tracing of messages from libdm & lib
executed code - which is mainly useful for testing
i.e.: 'dmeventd -fldddd'
 2016-11-03 12:43:09 +01:00
Zdenek Kabelac
33dd1f7747 dmeventd: abort on internal error 
Provide same support for DM_ABORT_ON_INTERNAL_ERRORS we do have
with default libdm logging  as  dmeventd is libdm based tool.
 2016-11-03 12:43:09 +01:00
Zdenek Kabelac
6af26273cb logging: add more log macros 
Introduce macros:

log_level(), log_stderr(), log_once(), log_bypass_report()

For easier and more consisten way how to 'decoder' bits
of info from passed 'level'.

This patch fixes potential problem when 'level' of message
might not have always masked right bits.
 2016-11-03 12:43:09 +01:00
Zdenek Kabelac
af148a9d77 cleanup: avoid gcc warns 
Some older systems may had global declaration to cause gcc warning.
Rename for cases we don't care...
 2016-04-08 20:20:16 +02:00
Zdenek Kabelac
fcbef05aae doc: change fsf address 
Hmm rpmlint suggest fsf is using a different address these days,
so lets keep it up-to-date
 2016-01-21 12:11:37 +01:00
Alasdair G Kergon
94dab390ef dmeventd: Extend checks on client socket. 
Reinstate and extend checks removed by e1b111b02a.

The code has always assumed that only root has access to the directory
containing the fifos and that they are under the complete control of
dmeventd code.  If anything is found not to be as expected, then open()
should certainly not be attempted!
 2015-12-08 00:59:39 +00:00
Zdenek Kabelac
058725c721 dmeventd: fix check for failing open. 
Recent change 2c8d6f5c90
actually droped restart when the reason of failing open is missing
device completely - check for ENOENT now as another reason
to start new dmeventd server  (when there is no systemd to maintain it).
 2015-11-11 19:54:55 +01:00
Zdenek Kabelac
c4c5635870 cleanup: drop unneeded assign 
prio is always assigned later.
 2015-11-09 10:22:52 +01:00
Zdenek Kabelac
e1b111b02a dmeventd: reorder tou 2015-11-09 10:00:33 +01:00
Zdenek Kabelac
8b857bfdc6 libdevmapper-event: fix fifo leak on error path 
Coverity: when _init_client() fails, client fifo could have
been already openned and needs to be closed on error path.
 2015-11-09 10:00:13 +01:00
Zdenek Kabelac
915f0faac1 dmeventd: syslog -> log_xxxxx 
Convert logging of dmeventd to libdm logging macros.
 2015-10-13 14:43:30 +02:00
Zdenek Kabelac
0641e3a5fd libdmevent: add dm_event_log 
Add dm_event_log() logging function.
Controled by dm_event_log_set().
 2015-10-13 14:40:46 +02:00
Alasdair G Kergon
dfe3eb12d0 include: Standardise around new tool.h. 2015-07-06 17:30:18 +01:00
Zdenek Kabelac
6d7f260f92 dmeventd: fix test for select return value 
Do not call read when select return -1 && EINTR.
Also check for return valuer from read() and
abort write function when unexpected error happens.
 2014-08-19 14:33:06 +02:00
Zdenek Kabelac
cbdf63fdd2 cleanup: indent in devmapper-event 
Drop header inclusion - this file is already included.
Shorten code.
 2014-04-30 10:26:30 +02:00
Zdenek Kabelac
816cc94ac1 devmapper-event: always initialize timeout 
Always pass fully initialized timeval struct to select.
 2014-04-30 10:26:29 +02:00
Zdenek Kabelac
6448428d05 cleanup: add some comment indents... 
Just cleanup things
 2014-04-18 16:38:51 +02:00
Zdenek Kabelac
db0045dfc9 devmapper-event: always initialize timeout 
Before calling select, always set all struct members of timeout.
 2014-04-18 16:38:48 +02:00
Zdenek Kabelac
406ec4162f cleanup: use dm_free without extra test 
It's ok to free(NULL).
 2014-03-25 11:22:59 +01:00
Zdenek Kabelac
db71739f42 cleanup: initilization of vars 2014-03-25 11:22:58 +01:00
Zdenek Kabelac
5c9165705a cleanup: indent 2014-03-25 11:22:58 +01:00
Zdenek Kabelac
c7b2c08a6b cleanup: use NULL for pointer reset 2014-03-25 11:22:58 +01:00
Petr Rockai
38457e1be9 libdevmapper-event: Print a deprecation warning for non-default plugins. 2014-02-10 14:52:59 +01:00
Zdenek Kabelac
5bdbaf4ed7 cleanup: convert log_sys_error to log_sys_debug 
Use debug for those error reports which do not lead to error return
call.
 2013-11-28 12:48:01 +01:00
Zdenek Kabelac
6dae237303 dmeventd: fifo init and close cleanup 
Use structure initialization for easier to read code.
Close only descriptors >= 0.
 2013-11-28 12:43:14 +01:00
Zdenek Kabelac
6fa95d17ee dmeventd: move format text to printf 
Instead of passing argument with format string to printf(),
put the string as arg directly.
Also move there remains args to make the code shorter.
 2013-11-22 21:00:51 +01:00
Zdenek Kabelac
47419d21ac cleanup: stack usage 
Shortening code with macros return_0, return_NULL.
Add some missing stack prints in error paths.
 2013-07-01 23:11:14 +02:00
Zdenek Kabelac
a5ad1ee858 dmeventd: return error if device is not found 
Do not return 'ok' status if we have failed to found device.
(Since it looks like the device is monitored)
 2013-04-25 17:33:24 +02:00
Zdenek Kabelac
45f396f2a0 dmeventd: check for msg.data nonnull 
Ensure we will not use  msg.data as NULL for strchr.
 2013-04-21 22:56:59 +02:00
Zdenek Kabelac
15891d366d cleanup: add error message and simplify creation 
Report error for malloc failure, and use zeroed allocation
to initialize handler structure.
 2012-08-23 14:37:38 +02:00
Zdenek Kabelac
516b79299a Fix check for passed in path for dmeventd startup 
Check passed in executable path for dmeventd instead of predefined
compiled in path which is not the thing to be executed.
 2012-03-20 17:38:47 +00:00
Zdenek Kabelac
65cfc5d16d We need longer window for checking read from fifo. 
Seems like some dmeventd startups are taking more time then expected,
so make the time window longer here.
 2012-03-12 14:46:53 +00:00
Zdenek Kabelac
310f54439c More useful debug message 2012-03-01 10:41:48 +00:00
Zdenek Kabelac
c19d86338d Better detection of missing dmeventd fifo connection 2012-02-28 11:03:24 +00:00
Zdenek Kabelac
4d44893d60 Add log_sys_error for close 2012-02-28 10:14:06 +00:00
Zdenek Kabelac
80202ecd98 Detect failing fifo 
If the fifo died because of dmeventd restart - do not wait for 20s
in select  - it will not get better and return error immediately.
 2012-02-15 13:56:47 +00:00
Zdenek Kabelac
74b5744b4b Check for missing reply_uuid 2012-02-13 11:24:09 +00:00
Zdenek Kabelac
8380b37529 Fix message check 
Check pointer from strchr for NULL instead of crash later.
Badly formated message would have crash dmeventd otherwise.
 2012-02-10 15:17:52 +00:00
Alasdair Kergon
c837830f6a report which dev was not found 2011-07-08 12:35:48 +00:00
Petr Rockai
968cdc0066 Add rudimentary versioning to the dmevend protocol, allowing us to detect the 
(protocol) version of the running dmeventd on the client side.

Right now this is only used in dmeventd -R.
 2011-04-04 16:11:09 +00:00
Milan Broz
cbedb99e4c Fix some compile warnings on RHEL5 
- returned char not needed to be explicitly const
- warn if pipe() fails in clvmd (more fixes here needed for error paths...)
- assign (and ignore) read() output in drain buffer
 2011-03-01 20:17:56 +00:00
Zdenek Kabelac
0a9b444a60 Remove dead assignment of 'ret' value 
Variable 'ret' assigned from _do_event() was actually not used and replaced with next
assignment without any read of the returned value.

Code is reformated - so the error path is put in the if() branch and normal
code is put after the 'if' together with FIXME comment.


FIXME lowprio: logging needs to be fixed in this code,
 - multiple log_errors are printed, stacks are missing...
 2011-01-06 10:45:41 +00:00
Zdenek Kabelac
4b1232984b Remove unneeded stack prints after log_error 2011-01-06 09:45:05 +00:00
Zdenek Kabelac
4388a09b0f Detect errors from dm_task_set calls 
Check for errors in dm_task_set calls.
Use  goto_bad macro with stack trace.
Replace  label  failed: with bad:.
 2010-12-22 15:28:44 +00:00
Zdenek Kabelac
d80f8cf41b Fix clang warning for ntohl(*((uint32_t *)buf)) 
We cast (char*) to (uint32_t*) that changes alignment requierements.
For our case the code has been correct as alloca() returns properly
aligned buffer, however this patch make it cleaner and more readable
and avoids warning generation.
 2010-10-25 11:57:06 +00:00
Petr Rockai
d95a85ca36 Implement dmeventd -R, allowing dmeventd to be restarted without losing 
monitoring state.
 2010-10-20 15:12:12 +00:00
Alasdair Kergon
d1e8046f56 Various small cleanups and fixes related to monitoring. 2010-08-16 22:54:35 +00:00
Alasdair Kergon
470c18847d Remove superfluous NULL pointer tests before dm_free from dmeventd. 2010-08-16 18:19:46 +00:00