Zdenek Kabelac
3d90c7fffc
tests: get.sh declare and assign separately
...
Declare and assign separately to avoid masking return values.
Also comment-out currently unused orig variable.
2017-06-29 22:23:17 +02:00
Zdenek Kabelac
834b82b0cd
tests: get.sh double quote
2017-06-29 22:23:17 +02:00
Zdenek Kabelac
d7b3815223
tests: utils.sh separately assign
...
Declare and assign separately to avoid masking return values.
2017-06-29 22:23:17 +02:00
Zdenek Kabelac
cf4b671acd
tests: utils.sh avoid iterating over ls output
2017-06-29 22:23:17 +02:00
Zdenek Kabelac
4697937af4
tests: utils.sh arithmetic
...
expr is antiquated. Consider rewriting this using $((..)), ${} or [[ ]].
$ is unnecessary on arithmetic variables.
2017-06-29 22:23:17 +02:00
Zdenek Kabelac
00957450eb
tests: utils.sh no mixed string array
...
Argument mixes string and array. Use * or separate argument.
2017-06-29 22:23:17 +02:00
Zdenek Kabelac
c396053955
tests: utils.sh double quote
2017-06-29 22:23:17 +02:00
Zdenek Kabelac
b442861f50
tests: lvm-wrapper.sh legacy syntax
2017-06-29 22:23:17 +02:00
Zdenek Kabelac
b1f80512c8
tests: lvm-wrapper.sh double quote
2017-06-29 22:23:17 +02:00
Zdenek Kabelac
32be18959d
tests: inittest.sh double quote and mixing string
2017-06-29 22:23:17 +02:00
Zdenek Kabelac
b45ca523ec
tests: check.sh eliminate useless cat
...
Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
2017-06-29 22:23:17 +02:00
Zdenek Kabelac
51237cb504
tests: check.sh better if
...
Prefer [ p ] || [ q ] as [ p -o q ] is not well defined.
2017-06-29 22:23:17 +02:00
Zdenek Kabelac
db338c2b42
tests: check.sh drop unnecessary $
...
$/${} is unnecessary on arithmetic variables.
2017-06-29 22:23:17 +02:00
Zdenek Kabelac
c0197040a5
tests: check.sh using grep -F
...
fgrep is non-standard and deprecated. Use grep -F instead.
2017-06-29 22:23:17 +02:00
Zdenek Kabelac
824db54128
tests: check.sh no mixing string
...
Argument mixes string and array. Use * or separate argument.
2017-06-29 22:23:17 +02:00
Zdenek Kabelac
810f856c24
tests: check.sh assign separately
...
Declare and assign separately to avoid masking return values.
2017-06-29 22:23:17 +02:00
Zdenek Kabelac
02729202f3
tests: check.sh double quote
2017-06-29 22:23:17 +02:00
Zdenek Kabelac
491fcd2a92
tests: aux.sh fix pid handling
...
Modification of pids is local (to subshell caused by pipeline).
pids was modified in a subshell. That change might be lost.
2017-06-29 22:23:17 +02:00
Zdenek Kabelac
96fcf82ddd
tests: aux.sh add -r to read
2017-06-29 22:23:17 +02:00
Zdenek Kabelac
ec02307e95
tests: aux.sh array assing
...
Assigning an array to a string! Assign as array, or use * instead of @ to concatenate.
2017-06-29 22:23:17 +02:00
Zdenek Kabelac
8a912d6dbc
tests: aux.sh separately assign
...
Declare and assign separately to avoid masking return values.
2017-06-29 22:23:17 +02:00
Zdenek Kabelac
4f63b7e9c1
tests: aux.sh using grep -c
...
Consider using grep -c instead of grep|wc -l.
2017-06-29 22:23:17 +02:00
Zdenek Kabelac
b16ca76260
tests: aux.sh no mixing string
...
Argument mixes string and array. Use * or separate argument.
2017-06-29 22:23:17 +02:00
Zdenek Kabelac
44e530b919
tests: aux.sh drop unnecessary $
...
$/${} is unnecessary on arithmetic variables.
2017-06-29 22:23:16 +02:00
Zdenek Kabelac
474e3cd66d
tests: aux.sh use pgrep
2017-06-29 22:23:16 +02:00
Zdenek Kabelac
72a58ce4b0
tests: aux.sh double quote
2017-06-29 22:23:16 +02:00
Zdenek Kabelac
191dadc623
clvmd_fix_conf.sh: double quote
2017-06-29 22:23:16 +02:00
Zdenek Kabelac
99925d0d41
clvmd_fix_conf.sh: legacy code
...
Use $(..) instead of legacy `..`.
2017-06-29 22:23:16 +02:00
Zdenek Kabelac
afa0bd916e
vgimportclone.sh: do not quote regex
...
Don't quote rhs of =~, it'll match literally rather than as a regex.
2017-06-29 22:23:16 +02:00
Zdenek Kabelac
ef4506069a
vgimportclone.sh: use well defined tests
...
Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
Prefer [ p ] || [ q ] as [ p -o q ] is not well defined.
2017-06-29 22:23:16 +02:00
Zdenek Kabelac
8dc29d7cc7
vgimportclone.sh: drop extra $
...
$/${} is unnecessary on arithmetic variables.
2017-06-29 22:23:16 +02:00
Zdenek Kabelac
16a38dede9
vgimportclone.sh: add -r to read
...
read without -r will mangle backslashes.
2017-06-29 22:23:16 +02:00
Zdenek Kabelac
588b12e71d
vgimportclone.sh: avoid legacy syntax
...
Use $(..) instead of legacy `..`.
2017-06-29 22:23:16 +02:00
Zdenek Kabelac
d745593e89
vgimportclone.sh: cannot trap signal 9
2017-06-29 22:23:16 +02:00
Zdenek Kabelac
275eeb4631
vgimportclone.sh: double quote
2017-06-29 22:23:16 +02:00
Zdenek Kabelac
96a2e00240
vgimportclone.sh: no mixing string and array
...
Argument mixes string and array. Use * or separate argument.
2017-06-29 22:23:16 +02:00
Zdenek Kabelac
4d34bc65dd
lvm2_cluster_activation_red_hat.sh: double quote
2017-06-29 22:23:16 +02:00
Zdenek Kabelac
051c7f88cf
lvmconf_lockingtype2: double quote
2017-06-29 22:23:16 +02:00
Zdenek Kabelac
ef8691a2d2
lvmconf_lockingtype2: preferable syntax
...
Prefer [ p ] || [ q ] as [ p -o q ] is not well defined.
2017-06-29 22:23:16 +02:00
Zdenek Kabelac
030912ec03
lvmdump: replace individual redirects
...
Consider using { cmd1; cmd2; } >> file instead of individual redirects.
2017-06-29 22:23:16 +02:00
Zdenek Kabelac
df57845f61
lvmdump: drop useless cat
...
Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
2017-06-29 22:23:16 +02:00
Zdenek Kabelac
a458065aa1
lvmdump: legacy syntax
...
Use $(..) instead of legacy `..`.
2017-06-29 22:23:16 +02:00
Zdenek Kabelac
a0740f831c
lvmdump: drop extra $
...
$/${} is unnecessary on arithmetic variables.
2017-06-29 22:23:16 +02:00
Zdenek Kabelac
e08e714b68
lvmdump: replace printf
...
Don't use variables in the printf format string. Use printf "..%s.." "$foo".
Advice replaced with plain 'echo'.
2017-06-29 22:23:16 +02:00
Zdenek Kabelac
e292c1a1ca
lvmdump: double quote
...
Double quote to prevent globbing and word splitting.
2017-06-29 22:23:16 +02:00
Zdenek Kabelac
6330e2dc86
lvmconf: prefer well defined and
...
Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
2017-06-29 22:23:16 +02:00
Zdenek Kabelac
ccdb75adcc
lvmconf: double quote
2017-06-29 22:23:16 +02:00
Zdenek Kabelac
de04e36fda
lvmconf: fix test for setting external locking type
...
Fix test for check of set locking lib dir.
2017-06-29 22:23:16 +02:00
Zdenek Kabelac
daa372f78d
blkdeactivate: quote literal
...
This { is literal. Check expression (missing ;/\n?) or quote it.
2017-06-29 22:23:16 +02:00
Zdenek Kabelac
b5fc0d73e5
blkdeactivate: more readable if-then-else-fi
2017-06-29 22:23:16 +02:00
