shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-01-03 05:18:29 +03:00
Code Releases Activity
5,103 Commits 425 Branches 667 Tags 54 MiB
414813e349
Commit Graph

2162 Commits

Author SHA1 Message Date
Zdenek Kabelac
414813e349 Check lv_info() success 
Add log_error message for lv_info failure and exit from futher
processing.

Replace 'leg' occurence in debug message with 'image' which
is used in other messages.
 2010-12-01 13:01:36 +00:00
Zdenek Kabelac
166597d998 Add backtraces for errors 
Add stack;  backtraces when error is reported from dev_set() or
dev_close_immediate().
 2010-12-01 12:56:39 +00:00
Zdenek Kabelac
e3552d738c Check result of vginfo_from_vgname 
Check for some potential internal error.
 2010-12-01 10:39:28 +00:00
Zdenek Kabelac
2937b51eaa Fallback to full rescan for missing device 
Fix bug when NULL could have been passsed as 'data'
to _add_pv_to_list() if 'dev' is NULL.

Now it fallbacks to complete scan.
 2010-12-01 10:33:55 +00:00
Zdenek Kabelac
bf8ea32876 Remove unneeded test for NULL 
Remove check for system_id (it is defined as int8_t[], so cannot be NULL).
 2010-11-30 22:57:35 +00:00
Zdenek Kabelac
81e606ab2c Remove check for lv is NULL 
'lv' is deferenced in the begining of the function so any check
later is not helpful.

Parameters for dev_manager_transien() are marked as nonnull.
 2010-11-30 22:28:06 +00:00
Zdenek Kabelac
14caa4a2d0 Add missing test for failed pool allocation 
Add test for NULL from dm_poll_create.
Reorder dm_pool_destroy() before file close and add label out:.
Avoid leaking file descriptor if the allocation fails.
 2010-11-30 22:23:35 +00:00
Petr Rockai
8191fe4f4a Refactor the percent (mirror sync, snapshot usage) handling code to use 
fixed-point values instead of a combination of a float value and an enum.
 2010-11-30 11:53:31 +00:00
Petr Rockai
97e8048e05 Avoid the automatic MISSING_PV recovery path in commands with special 
MISSING_PV handling (cmd->handles_missing_pvs is set).
 2010-11-30 11:15:54 +00:00
Alasdair Kergon
1415afcdba Fix memory leak when VG allocation policy in metadata is invalid. 
Ignore unrecognised allocation policy found in metadata instead of aborting.
Fix another missing vg_release() in _vg_read_by_vgid.
 2010-11-29 18:35:37 +00:00
Zdenek Kabelac
21ba805499 Fix memory leak in error path 
Nicely hidden memory leak in outf macro error path.
This macro is using out_text() and does automagical return_0.
That would leak tag_buffer allocated memory.

As there was same code for tags output - create _out_tags() function.
 2010-11-29 12:19:58 +00:00
Zdenek Kabelac
dce59eb407 Remove unused 'i' in _pv_analyze_mda_raw 
'i' is unused in the function - remove it.
 2010-11-29 11:16:58 +00:00
Zdenek Kabelac
73e3226012 Remove dead assignment in _lock_for_cluster 
'saved_errno' is not read from this initialization and before its
usage is assigned again before _cluster_free_request() call.
 2010-11-29 11:13:12 +00:00
Zdenek Kabelac
201222ebad Reset vg pointer after release 
Set vg to NULL after releasing it as the following memlock() test may
lead to goto for the second call of vg_release() with the already
released vg pointer.
 2010-11-29 11:08:14 +00:00
Zdenek Kabelac
99aacef51c Fix check for empty system_dir 
Fixing check for zero length system_dir string.
 2010-11-29 10:58:32 +00:00
Petr Rockai
0bc382eae4 All 'size' values of lvm2app properties should be in bytes. 
Fix 'seg_size' to return bytes.

Signed-off-by: Dave Wysochanski <wysochanski@pobox.com>
Reviewed-by: Petr Rockai <prockai@redhat.com>
 2010-11-25 14:39:02 +00:00
Zdenek Kabelac
e8ec0ba2e3 Fix resource leak of dlopened pointer 
Add missing dlclose in _init_formats() error path.
Use return_0 to print stack trace from the call.
 2010-11-24 09:34:34 +00:00
Zdenek Kabelac
0a178d853a Add missing closedir() - fixes resource leak 2010-11-23 15:28:54 +00:00
Zdenek Kabelac
7d11d708d8 Move va_end() so it is also used before error path return 2010-11-23 15:08:57 +00:00
Alasdair Kergon
728074ac83 Suppress 'No PV label' message when removing several PVs without mdas. 2010-11-23 01:55:53 +00:00
Petr Rockai
4543dac58e Add the macro and specific 'get' functions for pvsegs. 
Signed-off-by: Dave Wysochanski <wysochanski@pobox.com>
Reviewed-by: Petr Rockai <prockai@redhat.com>
 2010-11-17 20:11:27 +00:00
Petr Rockai
c1abd569f2 Add the macro and specific 'get' functions for lvsegs. 
Signed-off-by: Dave Wysochanski <wysochanski@pobox.com>
Reviewed-by: Petr Rockai <prockai@redhat.com>
 2010-11-17 20:08:14 +00:00
Petr Rockai
cbff112651 Make value.string const char *, in properties.h, to fix a warning introduced by 
the previous patch set.
 2010-11-17 19:50:15 +00:00
Petr Rockai
fd82d8c129 Add generic infrastructure to internal library to 'set' a property. 
Similar to 'get' property internal functions.
Add specific 'set' function for vg_mda_copies.

Signed-off-by: Dave Wysochanski <wysochanski@pobox.com>
Reviewed-by: Petr Rockai <prockai@redhat.com>
 2010-11-17 19:15:10 +00:00
Alasdair Kergon
10955b8289 Remove tag length restriction and allow / = ! : # & characters. 2010-11-17 10:19:29 +00:00
Alasdair Kergon
f8452d8cfd Support repetition of --addtag and --deltag arguments. 
Add infrastructure for specific cmdline arguments to be repeated in groups.
Split the_args cmdline arguments and values into arg_props and arg_values.
 2010-11-11 17:29:05 +00:00
Zdenek Kabelac
64dff85ce4 Preserve const for char pointer 
Keep char pointers 'const'  (introduced with cling commit).
 2010-11-11 12:32:33 +00:00
Alasdair Kergon
eb82bd0525 Extend cling allocation policy to recognise PV tags (cling_by_tags). 
Add allocation/cling_tag_list to lvm.conf.
 2010-11-09 12:34:40 +00:00
Peter Rajnoha
f7e3a19f75 Clarify error messages when activation fails due to activation filter use. 2010-11-05 18:18:11 +00:00
Zdenek Kabelac
2955b913ea Use new status code from fsadm check 
Patch updates exec_cmd() and adds 3rd parameter with pointer for
status value, so caller might examine returned status code.
If the passed pointer is NULL, behavior is unmodified.

Patch allows to confinue with lvresize if the failure from fsadm check is
caused by mounted filesystem as many of filesystem resize tools do support
online filesystem resize. (originally user had to use flag '-n' to bypass
this filesystem check)
 2010-11-01 14:17:35 +00:00
Zdenek Kabelac
d0604a856d Macro uninitialized_var gives warnings in static analysis 
Deactivate uninitialized_var() macro for clang static analysis.
 2010-10-26 10:04:34 +00:00
Zdenek Kabelac
419d5219cb Fix NULL pointer dereference for too large MDA error path 
Replace dereference of NULL vg with passed vgname to the function
_vg_read_raw_area() in the error path for too large MDA.
 2010-10-26 09:13:13 +00:00
Zdenek Kabelac
962ebfe4b4 Remove bufused for calculation 
As bufused is assigned 0 in preceding source line
clang Idempotent operation
 2010-10-26 08:53:25 +00:00
Dave Wysochanski
a90221d824 Add 'is_integer' flag into internal lvm_property_type. 
Add 'is_integer' flag similar to 'is_string'.
Suggested in review by Petr Rockai.
 2010-10-25 14:08:32 +00:00
Alasdair Kergon
2aa06d73ca pre-release 2010-10-25 13:54:29 +00:00
Zdenek Kabelac
3f329bd02c Use const config node 2010-10-25 13:38:11 +00:00
Zdenek Kabelac
d35c864521 Fix constness warning 
Keep using const pointers.
 2010-10-25 13:36:09 +00:00
Zdenek Kabelac
91e56ffb29 Fix constness warning for _vg_read_by_vgid() uuid usage 2010-10-25 13:35:13 +00:00
Zdenek Kabelac
faa1268182 Fix constness warnings 
After update of device_from_pvid() API fix constness warnings
Also fix info_from_pvid() constness warning for char* usage.
 2010-10-25 13:33:42 +00:00
Zdenek Kabelac
710784945c Use 'const' struct id *pvid for device_from_pvid() 
Update interface for device_from_pvid and use const pointer.
 2010-10-25 13:02:26 +00:00
Zdenek Kabelac
aa4f87d6e3 Switch to char* arithmetic from void* 2010-10-25 13:00:35 +00:00
Alasdair Kergon
eacd3a0916 fix header #defines 2010-10-25 12:01:59 +00:00
Alasdair Kergon
b83af51668 Add global/metadata_read_only to use unrepaired metadata in read-only cmds. 2010-10-25 11:20:54 +00:00
Alasdair Kergon
727d065f6e restrict last checkin to devs consisting entirely of error target 2010-10-25 10:37:34 +00:00
Mike Snitzer
06808d3357 Never scan a device which is using the error target 
A merged snapshot's DM device is made to use the "error" target as part
of lvm's transaction to merge a snapshot.  This snapshot merge use-case
aside, any device using the error target shouldn't be scanned.
 2010-10-24 17:36:58 +00:00
Dave Wysochanski
12873010e5 Add lv_get_property() internal lvm function. 2010-10-21 18:51:16 +00:00
Dave Wysochanski
60fc088d70 Rename fields in lvm_property_type. 
Based on review comments, rename a few fields in lvm_property_type.
In particular, change 'is_writeable' to 'is_settable', which is
more intuitive to the intent of the bitfield (a 'set' function
exists for this field/property).  Also, remove the char array
for 'id' - unnecessary as we can just use the string passed in
to do the strcmp.  Finally rename the union members from n_val
to 'integer' and 's_val' to 'string'.
 2010-10-21 14:49:43 +00:00
Dave Wysochanski
d53d92f2e1 Add lv_read_ahead and lv_kernel_read_ahead 'get' functions. 2010-10-21 14:49:31 +00:00
Dave Wysochanski
f1fc310730 Refactor and add code for (lv) 'lv_origin' get function. 2010-10-21 14:49:20 +00:00
Dave Wysochanski
6103254393 Refactor and add code for (lv) 'lv_name' get function. 2010-10-21 14:49:10 +00:00