David Teigland
15eaf703fc
commands: fix memory debug for cmd defs
...
Clean up the handling of memory used for cmd defs
so it doesn't trip up memory debugging.
Allocate memory for commands[] from libmem.
Free temporary memory used by define_commands()
at the end of the function.
Clear all the command def state in in lvm_fin().
2017-05-01 15:27:14 -05:00
David Teigland
54726a4950
fix running commands from a script file
...
Using any arg with a command name in a script file
would cause the command to fail.
The name of the script file being executed was being passed
to lvm_register_commands() and define_commands(), which
prevented command defs from being defined (simple commands
were still being defined only by name which was enough for those
to still work when run trivially with no args).
2017-04-28 16:51:04 -05:00
David Teigland
c73b9f062c
WHATS_NEW: pvcreate prompt
2017-04-28 09:06:41 -05:00
Alasdair G Kergon
1764524b06
WHATS_NEW: pvcreate --setphysicalvolumesize
2017-04-28 14:34:26 +01:00
David Teigland
86b9c23dbe
commands: improve syntax suggestion when no command is found
...
The logic for suggesting the nearest valid command syntax
was missing the simplest case. If a command has only one
valid syntax, that is the one we should suggest. (We were
suggesting nothing in this case.)
2017-04-27 14:21:01 -05:00
David Teigland
4f9ff14508
pvcreate: add prompt when setting dev size
...
If the device size does not match the size requested
by --setphysicalvolumesize, then prompt the user.
Make the pvcreate checking/prompting code handle
multiple prompts for the same device, since the
new prompt can be in addition to the existing
prompt when the PV is in a VG.
2017-04-27 13:25:41 -05:00
Marian Csontos
5cf51fb2f7
dbus: log_debug needs qualifier
...
Adding qualifier makes the only unqualified log_debug occurence
consistent with other uses in the same file.
Other possible ways to fix this:
- using `from .utils import log_debug`
- moving the line below `from . import utils` line
2017-04-27 18:16:17 +02:00
Alasdair G Kergon
0e3c16af56
pvresize: Missing a message on error path.
2017-04-27 15:00:41 +01:00
Heinz Mauelshagen
33afe2ca76
test: add -y to raid1 up conversions
2017-04-27 15:56:58 +02:00
Heinz Mauelshagen
0516447978
lvconvert: preserve region size on raid1 image count changes (v2)
...
Unless a change of the regionsize is requested via "lvconvert -R N ...",
keep the region size when the number of images changes in a raid1 LV.
Related: rhbz1443705
2017-04-27 15:52:25 +02:00
Marian Csontos
14c84c79db
test: Update pattern to match code
...
Fix commit a3fdc966b5
2017-04-27 15:30:03 +02:00
Heinz Mauelshagen
af47ec9f51
Revert "lvconvert: preserve region size on raid1 image count changes"
...
This reverts commit 8333d5a969
.
2017-04-27 15:29:03 +02:00
Alasdair G Kergon
813bcb24f0
test: Add -y to pvresize --setphysicalvolumesize
2017-04-27 02:57:59 +01:00
Alasdair G Kergon
cbc69f8c69
pvresize: Prompt when non-default size supplied.
...
Seek confirmation before changing the PV size to one that differs
from the underlying block device.
2017-04-27 02:36:34 +01:00
Jonathan Brassow
78a0b4a08a
typo: s/extends/extents/ in lvmthin man page
...
bug 1439905
2017-04-26 15:49:28 -05:00
Tony Asleson
0f31f10ac5
lvmdbusd: Improve error msg to include PV
...
Include PV device path when we believe it already exists.
2017-04-26 07:31:08 -05:00
Tony Asleson
e50fb06792
lvmdbustest.py: Add nested testing
...
Make sure when a LV is used as a PV the dbus service works correctly.
Signed-off-by: Tony Asleson <tasleson@redhat.com>
2017-04-26 07:30:45 -05:00
Tony Asleson
6de3a9b4d0
lvmdbustest.py: Handle nested setUp & tearDown
...
Handle cleaning up correctly if a LV is used as a PV.
2017-04-26 07:10:18 -05:00
Tony Asleson
e78329e281
lvmdbusd: Make sure we don't hang on lvcreate
...
If we happen to create a lv that has a previous signature we hang on y/n
prompt, add '--yes'.
2017-04-26 07:10:18 -05:00
David Teigland
a3fdc966b5
commands: improve error messages for rules
...
Make the error messages more consistent,
and use less code-centric wording.
2017-04-25 15:49:58 -05:00
Heinz Mauelshagen
c534a7bcc9
lvconvert: FIXME
...
Add FIXME to move error path processing out of tool into library.
Related: rhbz1437653
2017-04-24 18:56:36 +02:00
Heinz Mauelshagen
aa1d5d5c89
lvconvert: fix inactive mirror up converting regression
...
Up converting an inactive mirror with insufficient
devs results in an over concerned warning.
Resolves: rhbz1437653
2017-04-24 17:44:54 +02:00
Heinz Mauelshagen
8333d5a969
lvconvert: preserve region size on raid1 image count changes
...
Unless a change of the regionsize is requested via "lvconvert -R N ...",
keep the region size when the number of images changes in a raid1 LV.
Resolves: rhbz1443705
2017-04-22 02:04:49 +02:00
Heinz Mauelshagen
8f305f025e
raid: handle insufficent PVs on takeover to/from raid4
...
Commit 7bc85177b0
felt short relative to striped/raid0* -> raid4
and raid4 -> raid6.
Related: rhbz1438013
2017-04-22 01:19:44 +02:00
Heinz Mauelshagen
97a5fa4b87
raid: avoid superfluous variable
2017-04-22 00:50:36 +02:00
Heinz Mauelshagen
effeb2b93d
test: add raid4 to upconvert allocation failure tests
2017-04-22 00:43:31 +02:00
Heinz Mauelshagen
149e4fa04b
test: consider changed default
...
commit b81b4aad24
raised the region size so demand the sizes the
test checks for.
2017-04-22 00:42:09 +02:00
Heinz Mauelshagen
7c7122a3b1
test: add upconvert allocation failure tests
2017-04-21 20:57:31 +02:00
Heinz Mauelshagen
d48b816764
test: also prevent lvconvert-raid-reshape.sh on single core
2017-04-21 02:17:55 +02:00
Heinz Mauelshagen
a004cceed2
test: Adjust previous commit
...
Change have_single_core to have_multi_core and go back to || logic in related test scripts.
2017-04-21 01:21:24 +02:00
Heinz Mauelshagen
18bf954801
test: Fix skip some reshape tests that hang on single core machines
...
Fix commit c7fb0cb861
.
2017-04-20 21:45:56 +02:00
Heinz Mauelshagen
0c2fd133d7
raid: remove double minimum area check on takeover
2017-04-20 21:35:06 +02:00
Heinz Mauelshagen
d8a63f446e
raid: define return value on error paths
2017-04-20 21:32:40 +02:00
Heinz Mauelshagen
5fb5717402
raid: avoid superfluous reload on takeover
...
Allow any reset rebuild flags to trigger the second update on takeover.
Use descriptive callback names.
Fix typo and add comments.
2017-04-20 21:18:27 +02:00
Alasdair G Kergon
c7fb0cb861
test: Skip some reshape tests that hang on single core machines
...
Skip hanging raid reshape tests until https://bugzilla.redhat.com/1443999
is fixed
2017-04-20 20:05:07 +01:00
Heinz Mauelshagen
83cdba75bd
mirror/raid: display adjusted region size with units
...
Display adjusted region size in units (e.g. "4.00 MiB") rather than sectors.
2017-04-20 20:42:21 +02:00
David Teigland
b9d10857b2
man: quote the word no
2017-04-18 15:56:48 -05:00
Alasdair G Kergon
658d524d26
configure: Fix notify-dbus and dmfilemapd options.
2017-04-18 20:37:53 +01:00
David Teigland
2d9097e9ca
WHATS_NEW: configure option enable-lvmlockd
2017-04-18 12:58:18 -05:00
David Teigland
a5256d1353
spec: rename lockd to lvmlockd
2017-04-18 11:22:07 -05:00
David Teigland
a41a8430d6
configure: rename lockd to lvmlockd
2017-04-18 11:18:07 -05:00
Zdenek Kabelac
aa25cfe084
test: correcting binary usage
...
Ensure 'test suite' run uses fsadm and dmeventd from compiled dir,
while for 'rpm' installed test use binaries installed in system.
2017-04-14 01:03:18 +02:00
Heinz Mauelshagen
15c3ad9641
lvconvert: typo in message
2017-04-13 22:19:29 +02:00
David Teigland
0ea9a15612
tests: use raid_region_size 512
...
given the new default from 5ae7a016b8
2017-04-13 14:21:34 -05:00
Heinz Mauelshagen
b81b4aad24
WHATS_NEW: raise region_size default
2017-04-13 17:49:58 +02:00
Alasdair G Kergon
c6a6ce6cd5
conf: Remove exec_prefix from confdir.
...
Some distros now want to put /etc outside prefix/exec_prefix.
2017-04-13 16:21:29 +01:00
Heinz Mauelshagen
5ae7a016b8
lvcreate: raise default raid regionsize to 2MiB
...
Related: rhbz1392947.
2017-04-13 16:10:49 +02:00
Alasdair G Kergon
4547218a7d
conf: Add missing prefix to installation directory.
...
Our Makefiles also support systems that set the installation prefix
at configuration time - the use of DESTDIR is not required.
2017-04-13 02:17:27 +01:00
Alasdair G Kergon
ae7f696d53
post-release
2017-04-13 01:47:47 +01:00
Alasdair G Kergon
b9a16fe73b
pre-release
2017-04-13 00:43:31 +01:00