shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-02-27 01:57:55 +03:00
Code Releases Activity
6,390 Commits 432 Branches 668 Tags
Commit Graph

2751 Commits

Author SHA1 Message Date
Zdenek Kabelac
6d29fe0f33 Thin add pool_below_threshold 
Test both data and metadata percent usage.
 2012-02-08 13:05:38 +00:00
Zdenek Kabelac
70e3728446 Fix test for lv_snapshot_percent 
Do not check for PERCENT_MERGE_FAILED if the lv_snapshot_percent() failed.
(test for snap_percent would be testing uninitialized value).
 2012-02-08 13:02:07 +00:00
Zdenek Kabelac
74c7c69d34 Some fixmes 
'len' calculation is unused ?
Unreachable code could be removed or moved upward ?
 2012-02-08 12:57:15 +00:00
Zdenek Kabelac
7ce534f911 Switch to return void 
List delete cannot fail, so there is no reason to test for error.
 2012-02-08 12:52:58 +00:00
Zdenek Kabelac
f03f322f13 Use dm_snprintf and improve error handling 
Add standard error reporting with error logging.
Use plain alloc instead of zalloc for string buffer.
Use dm_snprintf with valid test for <0.
 2012-02-08 12:50:10 +00:00
Zdenek Kabelac
c929a0b3c8 Add range test for device number 
Check the output of atoi is in valid range.
 2012-02-08 12:48:14 +00:00
Zdenek Kabelac
84facc4fa5 Replace snprintf with dm_snprintf 
snprintf testing for negative is replaced with dm_snprintf where this
test really works.
Add missing test for result of dm_snprintf().
 2012-02-08 11:40:02 +00:00
Zdenek Kabelac
962fd76f26 Move done jump lower 
Since before 'goto done' is bufused zeroed, it would otherwise write 1
byte in front of buffer.
 2012-02-08 11:31:29 +00:00
Zdenek Kabelac
6e40adde76 Add boundary test for number of mirror devs and logs 
As atoi may return negative value - test for both limits.
Test log_args for limits before calling alloca().
Code from dmeventd mirror plugin should probably share same code as
we have in mirrored.c.
 2012-02-08 11:29:13 +00:00
Zdenek Kabelac
e6b610e8ed Check that whole locking_dir fits _lock_dir buffer 2012-02-08 11:17:34 +00:00
Zdenek Kabelac
bb0862fbb4 Move close few lines 
Since the function dev_close() has code path, which really could close
file (for unlocked vg) and destroy dev handler, stay on safe side and move
the close few lines later, even our current use case shouldn't trigger
such scenario.
 2012-02-08 11:15:38 +00:00
Zdenek Kabelac
e2d2f6c7b7 Use dm_list_iterate_items_safe 
And avoid direct access to list member variables.
Inline _free_li().
 2012-02-08 11:12:18 +00:00
Zdenek Kabelac
4443aa41cc Ensure strncpy() function always ends with '\0' 
Since last character needs to be \0 for string,
pass buffer size smaller by 1 byte.
 2012-02-08 11:05:04 +00:00
Zdenek Kabelac
328ed80160 Fix resource leaks for failing allocation 
In case, something would fail during format initialization,
return allocated memory.
 2012-02-08 10:49:36 +00:00
Zdenek Kabelac
582c94aa21 Release allocated resources in error path 
If composite_filter_create() fails, release filters.
 2012-02-08 10:46:24 +00:00
Zdenek Kabelac
38188ff8aa Check result of lstat 
If lstat returns errno different from ENOENT, do not use the content of
struct stat 'buf'.
 2012-02-08 10:43:42 +00:00
Alasdair Kergon
759f5b3349 Adjust comments 2012-02-01 15:05:53 +00:00
Zdenek Kabelac
433c583cd7 Add synchornization point in mirror log init. 
Put extra sync point when mirror log is deactivated and before
it's activated for the second time.
 2012-02-01 13:50:36 +00:00
Zdenek Kabelac
02f6f4902f Disable partial activation for thin LVs and LVs with all missing segments 
Count number of error and existing areas and if there is no existing area
for the LV avoid its activation.

Always disable partial activatio for thin volumes.

For mirrors currently put in hack to let it pass with a special name
since current mirror code needs to activate such LV during some operations.
 2012-02-01 13:47:27 +00:00
Zdenek Kabelac
90fd0f5b42 Avoid warning for small pv_min_size 
Do not print warning for pv_min_size set in range between 512KB and 2MB.
 2012-02-01 13:42:18 +00:00
Zdenek Kabelac
8bec4f1a79 Minor consistency update for debugging messages 
Use mlock/munlock for debugging lines.
 2012-02-01 10:48:22 +00:00
Alasdair Kergon
1228bcaa0d lost line 2012-02-01 02:11:43 +00:00
Alasdair Kergon
b94b757e1e Track unreserved space for all alloc policies and then permit NORMAL to place 
log and data on same single PV.
 2012-02-01 02:10:45 +00:00
Alasdair Kergon
8416129244 Automatically detect whether corosync clvmd needs to use confdb or cmap. (fabio) 2012-01-31 21:21:53 +00:00
Zdenek Kabelac
b329581e8e Fix data% reporting 
For reading % of mapped size of thin volume use as origin for
old style snapshot '-real' device needs to be queried.
Fix log_error report given for lvs -a in this case.
 2012-01-28 20:12:26 +00:00
Zdenek Kabelac
6f9deb5b47 Thin for_each_sub_lv 
Adapt to scan thin dependency LVs
 2012-01-26 21:39:32 +00:00
Alasdair Kergon
f47f37485e pre-release 2012-01-26 14:02:42 +00:00
Zdenek Kabelac
0f5dc427f6 Set missing header define 2012-01-25 22:37:48 +00:00
Zdenek Kabelac
4e9ef2eea3 Instrument code that pointer are already released 
Set pointers to NULL since on the function exit they are no longer valid.
 2012-01-25 22:35:36 +00:00
Zdenek Kabelac
381deeed8f Fix missing dmt destructor 
Also always initialize maj,min,patchlevel when success is returned.
 2012-01-25 22:16:04 +00:00
Zdenek Kabelac
6f37aa5e65 Free allocated segment type in error path 2012-01-25 21:54:00 +00:00
Zdenek Kabelac
5d1d269f45 Check for correctness of uint64 value if exists 2012-01-25 21:43:51 +00:00
Alasdair Kergon
1835cb731d & -> && 2012-01-25 17:14:56 +00:00
Zdenek Kabelac
ab418f0317 Fix compilation with disabled devmapper 
During release preparation things has changed, so making sure
we are compilable with --disable-devmapper.
 2012-01-25 13:12:59 +00:00
Zdenek Kabelac
4fb4548a57 Thin read percent info from layered device 
Since we only need layered device - check for tpool device presence,
so user doesn't need to activate thin pool explicitely for percent info.
 2012-01-25 13:11:52 +00:00
Zdenek Kabelac
ec2012f736 Rename origin_only to more generic use_layer flag 
Since now we have more layered devices i.e. thin volumes - support
selection of layer via flag.
 2012-01-25 13:10:26 +00:00
Zdenek Kabelac
500806dda9 Update verbose lvs to print metadata_percent info 
Update lvs  -o fields in WHATS_NEW.
 2012-01-25 11:32:41 +00:00
Zdenek Kabelac
7e134dfb8e Thin clear stacked message for thin pool 
Before removing thin pool LV always make sure, stacked message
for previous run are cleared - but allow to remove any
device that should have been created
(i.e. creation of snapshot failed - so the message for snapshot creation
may be replaced with delete message within unfinished transaction).

Also commit messages after lv remove - so free space is released in pool.
 2012-01-25 11:27:42 +00:00
Alasdair Kergon
dee7712483 Make commented out code more obvious 2012-01-25 11:10:06 +00:00
Zdenek Kabelac
cfd3d9413b Thin skip activation when there are no thin message 
If the list with thin messages is empty, do not touch thin pool device.
 2012-01-25 09:17:15 +00:00
Zdenek Kabelac
5feef4f92b Thin correct activation order 
When the message is passed only in resume path the order needs
to be corrected.
 2012-01-25 09:15:44 +00:00
Zdenek Kabelac
9644179f39 Thin use suspend/resume_lv_origin 
Use origin_only support for thin volume when thin snapshot is created.
 2012-01-25 09:14:25 +00:00
Zdenek Kabelac
9142bc74bb Thin use origin_only for thin pools as well 
Extend the usage of origin_only flag to allow resume of thin pool LV
(when it's active) to pass only the messages.

origin_only flag will skip detection of already resumed tree for thin_pool,
so we do not need to suspend the tree and we just send messages.
 2012-01-25 09:13:10 +00:00
Zdenek Kabelac
9518d362ab Thin add support for origin_only suspend of thin volumes 
Pass in the origin_only flag also for thin volumes - but curently the flag
is not used to its best.

FIXME: achieve the state where only  thin volume snapshot origin is
suspended without its childrens -  let's explore whether this may
happen automatically inside libdm (might be generic for other targets).
So the code would not need to annotate the node for this.
 2012-01-25 09:10:13 +00:00
Zdenek Kabelac
529267fe5d Thin add messages only for activation tree 
Extend lv_activate_opts with bool flag to know for which purpose
dtree is created - and add message only for activation tree
(since that's the only place that may send them).

Extend validation check for thin snapshot creation and test whether
active snapshot origin is suspended before its snapshot is created
(useful in recover scenarios) -  in this case also detect, whether
transaction has been already completed and avoid such suspend check
failure in that case.
 2012-01-25 09:06:43 +00:00
Zdenek Kabelac
c3606d4127 Thin check for lv_thin_pool_percent error status 
Check has been missing.
 2012-01-25 09:02:35 +00:00
Zdenek Kabelac
fd3e9e102d lv_info using -real layer only for origin_only LV 
If the origin_only flag is passed for non lv_is_origin LVs,
the extension is not added.

Thin volumes may also use origin_only flag.
 2012-01-25 09:00:18 +00:00
Zdenek Kabelac
7264da9af1 Thin prevent removal of its data and metadata LVs 
LVs cannot be removed while there are linked to thin pool.
(Gives better error message, than validation).
 2012-01-25 08:57:25 +00:00
Zdenek Kabelac
c0f8f6270e Thin fix transaction_id incrementation and code refactoring 
Add pool_has_message and use it in attach_pool_message.
Also update header to make more obvious which segment type is
expected as parameter.
Rename  'read_only' to  'no_update' (no auto update transaction_id)
to better fit how it's used.
Fix problem when there was only one stacked message replaced with delete
message that caused unwanted transaction_id increase.
 2012-01-25 08:55:19 +00:00
Zdenek Kabelac
13c67c55af Comment cleanups 
Move comment where it applies and remove unused attribe when the var
is actually used.
 2012-01-25 08:51:29 +00:00