Dave Wysochanski
f18ef24471
Refactor lvcreate mirror parameter validation.
2007-09-24 13:29:49 +00:00
Dave Wysochanski
479921f1ef
Refactor lvcreate stripe parameter validation.
2007-09-24 13:25:31 +00:00
Jim Meyering
f955ed718f
Don't emit a trailing newline to stderr.
...
* tools/lvmcmdline.c (_short_usage): Remove trailing "\n".
Spotted by Alasdair G. Kergon.
Author: Jim Meyering <jim@meyering.net>
2007-09-21 18:43:55 +00:00
Jim Meyering
01c2ec4be5
Print --help output to stdout, not stderr.
...
* tools/lvmcmdline.c (_usage): Use log_print, not log_error.
Author: Jim Meyering <jim@meyering.net>
2007-09-21 18:06:56 +00:00
Jim Meyering
60c453a2e2
After a diagnostic, suggest --help, rather than printing all --help output.
...
Print just one line:
Use `COMMAND --help' for more information.
after "real" diagnostic(s), rather than all of the usage lines.
Otherwise, the 30-40+ lines of --help output could obscure the real diagnostic.
Author: Jim Meyering <jim@meyering.net>
2007-09-21 18:06:33 +00:00
Jim Meyering
7f8f8bfa09
Correct typo in comments: s/is part of the LVM2/is part of LVM2/.
...
Signed-off-by: Jim Meyering <jim@meyering.net>
Author: Jim Meyering <jim@meyering.net>
2007-09-21 10:16:45 +00:00
Dave Wysochanski
dfef7f6942
Add %PVS extents option to lvresize, lvextend, and lvcreate.
2007-09-20 21:39:08 +00:00
Alasdair Kergon
13aba0817b
Remove no-longer-correct restrictions on PV arg count with stripes/mirrors.
...
[E.g. They fail if tags or --alloc anywhere used.]
2007-09-17 17:18:37 +00:00
Jim Meyering
66e941e83f
Avoid static link failure with some SELinux libraries.
...
Author: Jim Meyering <jim@meyering.net>
2007-09-12 16:54:23 +00:00
Jim Meyering
3851b7a364
Diagnose invalid PE values given on the pvmove command line (64-bit systems).
...
* tools/toollib.c (xstrtouint32): New function.
(_parse_pes): Use xstrtouint32; don't cast strtoul's unsigned
long to uint32_t. Detect overflow.
Author: Jim Meyering <jim@meyering.net>
2007-09-11 20:12:54 +00:00
Dave Wysochanski
1102c4ee95
Fix last checkin
2007-09-06 22:35:01 +00:00
Dave Wysochanski
406a97546a
Fixup _lvresize error return codes and modularize function
2007-09-06 21:08:16 +00:00
Dave Wysochanski
e38a476e72
prepare to move guts of vgrename into library function
2007-08-31 19:09:49 +00:00
Dave Wysochanski
c6ea067fed
move guts of pvresize into library
2007-08-30 20:30:41 +00:00
Dave Wysochanski
4463d20448
prepare to move guts of pvresize into library
2007-08-30 20:16:01 +00:00
Alasdair Kergon
2b849ab4d1
Avoid error when --corelog is provided without --mirrorlog. (2.02.28)
...
Correct --mirrorlog argument name in man pages (not --log).
2007-08-30 19:34:19 +00:00
Jonathan Earl Brassow
a2cb3d17a7
When mirrors are created with the --nosync option, a status flag
...
(MIRROR_NOTSYNCED) is added to the LVM metadata. This flag is
not cleared when converting to linear. Subsequently, if you
up-convert the linear to a mirror, the flag remains - even though
an up-convert will always force a complete resync.
2007-08-29 20:19:11 +00:00
Dave Wysochanski
f603fe64bd
Modify lvremove to prompt for removal if LV active on other cluster nodes.
...
Add '-f' to vgremove to force removal of VG even if LVs exist.
Update vgremove man page for '-f'.
2007-08-28 16:14:49 +00:00
Alasdair Kergon
e935d21752
Introduce VG_GLOBAL lock type for vgscan/pvscan to trigger clvmd -R.
2007-08-23 15:02:26 +00:00
Alasdair Kergon
3b3948f1d2
Change lvconvert_mirrors to use mirror segtype not striped.
2007-08-22 20:03:46 +00:00
Alasdair Kergon
ea041b12f1
Fix lvconvert_mirrors detection of number of existing mirrors.
2007-08-22 19:32:39 +00:00
Alasdair Kergon
21bc366486
Clean up numerous compiler warnings that crept in recently.
...
Remove several unused parameters from _allocate().
2007-08-22 14:38:18 +00:00
Alasdair Kergon
91953ca3aa
Fix (C) !
2007-08-21 19:56:18 +00:00
Alasdair Kergon
edb3374d32
Clean up mirrorlog argument processing.
...
Only permit --force, --verbose and --debug arguments to be repeated.
2007-08-21 19:46:36 +00:00
Dave Wysochanski
16669b5aa0
Move guts of vgremove into lvm library.
...
Include archiver.h in metadata.c as a result of prior move.
2007-08-21 17:38:20 +00:00
Dave Wysochanski
3d33abbb8c
Prepare to move guts of vgremove into lvm library.
...
Fixup force_t.
2007-08-21 16:40:33 +00:00
Alasdair Kergon
147d5faccf
Fix inconsistent licence notices: executables are GPLv2; libraries LGPLv2.1.
2007-08-21 16:26:07 +00:00
Alasdair Kergon
be6845999b
Fix inconsistent licence notices: executables are GPLv2; libraries LGPLv2.1.
2007-08-20 20:55:30 +00:00
Dave Wysochanski
cc78b9800d
Move lv_remove_single() into library (lv_manip.c, metadata-exported.h).
...
Move yes_no_prompt() into library (display.c, display.h).
Fixup includes as a result of movement of prior two functions.
Fixup force_t enum to be more descriptive.
2007-08-20 17:04:53 +00:00
Dave Wysochanski
9eb05d9761
Prepare to move guts of lvremove into lvm library
2007-08-20 16:16:54 +00:00
Dave Wysochanski
62af220c9e
Fix "lvconvert -s" from always failing with argument error message.
...
Patch by Jun'ichi Nomura <j-nomura@ce.jp.nec.com>.
2007-08-10 13:33:49 +00:00
Jonathan Earl Brassow
64119287c3
- change new log_ARG variable to more explicit mirrorlog_ARG.
2007-08-09 21:25:08 +00:00
Jim Meyering
08c9ff434b
Add "const" attributes where possible: first cut.
2007-08-07 09:06:05 +00:00
Dave Wysochanski
b7cd307f9b
Factor out core of lvrename to lv_rename library function.
...
Patch by Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
2007-08-03 21:22:10 +00:00
Jonathan Earl Brassow
19583d115c
This patch changes the arguments that specify the mirror
...
log type. Previously, we had a '--corelog' argument that
would change the default type from 'disk' to 'core'. I
think that creates too much confusion - especially when
doing conversions on mirrors.
The new argument '--log' takes either "disk" or "core"
as a parameter. This could be expanded in the future
for additional logging types as well.
Examples:
# Creating a 2-way mirror
$> lvcreate -m1 ... # implicitly use default disk logging
$> lvcreate -m1 --log disk ... # explicit disk logging
$> lvcreate -m1 --log core ... # specify core logging
$> lvcreate -m1 --corelog ... # old way still works
# Conversion examples
$> lvconvert --log core ... # convert to core logging
$> lvconvert --log disk ... # convert to disk logging
$> lvconvert -mX --corelog ... # old way still works
$> lvconvert -mX ... # old way of converting to disk logging still works
Changes are reflected in the man pages.
2007-08-01 21:01:06 +00:00
Jonathan Earl Brassow
579d086d7a
- cleanup excessive indentation in tools/lvconvert.c:lvconvert_mirrors
2007-08-01 20:54:28 +00:00
Dave Wysochanski
0c8b215a60
Update lvconvert and lvrename to use vg_lock_and_read
2007-07-23 22:20:42 +00:00
Dave Wysochanski
d2f218cc46
Fix error introduced with previous checkin
2007-07-23 21:10:36 +00:00
Dave Wysochanski
4f629c3bba
Add CORRECT_INCONSISTENT and FAIL_INCONSISTENT flags to vg_lock_and_read
2007-07-23 21:03:42 +00:00
Dave Wysochanski
891c3d298b
Add vg_lock_and_read() external library function.
2007-07-23 17:27:55 +00:00
Jim Meyering
6c35e3c84c
Eliminate uses of strdup+basename. Use last_path_component instead.
...
* lib/misc/util.c, lib/misc/util.h (last_path_component): New files.
* lib/Makefile.in (SOURCES): Add misc/util.c.
* lib/misc/lib.h: Include "util.h".
* tools/fsadm/fsadm.c: Include "util.h". (_usage): Use last_path_component,
not basename.
* tools/lvmcmdline.c (_find_command, lvm2_main): Likewise.
* include/.symlinks: Add lib/misc/util.h.
2007-07-20 15:48:39 +00:00
Alasdair Kergon
03eee0e2ed
Split metadata-external.h out from metadata.h for the tools to use.
2007-07-18 15:38:58 +00:00
Milan Broz
5b7d162947
Fix snapshot cow area deactivation if origin is not active. (2.02.13)
2007-07-17 16:13:12 +00:00
Alasdair Kergon
fb697f281b
Call dev_iter_destroy() if _process_all_devs() is interrupted by sigint.
2007-07-10 17:51:26 +00:00
Milan Broz
b9567c9561
Fix vgsplit if splitting all PVs from VG.
2007-06-28 17:59:34 +00:00
Petr Rockai
e7ddf4168d
Make warnings go to stderr. Change log_warn to that effect, log_print
...
continues to send messages to stdout.
2007-06-28 17:33:44 +00:00
Bryn M. Reeves
933b1e9b8f
Fix lvmdiskscan volume reporting when run in the lvm shell
2007-06-25 13:19:37 +00:00
Alasdair Kergon
ef4ed892da
revert accidental change
2007-06-19 16:50:38 +00:00
Alasdair Kergon
64f0efd33f
Fix dmsetup -o devno string termination. (1.02.20)
2007-06-19 15:47:20 +00:00
Milan Broz
86df68f370
Fix missing lvm_shell symbol in lvm2cmd library. (2.02.23)
2007-06-19 10:51:51 +00:00
Dave Wysochanski
d6b1de30fe
Convert vg->status checks to use vg_check_status function.\nRename status_flags to status in vg_check_status.
2007-06-19 04:36:12 +00:00
Dave Wysochanski
69483a8aaf
Add vg_status function and clean up vg->status in tools directory
2007-06-19 04:23:32 +00:00
Dave Wysochanski
1f54709ee6
Make vg_extend() format_instance * parameter internal to vg_extend()
2007-06-19 00:33:43 +00:00
Alasdair Kergon
53c774b948
Add --ignoremonitoring to disable all dmeventd interaction.
2007-06-18 14:14:33 +00:00
Dave Wysochanski
ff77bb1ab6
Remove get_ prefix from get_pv_* functions
2007-06-15 22:16:55 +00:00
Alasdair Kergon
117d85978a
Fix default dmsetup report buffering and add --unbuffered.
...
Add tree-based and dependency fields to dmsetup reports.
2007-06-15 18:20:28 +00:00
Petr Rockai
7379c67839
Allow keyboard interrupts in yes_no_prompt(). Add code to toollib.c
...
loops and to pvcreate.c, lvchange.c and lvresize.c to handle
interrupted prompts.
2007-06-15 10:11:14 +00:00
Dave Wysochanski
fcd444b4e1
Fix inverted logic on last checkin for pvremove
2007-06-14 15:51:36 +00:00
Dave Wysochanski
3df2c388b1
convert pv->vg_name[0] to \!is_orphan(pv)
2007-06-14 15:48:05 +00:00
Dave Wysochanski
b5c344937b
Convert pv->vg_name to get_pv_vg_name
2007-06-14 15:25:36 +00:00
Dave Wysochanski
7f5f9b02e2
Convert pv->vg_name to get_pv_vg_name
2007-06-13 23:53:38 +00:00
Dave Wysochanski
c29f3efd43
Convert pv->status to get_pv_status
2007-06-13 23:33:45 +00:00
Dave Wysochanski
b7dd5ac374
Convert pv->dev to get_pv_dev
2007-06-13 23:29:33 +00:00
Dave Wysochanski
9dcbe73897
Convert pv->size to get_pv_size
2007-06-13 23:02:51 +00:00
Dave Wysochanski
becc177dac
Convert existing_pv dereferences to get_pv_*
2007-06-13 22:58:32 +00:00
Dave Wysochanski
70121705ba
Convert pv->pe_size to get_pv_pe_size
2007-06-13 22:30:26 +00:00
Dave Wysochanski
1f72bbcaa7
Convert pv->pe_start to get_pv_pe_start
2007-06-13 22:16:27 +00:00
Dave Wysochanski
ec26c285c2
Convert pv->pe_count to get_pv_pe_count
2007-06-13 22:11:29 +00:00
Dave Wysochanski
aeea47205b
Convert pv->pe_alloc_count to get_pv_pe_alloc_count
2007-06-13 22:04:45 +00:00
Dave Wysochanski
7da624db7b
Fix a couple benign warnings by adding variable initializations.
2007-06-13 15:11:19 +00:00
Dave Wysochanski
b496210d9a
Convert find_pv_in_vg_by_uuid and pv_create to use PV handles
2007-06-12 22:41:27 +00:00
Alasdair Kergon
41d8dcd802
Add capability for tree-based fields to dmsetup reports.
2007-06-11 13:20:29 +00:00
Bryn M. Reeves
944cac939c
Allow vgcfgrestore to list metadata backup files using -f
2007-06-08 22:38:48 +00:00
Dave Wysochanski
c221b0bc21
Add vg_check_status to consolidate vg status flags checks and error messages.
2007-06-06 19:40:28 +00:00
Dave Wysochanski
7da954d191
make code consistent with pvresize code - good candidate for common code cleanup
2007-06-05 18:23:17 +00:00
Dave Wysochanski
3008bc4432
Fix redundant segment display when PV is given to 'pvdisplay --maps' cmdline.
2007-05-31 20:10:25 +00:00
Dave Wysochanski
4baa42be1c
Add --maps to pvdisplay.
...
Modified original patch from David Robinson <zxvdr.au@gmail.com>.
2007-05-30 20:43:09 +00:00
Milan Broz
b3b0f199ae
Fix and clarify vgsplit error messages.
2007-05-15 13:01:41 +00:00
Alasdair Kergon
44566dd46d
configure.h isn't a system header
2007-04-27 18:01:45 +00:00
Alasdair Kergon
d59b2474e1
Fix segfault in 'dmsetup status' without --showkeys against crypt target. [nec]
2007-04-27 15:12:26 +00:00
Alasdair Kergon
8d2b0f24d3
Deal with some more compiler warnings. Hope this doesn't break anything...
2007-04-27 14:52:41 +00:00
Alasdair Kergon
4f2f566b06
Add devices/preferred_names config regex list for displayed device names.
...
Free a temporary dir string in fcntl_lock_file() after use.
Fix a dm_pool_destroy() in matcher_create().
Introduce goto_bad macro.
2007-04-26 16:44:59 +00:00
Dave Wysochanski
d915579c6b
Update pvck to read labels on disk, with flexible --labelsector
...
parameter.
--
2007-04-25 20:03:16 +00:00
Dave Wysochanski
17a6fc0b45
Add 'scan_sector' parameter to label_read and _find_labeller to add
...
flexibility in searching for disk labels.
2007-04-23 18:21:01 +00:00
Dave Wysochanski
cc5a4e1d38
Add stub for pvck, a command to check physical volume consistency.
2007-03-30 21:00:26 +00:00
Milan Broz
5d06515c0b
Fix creation and conversion of mirrors with tags.
2007-03-26 16:10:10 +00:00
Milan Broz
851002b87d
Fix vgsplit for lvm1 format (set and validate VG name in PVs metadata).
...
Split metadata areas in vgsplit properly.
2007-03-23 12:43:17 +00:00
Milan Broz
d330e660ee
Fix vgremove to require at least one vg argument.
2007-03-15 14:00:30 +00:00
Alasdair Kergon
b9b260119f
Add a few missing pieces of vgname command line validation.
2007-03-09 21:25:33 +00:00
Alasdair Kergon
9397354a33
Support the /dev/mapper prefix on most command lines.
2007-03-09 20:47:41 +00:00
Alasdair Kergon
b45c9f49d0
Fix vgrename active LV check to ignore differing vgids.
2007-03-08 21:08:25 +00:00
Alasdair Kergon
f359c9b80f
Exclude readline support from lvm.static
2007-02-14 16:51:48 +00:00
Alasdair Kergon
0558b9284e
Fix a leak in a reporting error path.
2007-02-14 15:18:31 +00:00
Alasdair Kergon
012869d6d2
Fix a few leaks in reporting error paths.
2007-02-14 15:12:16 +00:00
Alasdair Kergon
aa350ef426
Fix some &->&& vgreduce cmdline validation. [Andre Noll]
2007-01-31 16:26:23 +00:00
Alasdair Kergon
ce4c33102f
Fix vgsplit to handle mirrors.
...
Reorder fields in reporting field definitions.
2007-01-29 23:01:18 +00:00
Alasdair Kergon
34c710712d
Add recent reporting options to dmsetup man page.
...
Revise some report fields names.
2007-01-29 19:35:24 +00:00
Alasdair Kergon
85a0cecf68
help on help
2007-01-29 18:45:08 +00:00
Alasdair Kergon
b6ebe41ace
help unused attr
2007-01-29 18:43:27 +00:00
Alasdair Kergon
64d7041264
add help -c for field list
2007-01-29 18:37:57 +00:00
