shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-01-20 18:09:23 +03:00
Code Releases Activity
6,821 Commits 427 Branches 668 Tags
Commit Graph

757 Commits

Author SHA1 Message Date
Zdenek Kabelac
e2b77ed33c Move allocation after check for vgid 
so there is no mem leak on this error path.
Also actually check if the hash exists.
 2012-02-27 10:10:43 +00:00
Zdenek Kabelac
1b197085b3 Explicitely ignore result from sync_unlock() 
Make it obvious to analyzer - we can't do anything better here anyway.
 2012-02-27 10:02:17 +00:00
Zdenek Kabelac
dc92528f10 Drop uname call, it's not used from gulm era. 2012-02-27 09:58:18 +00:00
Petr Rockai
50730ddd96 Improve error handling & reporting in common daemon code. 2012-02-26 08:46:28 +00:00
Petr Rockai
7bc76e9c20 Fix server-side leaks in lvmetad. 2012-02-24 00:24:37 +00:00
Petr Rockai
1336a1cbf1 Clean up the lvmetad state more thoroughly upon shutdown. 2012-02-24 00:11:59 +00:00
Petr Rockai
6295e3ef1e Fix an error path in daemon_open. 2012-02-24 00:02:54 +00:00
Petr Rockai
ed5d30f075 Couple of improvements in the daemon (common + lvmetad) code: 
- some client-side memory leak fixes
- announce and check protocols and protocol versions
 2012-02-23 23:52:11 +00:00
Zdenek Kabelac
75ac0b638c Limit sscanf params with size 
Make sure parsed string fits given char buffer.
 2012-02-23 22:50:50 +00:00
Zdenek Kabelac
b2edbee763 Remaing code suffling 
Move declaration to the front of function to follow coding rules.
 2012-02-23 22:23:12 +00:00
Zdenek Kabelac
0dd5bf2730 Some reformating for lvmetad uddates 
cleanup gcc warning,
use PRIu64
header cleanups
const pointer fixes.
 2012-02-23 17:59:32 +00:00
Petr Rockai
4c10334843 Add a missed dependency that is required to pull in dameons/common in an early 
part of the build.
 2012-02-23 13:58:56 +00:00
Petr Rockai
165a28a8a5 We need daemons/common now even if the lvmetad server side is not built. 2012-02-23 13:41:11 +00:00
Petr Rockai
002f7a0ce2 The lvmetad client-side integration. Only active when use_lvmetad = 1 is set in 
lvm.conf *and* lvmetad is running.
 2012-02-23 13:11:07 +00:00
Petr Rockai
fa73b2ee3d Also use DEFAULT_RUN_DIR for the lvmetad socket on the client side. 2012-02-23 11:40:24 +00:00
Petr Rockai
b1e320e5c4 Tweak lvmetad a bit more: 
- allow at most one PV on any given device
- allow PV lookup by device
- merge the pvmeta info into VG metadata when responding to vg_lookup
 2012-02-21 09:19:08 +00:00
Petr Rockai
b0fe3642c8 Drop the now-redundant pvid_to_status hash. 2012-02-15 17:37:09 +00:00
Petr Rockai
a0289c969f Update lvmetad: use device major/minor pair to track devices. Keep a pvmeta 
config tree per PV which is mostly provided by the client, so it can be used to
keep track of things like label_sector, PV format, mda count / offsets and so
on.
 2012-02-15 17:30:07 +00:00
Petr Rockai
351c6b96b8 (lvmetad) Remove unused variable. 2012-02-15 14:15:50 +00:00
Petr Rockai
cc3552f4a8 In lvmetad, also nuke VGs when all their PVs are stolen by another VG (vgmerge 
& vgsplit do this).
 2012-02-15 14:06:48 +00:00
Zdenek Kabelac
735a00a152 Detect failing fifo 
If the fifo died because of dmeventd restart - do not wait for 20s
in select  - it will not get better and return error immediately.
 2012-02-15 13:56:47 +00:00
Petr Rockai
4ec2657ac3 lvmetad server-side update: 
- rename the hashes to be explicit about the mapping
- add VG/PV listing calls to the protocol
- cache slightly more of the per-PV state
- filter cached metadata
- compare the metadata upon metadata_update
 2012-02-15 11:43:06 +00:00
Petr Rockai
017c0c9e8c Do not forget to initialise the error value in daemon_reply. 2012-02-15 09:14:54 +00:00
Zdenek Kabelac
2b62c3ed69 Add some FIXME around allocation code 
Remove also unreachable break..
 2012-02-13 14:25:14 +00:00
Zdenek Kabelac
27d46fc686 Make sure dereferenced words[0] and words[1] are defined 2012-02-13 14:17:04 +00:00
Zdenek Kabelac
afed769d42 Check for missing reply_uuid 2012-02-13 11:24:09 +00:00
Zdenek Kabelac
a140caa666 Check for allocation failure 2012-02-13 11:18:45 +00:00
Zdenek Kabelac
777a797ec3 Fix message check 
Check pointer from strchr for NULL instead of crash later.
Badly formated message would have crash dmeventd otherwise.
 2012-02-10 15:17:52 +00:00
Zdenek Kabelac
c966f07bbd Remove unreachable code 2012-02-10 13:46:23 +00:00
Zdenek Kabelac
5365e4a53f A bit more readable code 
Just a minor readability conversion.
 2012-02-08 13:03:40 +00:00
Zdenek Kabelac
7940545204 Remove unneeded assignments 
Variables have (or will have) those values set.
 2012-02-08 11:36:18 +00:00
Zdenek Kabelac
cc525412f1 Keep page_size as signed number 
Since it's return value from sysconf and is checked for <0.
 2012-02-08 11:34:46 +00:00
Zdenek Kabelac
6e40adde76 Add boundary test for number of mirror devs and logs 
As atoi may return negative value - test for both limits.
Test log_args for limits before calling alloca().
Code from dmeventd mirror plugin should probably share same code as
we have in mirrored.c.
 2012-02-08 11:29:13 +00:00
Petr Rockai
a3ac5a54d0 Remove a dubious log message ("another thread is handling an event") from LVM 
dmeventd plugins. Fixes RHBZ 771419.
 2012-02-01 20:11:58 +00:00
Alasdair Kergon
8416129244 Automatically detect whether corosync clvmd needs to use confdb or cmap. (fabio) 2012-01-31 21:21:53 +00:00
Zdenek Kabelac
3d0906496b Oops missed braces in previous commit 
This has disabled clvmd for being executed.
(FIXME improve testing part to catch this fault)
 2012-01-26 17:55:55 +00:00
Zdenek Kabelac
28de76ed58 Fix leak of hash table 
Minor leak on command initialization.
 2012-01-25 22:36:33 +00:00
Zdenek Kabelac
a1f42a8e88 Set to a defined value vars used after error path 
Static analyzer noticed this vars are used even when error is reported
back thus their state is undefined - set to 0 for this case.
 2012-01-25 22:20:11 +00:00
Zdenek Kabelac
baffb459d8 Test for uname result 
in fail path initialize to 0.
 2012-01-25 22:17:57 +00:00
Zdenek Kabelac
e152c0b9e6 Add breaks for cases 2012-01-25 21:42:09 +00:00
Zdenek Kabelac
cd55e7238a Ensure reply struct has all fields defined 
Reply is returned by value.
 2012-01-25 21:31:59 +00:00
Zdenek Kabelac
dfac9aef46 Check and print perror for syscalls 2012-01-25 21:30:27 +00:00
Zdenek Kabelac
93903e1edf Clean var declarations to the front of the function 2012-01-25 13:06:57 +00:00
Alasdair Kergon
efa33f0b49 Add CLVMD_FLAG_REMOTE to skip processing on local node. 2012-01-21 05:31:54 +00:00
Zdenek Kabelac
76b1e2d9b1 Thin forgotten initialisation of pointer to NULL 
Since the code may go in error path, set to defined NULL.
 2012-01-20 10:59:26 +00:00
Jonathan Earl Brassow
6bcd3263c2 Preserve exclusive activation of cluster mirror when converting. 
This patch to the suspend code - like the similar change for resume -
queries the lock mode of a cluster volume and records whether it is active
exclusively.  This is necessary for suspend due to the possibility of
preloading targets.  Failure to check to exclusivity causes the cluster target
of an exclusively activated mirror to be used when converting - rather than
the single machine target.
 2012-01-20 00:27:18 +00:00
Zdenek Kabelac
946166795e Drop unused variable 2012-01-19 15:59:51 +00:00
Zdenek Kabelac
a1224b2da8 Thin use consistentely metadata 
Do not shortcut to 'meta' and stay with 'metadata'
Also matches kernel doc for dm API then.
 2012-01-19 15:21:23 +00:00
Petr Rockai
693e6e76a9 Beef up the lvmetad code with more functionality and a bunch of bugfixes. There 
used to be a few mis-ordered memory accesses (release and access in the next
block). Fix that set_flag could have sometimes corrupted the flags being
modified.

A few issues with metadata tracking are sorted out as well now, and there are
only a few problems remaining before we can integrate lvmetad, mostly on the
client side:

- metadata areas need to be tracked in lvmetad (most likely to be addressed
  through an extension of metadata, meaning no special support in lvmetad would
  be needed)
- non-udev scanning code needs to be taught about telling lvmetad about device
  disappearance (pvscan most importantly)
- this last item also needs to mesh with metadata inconsistencies and
  suddenly-incomplete volume groups (aux disable_dev in tests); udev-based
  scanning should address this separately and more elegantly
 2012-01-16 08:25:32 +00:00
Petr Rockai
5463a05a32 Fix a boundary condition in read_buffer in daemon-shared.c. 2012-01-16 05:09:16 +00:00