shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-22 17:35:59 +03:00
Code Releases Activity
8,796 Commits 425 Branches 667 Tags 54 MiB
9196274c1e
Commit Graph

173 Commits

Author SHA1 Message Date
Zdenek Kabelac
9196274c1e cleanup: clvmd zombie removal loop 
Simplier code to start scan from the next node,
and remove matching pipe client.
 2014-03-21 22:29:27 +01:00
Zdenek Kabelac
5740c00f3b cleanup: clvmd reindent read_from_local_sock 
Shift indent of else branch to right since
error path returns in the front.
(Simplier to read)
 2014-03-21 22:29:26 +01:00
Zdenek Kabelac
dd17286c90 cleanup: clvmd indent change 
Plain indent changes.
 2014-03-21 22:29:26 +01:00
Zdenek Kabelac
0b79979bb9 cleanup: clvmd dump_messages 2014-03-21 22:29:26 +01:00
Zdenek Kabelac
f8cd435cd8 cleanup: clvmd update log_error 
Drop \n from log_error() and add '.'
 2014-03-21 22:29:26 +01:00
Zdenek Kabelac
4c97ea2ce5 cleanup: clvmd drop goto 2014-03-21 22:29:25 +01:00
Zdenek Kabelac
bf19c6be2c cleanup: clvmd move destroy_lvhash into main 
Keep destruction code path consistent and simple and
destroy lvhash in the place it's been created.
Also issue debug message from a single place.
 2014-03-21 22:29:25 +01:00
Zdenek Kabelac
7041c8bf51 clvmd: drop dead code 
Since pipe_client has been already reset to NULL,
remove this dead code.
 2014-03-21 22:29:24 +01:00
Zdenek Kabelac
73978f8d7d clvmd: drop unused local_sock parameter 2014-03-21 22:29:24 +01:00
Zdenek Kabelac
37396e2fe5 clvmd: update add_reply_to_list 
Take mutex lock after the allocation just before
the structure is merged into reply list.
 2014-03-21 22:29:24 +01:00
Zdenek Kabelac
2847994624 clvmd: use dm_malloc 
Use libdm malloc wrapper functions.
 2014-03-21 22:29:24 +01:00
Zdenek Kabelac
c45cd6eb8d clvmd: move call of cluster_closedown 
We have to close cluster in some predicatable way,
otherwise we may access released memory from different
threads.

So move closedown till the point we know all thread
are closed. New messages from cluster are discarded.
 2014-03-21 22:29:23 +01:00
Zdenek Kabelac
fc39ad677b clvmd: move destroy_lvm into lvm thread 
Since lvm was initialized in lvm thread call destroy there as well.
 2014-03-21 22:29:23 +01:00
Zdenek Kabelac
8431d47b3b clvmd: add special lvm thread exit 
When multiple threads act on the same 'quit' variable
the order of exit becomes unpredictable.

So let the main_loop() finish first and then clean up
all queued lvm jobs.

Do not add any new work, when lvm_thread_exit is set.
 2014-03-21 22:29:23 +01:00
Zdenek Kabelac
05a532e171 clvmd: always set cleanup_needed 
When thread is created, set the cleanup_needed flag
immediately so it could be used properly any time later
when cleanup_zombie() is needed.
 2014-03-21 22:29:23 +01:00
Zdenek Kabelac
5bea2b5c82 clvmd: fix clean memory on exit 
Properly clean 'client' structure only for LOCAL_SOCK type.
(Fixes bug from commit 460c19df62)
(in release fix)

Also cleanup-up associated pthreads by using cleanup_zombie() function.
Since this function may change the list, restart scanning always from
the list header.

Note: couple following patches are necessary to make this working properly.
 2014-03-21 22:29:22 +01:00
Zdenek Kabelac
6c892be4a5 clvmd: fix the len setting in last commit 
When theoretically sending 0 length buffer, ensure 0 is returned.
 2014-03-10 12:35:44 +01:00
Zdenek Kabelac
341055ddb3 cleanup: clvmd use struct initializers 
Simplify code, and use compiler capability to
initilize struct members on its own.
 2014-03-10 12:24:10 +01:00
Zdenek Kabelac
c44ede31a3 cleanup: clvmd use else if 
When string already matches, skip rest of tests.
 2014-03-10 12:24:09 +01:00
Zdenek Kabelac
2cfe0840d2 cleanup: clvmd assign NULL to pointers 
Use NULL when assigning to void*.
 2014-03-10 12:24:09 +01:00
Zdenek Kabelac
c824369fbd cleanup: clvmd indent changes 
Improve readbility of clvmd code.
Remove some unneeded braces.
 2014-03-10 12:24:09 +01:00
Zdenek Kabelac
109564d6a5 cleanup: clvmd simplify loops 
Rewrite write loops to be more readable.
 2014-03-10 12:24:09 +01:00
Zdenek Kabelac
3d23404081 cleanup: clvmd rewrite send_message 
Improve readability of code and make it clear what it tries
to achieve.
 2014-03-10 12:24:09 +01:00
Zdenek Kabelac
460c19df62 clvmd: fix memleak on exit 
This patch will releases allocated private resources from
startup. Needs previous dm_zalloc patch to ensure unset
private pointer is NULL.

TODO: check on real cluster.
 2014-03-10 12:21:32 +01:00
Zdenek Kabelac
38ce06e448 clvmd: use dm_zalloc for socket allocation 
Instead of doing individual settings for struct members,
ensure whole struct is in defined state.
 2014-03-10 12:20:49 +01:00
Zdenek Kabelac
50e1fad86a cleanup: use matching signed types 2013-11-28 12:47:51 +01:00
David Teigland
4c0db84948 clvmd: fix verify message rejection of REMOTE flag 
This fixes a bug in commit 19baf842 where verify_message
was rejecting the CLVMD_FLAG_REMOTE flag.  It was missed
since the patch was ported from an lvm version where that
flag does not exist.
 2013-10-24 11:18:22 -05:00
Petr Rockai
25bed99681 clvmd: Avoid a 3-way deadlock in dead-client cleanup. 2013-09-18 21:17:48 +02:00
Peter Rajnoha
0563bd0037 fix: some issues reported by coverity 
- null_fd resource leak on error path in _reopen_fd_null fn
  - dead code in verify_message in clvmd code
  - dead code in _init_filter_components in toolcontext code
  - null dereference in dm_prepare_selinux_context on error path if
    setfscreatecon fails while resetting SELinux context
 2013-08-15 12:23:49 +02:00
Zdenek Kabelac
7b1315411f clmvd: fix decriptor leak on restart 
Do not leave descriptor used for dup2() openned.
 2013-08-06 16:20:36 +02:00
David Teigland
19baf84290 clvmd: verify messages before processing 
Check that fields in clvm_header are valid when
local or remote messages are received.  If not,
log an error, dump the message data and ignore
the message.
 2013-08-02 09:55:54 -05:00
Zdenek Kabelac
d38af2857f cleanup: cast to len's type 
Cleanup different signess gcc warning.
 2013-04-21 23:14:05 +02:00
Zdenek Kabelac
5070ffbca7 clvmd: avoid logging in signal handler 
debuglog in the main thread.
 2013-04-21 22:56:59 +02:00
Zdenek Kabelac
0125518d6d clvmd: preserve foreground mode across restart 
Keep clvmd in foreground when restarted.
Useful for testing.
 2013-04-21 22:56:48 +02:00
Zdenek Kabelac
8bcc1da2f3 locales: use higher prio LC_ALL variable 
For reseting locale environment into significantly less memory
consuming version 'C' - use LC_ALL instead of LANG since it has
higher priority in locale settings.

Otherwise we may observe whole locale-archive which might be
over 100MB on i.e. Fedora systems locked in memory with
some daemons.
 2013-01-22 11:25:02 +01:00
Zdenek Kabelac
1d774e5667 cleanup: drop test for optarg NULL 
Since -d takes an argument, we do not need to check for
optarg being NULL here.
 2012-12-15 14:57:40 +01:00
Zdenek Kabelac
13fe333b54 clvmd: fix parsing of -d argument 
clvmd -d option parsing was not working properly.

clvmd -d 2   (with space) has been ignored because of
'::' used in getopt string, and as failsafe it's been used '1'.

Later this debug_arg has been ignored and debug_opt was used
instead which happend to have value '1'.

Submitted-by: Robert Milasan <rmilasan at suse.com>
Reported-by: Robert Milasan  <rmilasan at suse.com>
 2012-10-19 15:35:56 +02:00
Zdenek Kabelac
c6f680ee49 clvmd,lvmetad: check for fcntl result 
Report any problem of fcntl.
 2012-08-23 14:38:48 +02:00
Zdenek Kabelac
59ca324c35 clvmd: release excl_uuid hash 
Release allocated hash before exit.
 2012-08-23 14:34:56 +02:00
Zdenek Kabelac
6f3cd63551 cleanup: replace memset with struct initilization 
Simplifies the code, properly detects too long socket paths,
drops unused parameter.
 2012-06-22 13:23:03 +02:00
Milan Broz
61a1effcf1 Avoid closing clvmd socket twice. 2012-03-27 16:59:28 +00:00
Zdenek Kabelac
4ea8533f30 Make sure namelen fits into buffer allocated on stack 2012-03-23 09:43:44 +00:00
Zdenek Kabelac
f3c177312f Correct enum type 
Using debug_t and some forgetten alloc_policy_t, force_t from past commit.
 2012-03-01 21:14:43 +00:00
Zdenek Kabelac
c452307543 Few more close and dev_close trace 
Adding (void) where we cannot really report an error.
 2012-03-01 21:12:37 +00:00
Zdenek Kabelac
bd046f0201 Ensure clvmd message is always \0 terminated 
Drop whole buffer clearing (most messages at <100 bytes).
Just make sure we have always \0 terminated string for strlen() operations.
(before for PIPE_BUF sized messages this was not set).
 2012-02-28 11:06:56 +00:00
Zdenek Kabelac
e5d399f667 Missed to properly merge patch for definition of MAX_MISSING_LEN 
(fix previous commit)
 2012-02-28 10:42:20 +00:00
Zdenek Kabelac
4d44893d60 Add log_sys_error for close 2012-02-28 10:14:06 +00:00
Zdenek Kabelac
696052b78e Limit max size of clvmd message 
This could be seen as some sort of simple validation - it's not easy to
recognize a valid message for now - but we definitely do not want to
allocate a lot of megabytes in  clvmd memory locked daemon when broken
message gets in.

Size of 8000 is just selected for now - possibly there could be much
lower value put in.
 2012-02-28 09:58:19 +00:00
Zdenek Kabelac
782a37e411 Do not send uninitilised bytes 
Use struct initalizers to fill struct members and at the same time have
all unspecified members set to 0.
 2012-02-28 09:53:55 +00:00
Zdenek Kabelac
8918bf2430 Add some log_sys_errors to close() call 2012-02-27 11:28:47 +00:00