Petr Rockai
e8ada4a717
What's new.
2012-02-10 02:56:54 +00:00
Petr Rockai
14d7b7b4e9
Keep a global (per-format) orphan_vg and keep any and all orphan PVs linked to
...
it. Avoids the need for FMT_INSTANCE_PV and enables further simplifications. No
functional change, internal refactor only.
2012-02-10 02:53:03 +00:00
Petr Rockai
395ee036d7
What's new: lvmcache.
2012-02-10 01:29:46 +00:00
Petr Rockai
1a28df6bb4
Move lvmcache data structures behind an API (making the structures private to
...
lvmcache.c). No functional change.
2012-02-10 01:28:27 +00:00
Peter Rajnoha
2936951d94
Stop processing lvextend if trying to extend a mirror that is being recovered.
...
Missing correct return value in lv_extend fn.
2012-02-09 15:13:42 +00:00
Zdenek Kabelac
e98b640d5d
Move label_init up in code stack
...
label_exit() is called destroy_toolcontext() and we are now
using standard dm_list function for destroy, we have to make sure
dm_list gets initialized properly.
2012-02-08 13:44:49 +00:00
Zdenek Kabelac
6d29fe0f33
Thin add pool_below_threshold
...
Test both data and metadata percent usage.
2012-02-08 13:05:38 +00:00
Zdenek Kabelac
5365e4a53f
A bit more readable code
...
Just a minor readability conversion.
2012-02-08 13:03:40 +00:00
Zdenek Kabelac
70e3728446
Fix test for lv_snapshot_percent
...
Do not check for PERCENT_MERGE_FAILED if the lv_snapshot_percent() failed.
(test for snap_percent would be testing uninitialized value).
2012-02-08 13:02:07 +00:00
Zdenek Kabelac
0cb3bdcfce
Drop unreachable code
2012-02-08 12:59:45 +00:00
Zdenek Kabelac
d735798674
Use dm_asprintf to simplify code
2012-02-08 12:59:19 +00:00
Zdenek Kabelac
74c7c69d34
Some fixmes
...
'len' calculation is unused ?
Unreachable code could be removed or moved upward ?
2012-02-08 12:57:15 +00:00
Zdenek Kabelac
7ce534f911
Switch to return void
...
List delete cannot fail, so there is no reason to test for error.
2012-02-08 12:52:58 +00:00
Zdenek Kabelac
f03f322f13
Use dm_snprintf and improve error handling
...
Add standard error reporting with error logging.
Use plain alloc instead of zalloc for string buffer.
Use dm_snprintf with valid test for <0.
2012-02-08 12:50:10 +00:00
Zdenek Kabelac
c929a0b3c8
Add range test for device number
...
Check the output of atoi is in valid range.
2012-02-08 12:48:14 +00:00
Zdenek Kabelac
6bea32ccf2
Remove duplicate test
...
Tested condition has been already evaluated before
For strlen() code has already excluded <ID_LEN.
For repairing, already tested (!argc && !repairing) before.
2012-02-08 11:41:18 +00:00
Zdenek Kabelac
84facc4fa5
Replace snprintf with dm_snprintf
...
snprintf testing for negative is replaced with dm_snprintf where this
test really works.
Add missing test for result of dm_snprintf().
2012-02-08 11:40:02 +00:00
Zdenek Kabelac
7940545204
Remove unneeded assignments
...
Variables have (or will have) those values set.
2012-02-08 11:36:18 +00:00
Zdenek Kabelac
cc525412f1
Keep page_size as signed number
...
Since it's return value from sysconf and is checked for <0.
2012-02-08 11:34:46 +00:00
Zdenek Kabelac
962fd76f26
Move done jump lower
...
Since before 'goto done' is bufused zeroed, it would otherwise write 1
byte in front of buffer.
2012-02-08 11:31:29 +00:00
Zdenek Kabelac
6e40adde76
Add boundary test for number of mirror devs and logs
...
As atoi may return negative value - test for both limits.
Test log_args for limits before calling alloca().
Code from dmeventd mirror plugin should probably share same code as
we have in mirrored.c.
2012-02-08 11:29:13 +00:00
Zdenek Kabelac
fb6a209080
Set all parameters to 0
...
Since the function dm_get_next_target() returns NULL as 'next' pointer
so it's not a 'real' error - set 0 to all parameters when NULL is
returned because of missing head.
i.e. one of use case::
do {
next = dm_get_next_target(dmt, next, &start, &length,
&target_type, ¶ms);
size += length;
} while (next);
2012-02-08 11:25:09 +00:00
Zdenek Kabelac
e6b610e8ed
Check that whole locking_dir fits _lock_dir buffer
2012-02-08 11:17:34 +00:00
Zdenek Kabelac
bb0862fbb4
Move close few lines
...
Since the function dev_close() has code path, which really could close
file (for unlocked vg) and destroy dev handler, stay on safe side and move
the close few lines later, even our current use case shouldn't trigger
such scenario.
2012-02-08 11:15:38 +00:00
Zdenek Kabelac
e2d2f6c7b7
Use dm_list_iterate_items_safe
...
And avoid direct access to list member variables.
Inline _free_li().
2012-02-08 11:12:18 +00:00
Zdenek Kabelac
e48d39cba0
Fix fd resource leak in error path
...
Use 'goto bad' to cleanup fd on error path.
2012-02-08 11:07:17 +00:00
Zdenek Kabelac
4443aa41cc
Ensure strncpy() function always ends with '\0'
...
Since last character needs to be \0 for string,
pass buffer size smaller by 1 byte.
2012-02-08 11:05:04 +00:00
Zdenek Kabelac
24da0046d5
Set status for error path
...
Do not leave status unitialized, since in some cases, it's tested,
when the function returns error.
2012-02-08 10:56:17 +00:00
Zdenek Kabelac
8d9b4b0133
Add missing deps for lvm2api
...
Hmm, wasted some time because of this missing deps....
2012-02-08 10:52:45 +00:00
Zdenek Kabelac
328ed80160
Fix resource leaks for failing allocation
...
In case, something would fail during format initialization,
return allocated memory.
2012-02-08 10:49:36 +00:00
Zdenek Kabelac
582c94aa21
Release allocated resources in error path
...
If composite_filter_create() fails, release filters.
2012-02-08 10:46:24 +00:00
Zdenek Kabelac
38188ff8aa
Check result of lstat
...
If lstat returns errno different from ENOENT, do not use the content of
struct stat 'buf'.
2012-02-08 10:43:42 +00:00
Petr Rockai
c84c7ee034
What's new.
2012-02-01 20:13:44 +00:00
Petr Rockai
a3ac5a54d0
Remove a dubious log message ("another thread is handling an event") from LVM
...
dmeventd plugins. Fixes RHBZ 771419.
2012-02-01 20:11:58 +00:00
Alasdair Kergon
b93aa9eac4
post-release
2012-02-01 18:46:57 +00:00
Alasdair Kergon
d8e7d0e2bd
pre-release
old-v2_02_90
v2_02_90
2012-02-01 15:17:04 +00:00
Alasdair Kergon
759f5b3349
Adjust comments
2012-02-01 15:05:53 +00:00
Zdenek Kabelac
433c583cd7
Add synchornization point in mirror log init.
...
Put extra sync point when mirror log is deactivated and before
it's activated for the second time.
2012-02-01 13:50:36 +00:00
Zdenek Kabelac
02f6f4902f
Disable partial activation for thin LVs and LVs with all missing segments
...
Count number of error and existing areas and if there is no existing area
for the LV avoid its activation.
Always disable partial activatio for thin volumes.
For mirrors currently put in hack to let it pass with a special name
since current mirror code needs to activate such LV during some operations.
2012-02-01 13:47:27 +00:00
Zdenek Kabelac
90fd0f5b42
Avoid warning for small pv_min_size
...
Do not print warning for pv_min_size set in range between 512KB and 2MB.
2012-02-01 13:42:18 +00:00
Peter Rajnoha
56f6e9310d
Clean up systemd unit ordering and requirements.
2012-02-01 13:08:39 +00:00
Zdenek Kabelac
8bec4f1a79
Minor consistency update for debugging messages
...
Use mlock/munlock for debugging lines.
2012-02-01 10:48:22 +00:00
Zdenek Kabelac
f00a162500
User correct base dir for lcov reports
...
Fix problem when srcdir != builddir.
2012-02-01 10:46:45 +00:00
Alasdair Kergon
1228bcaa0d
lost line
2012-02-01 02:11:43 +00:00
Alasdair Kergon
b94b757e1e
Track unreserved space for all alloc policies and then permit NORMAL to place
...
log and data on same single PV.
2012-02-01 02:10:45 +00:00
Alasdair Kergon
49fd0fef6b
lp.pool may be (null) too
2012-02-01 01:54:20 +00:00
Alasdair Kergon
8416129244
Automatically detect whether corosync clvmd needs to use confdb or cmap. (fabio)
2012-01-31 21:21:53 +00:00
Zdenek Kabelac
b329581e8e
Fix data% reporting
...
For reading % of mapped size of thin volume use as origin for
old style snapshot '-real' device needs to be queried.
Fix log_error report given for lvs -a in this case.
2012-01-28 20:12:26 +00:00
Zdenek Kabelac
0117473049
TARGETS macro has to be defined before inclusion of make.tmpl
...
Use @TESTING@ check in this case.
2012-01-27 10:55:02 +00:00
Alasdair Kergon
09e8d81a53
post-release
2012-01-27 01:23:40 +00:00