Zdenek Kabelac
a15b796146
tests: repair of cachepool
2017-09-20 15:14:16 +02:00
Peter Rajnoha
aa75ca6332
test: pvcreate-bootloaderarea: pvcreate --restorefile --bootloaderarea not supported anymore
...
The fact that this combination is not supported anymore is tested
already in pvcreate-operation.sh test.
2017-08-15 14:15:50 +02:00
Peter Rajnoha
3c978f7bcc
pvcreate: fix check for 2nd mda at end of disk fits if using pvcreate --restorefile
...
Fix code checking that the 2nd mda which is at the end of disk really
fits the available free space and avoid any DA and MDA interleaving when
we already have DA preallocated. This mainly applies when we're restoring
a PV from VG backup using pvcreate --restorefile where we may already have
some DA preallocated - this means the PV was in a VG before with already
allocated space from it (the LVs were created). Hence we need to avoid
stepping into DA - the MDA can never ever be inside in such case!
The code responsible for this calculation was already in
_text_pv_add_metadata_area fn, but it had a bug in the calculation where
we subtracted one more sector by mistake and then the code could still
incorrectly allocate the MDA inside existing DA. The patch also renames
the variable in the code so it doesn't confuse us in future.
Also, if the 2nd mda doesn't fit, don't silently continue with just 1
MDA (at the start of the disk). If 2nd mda was requested and we can't
create that due to unavailable space, error out correctly (the patch
also adds a test to shell/pvcreate-operation.sh for this case).
2017-08-15 13:40:25 +02:00
Zdenek Kabelac
5dd53943c9
tests: update checked message
2017-08-02 00:04:35 +02:00
Zdenek Kabelac
466da710e0
tests: avoid endless loops
...
If there is some problem with device removal avoid generating very long
error logs...
2017-07-18 21:17:51 +02:00
Zdenek Kabelac
3c32883cec
test: repeat rediscovery few times
...
Avoid using 'aux' shell when setting dmsetup cookie.
Do not user '--force' when using external cookie.
2017-07-17 13:38:31 +02:00
Zdenek Kabelac
d15b9ac510
tests: extend lvcreate size validation
2017-07-17 12:33:42 +02:00
Zdenek Kabelac
c64e2a85cb
tests: use get_devs
2017-07-15 00:13:33 +02:00
Zdenek Kabelac
8a2448a4ed
tests: skip test for non dirty cache
...
Seems some cache LV can't be made dirty easily with older
cache policy implementations....
2017-07-14 00:42:40 +02:00
Zdenek Kabelac
f64f6c5e70
tests: wait for udev to minize race windows
...
mkfs can complain about volume in use when meets udev rule processing.
2017-07-13 21:11:16 +02:00
Zdenek Kabelac
870c7bc76c
tests: bound variables
2017-07-13 21:11:16 +02:00
Zdenek Kabelac
e88534b680
tests: delay read of cache pool data
...
It's better to delay read of cached data.
Limit loop checking for cleaner policy.
2017-07-13 21:11:16 +02:00
Zdenek Kabelac
c838e79cd2
tests: fix for new hardened bash
...
Add missing get_devs.
When $7 is not given use empty string.
See if we can live with less RAM disk for PVs.
Drop limitation on single core as presence 1.12 should address this.
2017-07-12 18:05:56 +02:00
Zdenek Kabelac
0f2dccc601
tests: bounds still more vars
2017-07-12 01:37:29 +02:00
Zdenek Kabelac
ec9b845aaa
tests: drop type
...
Assuming test wanted to check $lv3 does not exists.
2017-07-12 01:21:44 +02:00
Zdenek Kabelac
a1ed9bc145
tests: more exact test
...
Check there is really just linear.
Also short-circuit mimages_are_on_ when file is empty
(avoids unbound mimages[@] access on older bash)
2017-07-12 01:21:44 +02:00
Zdenek Kabelac
b97f75b133
tests: improve logic for a race to catch abortion
2017-07-11 17:21:25 +02:00
Zdenek Kabelac
5ab2676bac
tests: double quote
2017-07-11 16:26:12 +02:00
Zdenek Kabelac
21e0e98665
tests: correct typo
...
Use defined MARKED_AS_USED_MSG shell var.
2017-07-11 16:26:12 +02:00
Zdenek Kabelac
429e613ba8
tests: avoid unbound shell var usage
2017-07-11 16:26:12 +02:00
Zdenek Kabelac
f11e74ae3d
tests: improve test logic
...
Use existing vars.
Reduce extra lvchange -an and use directly activation with lvcreate.
2017-07-11 16:26:12 +02:00
Zdenek Kabelac
e9a544b942
tests: avoid using readarray
...
Real bashman can live without readarray.
Support older tested machines with bash <4.0....
2017-07-10 17:40:31 +02:00
Zdenek Kabelac
d23a475c98
tests: using prepare_vg
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
dafeb0274a
tests: assign path
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
f818a83a1d
tests: fix array usage
...
Use bash arrays to pass devs.
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
85e5a8803c
tests: simplify and doublequote
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
1c9789b0cc
tests: use well defined test
...
Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
Apparently && and || "short-circuit" while -a and -o do not.
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
9c0a92ee8d
tests: cleaner written eval
...
Although code work this coding style is better.
This \c will be a regular 'c' in this context.
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
ec05890026
tests: mixes string and array
...
Argument mixes string and array. Use * or separate argument
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
4e2fd6f6ab
tests: fix caller of mirror_images_on
...
Missed vg name.
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
bc10d0373a
tests: fix working with devs in array
...
Also fixes one instance of invalid 'mirror_image_on' test
and places there correct indexed set of PVs.
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
91d6a62fc5
tests: correcting usage of $@
...
Use "$@" (with quotes) to prevent whitespace problems.
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
f161c6ee9f
tests: assign as string
...
Assigning an array to a string! Assign as array, or use * instead of @ to concatenate.
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
2e47ab9b8c
tests: secure rm call
...
Use "${var:?}" to ensure this never expands to / .
(Should never happen as 'dir' was supposed to exist from preceding
test.)
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
4ed3f1bee3
tests: improve loop
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
e68d986cd5
tests: check result directly
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
160cb1e713
tests: replace cat usage
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
e11de5847d
tests: add space to split words
...
Fixing shellcheck warning:
This word is outside of quotes. Did you intend to 'nest '"'single quotes'"' instead'?
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
270e526734
tests: fix tests variable
...
Actually check $r instead or 'r' for test failure.
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
38917ee51c
tests: replace legacy code
...
Use $(..) instead of legacy `..`.
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
d606891e4a
tests: fix quoting
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
494d819a6f
tests: drop extra sourcing of utils
...
This sourceing is automatic by . lib/inittest
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
ff2242036b
tests: drop useless literal
...
Here was usage of '\' unneeded.
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
5214e62f09
tests: drop unneeded ;
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
c3d8ee4da2
tests: drop unneeded check
...
Test should actually fail in this condition as it's testing lvmetad.
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
4a5eea7758
tests: drop unneeded echo
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
2d96b758e4
tests: drop unneeded cat
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
eba96a9720
tests: fix possible misspelling
...
Possible misspelling: FAILED_MIXED_STR may not be assigned, but FAIL_MIXED_STR is.
Possible misspelling: FAILED_MULTI_STR may not be assigned, but FAIL_MULTI_STR is.
Possible misspelling: FAILED_BLACK_STR may not be assigned, but FAIL_BLACK_STR is.
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
d4345220cc
tests: avoid masking return values
...
Declare and assign separately to avoid masking return values.
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
146bfb2417
tests: math drop uncessary $/${}
...
$/${} is unnecessary on arithmetic variables.
Use $((..)) instead of deprecated $[..]
2017-07-10 14:23:53 +02:00