prajnoha
699a2268d6
Add "--refresh" functionality to vgchange and vgmknodes.
2008-12-22 09:00:51 +00:00
prajnoha
370dc2d727
Fix vgrename using UUID in case there are VGs with the same name.
2008-12-19 14:22:48 +00:00
Dave Wysochanski
03798fd604
Move arg_* functions from toollib.c to lvmcmdline.c.
...
In preparation for removing cmd->args.
IMO, it makes more sense to put these accessor functions
in the same location as the static array _the_args.
Next patch will update arg_* functions to use _the_args[]
directly and remove cmd->args.
2008-12-17 16:45:32 +00:00
Alasdair Kergon
a2bfad1c29
Right, a simple build (without options) is working again.
2008-11-03 22:14:30 +00:00
Jim Meyering
a78d7231a9
break (rather than return) so we have only one point of return
...
* tools/toollib.c (process_each_segment_in_lv): Upon sigint_caught,
break rather than returning ret_max. No semantic change.
2008-06-11 15:02:52 +00:00
Dave Wysochanski
3e47d4e65b
Fix return values for reporting commands when run with no PVs, LVs, or VGs.
...
The new error checking code caught some commands that were returning '0' as
an exit status for success. This is incorrect and resulted in a benign error
message displayed (see below). As of today, all commands should return a
value defined in lib/commands/errors.h (1-5). This results in an exit code of
0 on success, or > 0 on failure (as stated in the lvm.8 man page).
Before change:
1. Make sure no PVs are on the system
2. Run 'pvs'
Command failed with status code 0.
After change:
<no output>
2008-06-10 20:07:04 +00:00
Dave Wysochanski
8b42fa150b
Add ommitted unlock_vg() call when sigint_caught() during vg processing.
...
Specific test case:
1. pvcreate /dev/loop1; vgcreate vg1 /dev/loop1; lvcreate -L 64M -n lv1 vg1
2. vgremove vg1 (will prompt user)
3. CTRL-C
Code will exit with:
Do you really want to remove volume group "vg2" containing 2 logical volumes? [y/n]:
Volume group "vg2" not removed
Command failed with status code 5.
Internal error: Volume Group vg2 was not unlocked
Device '/dev/loop1' has been left open.
After change:
Do you really want to remove volume group "vg2" containing 2 logical volumes? [y/n]:
Volume group "vg2" not removed
Command failed with status code 5.
2008-06-10 15:25:38 +00:00
Alasdair Kergon
e612871ea7
more pre-release cleanup
2008-04-10 19:59:43 +00:00
Dave Wysochanski
788e544e1d
Add 'is_reserved_lvname()' helper function.
...
Very similar to apply_lvname_restrictions but without the error messages.
2008-03-25 15:24:59 +00:00
Alasdair Kergon
f70af6018c
Fix 'pvs -a' to detect VGs of PVs without metadata areas.
2008-02-06 16:09:51 +00:00
Alasdair Kergon
1ddd4509dc
Some whitespace tidy-ups.
2008-01-30 14:00:02 +00:00
Alasdair Kergon
6af3f4f4cf
Use stack return macros throughout.
2008-01-30 13:19:47 +00:00
Alasdair Kergon
9397833ceb
pre-release review cleanups
2008-01-17 17:17:09 +00:00
Dave Wysochanski
dad73465fc
Create vgs_are_compatible() fn to check whether vgs are compatible for merging.
...
Add new vgmerge and vgsplit tests to check rejection of incompatible vgs.
Cleanup comments.
Bugzilla: bz251992
---
lib/metadata/metadata-exported.h | 3 +
lib/metadata/metadata.c | 89 +++++++++++++++++++++++++++++++++-
test/t-vgmerge-usage.sh | 101 +++++++++++++++++++++++++++++++++++++++
test/t-vgsplit-operation.sh | 20 +++++++
tools/vgmerge.c | 69 --------------------------
tools/vgsplit.c | 5 -
6 files changed, 215 insertions(+), 72 deletions(-)
2008-01-16 19:54:39 +00:00
Alasdair Kergon
a664ce4298
use scan_vgs_for_pvs to detect non-orphans without MDAs
2008-01-16 18:15:26 +00:00
Dave Wysochanski
628d3bff45
Move more parameter validation into the library.
...
Update vgrename to call validate_vg_rename_params().
Fix vgcreate and vgsplit default arguments by adding defaults parameter to
fill_vg_create_params().
Add t-vgrename-usage.sh test.
Bugzilla: bz251992
---
tools/toollib.c | 32 ++++++++------------------------
tools/toollib.h | 5 ++---
tools/vgcreate.c | 35 +++++++++++++++++++++--------------
tools/vgrename.c | 35 ++++++-----------------------------
tools/vgsplit.c | 21 ++++++++++++++-------
5 files changed, 51 insertions(+), 77 deletions(-)
2008-01-15 22:56:30 +00:00
Dave Wysochanski
38857ba29e
Allow vgcreate options as input to vgsplit when new vg is split destination.
2008-01-14 21:07:58 +00:00
Alasdair Kergon
30cbcccc80
Fix vgreduce PV list processing not to process every PV in the VG.
2008-01-03 19:03:32 +00:00
Alasdair Kergon
4b0950aba5
a few more changes/fixes to recent code
2007-12-22 02:13:00 +00:00
Alasdair Kergon
0537ad860a
various cleanups in recent patches
2007-12-20 22:37:42 +00:00
Alasdair Kergon
2cdbbb1aea
stacked mirror support (incomplete)
2007-12-20 18:55:46 +00:00
Alasdair Kergon
9afff4cf30
Major restructuring of pvmove and lvconvert layer manipulation code
2007-12-20 15:42:55 +00:00
Alasdair Kergon
d6e5e3d103
Decode cluster locking state in log message. (untested)
...
Change file locking state messages from debug to very verbose.
2007-11-16 21:16:20 +00:00
Alasdair Kergon
a01732ee9b
more vg_read lock fixes
2007-11-15 21:30:52 +00:00
Alasdair Kergon
df49287e5f
Convert some vg_reads into vg_lock_and_reads
2007-11-15 02:20:03 +00:00
Alasdair Kergon
c8ec8391ee
Avoid nested vg_reads when processing PVs in VGs and fix associated locking.
2007-11-14 18:41:05 +00:00
Alasdair Kergon
f8ee3c2369
fix precedence
2007-11-12 21:50:21 +00:00
Alasdair Kergon
c74fa11518
readahead activation code (but no dm support yet)
2007-11-12 20:51:54 +00:00
Dave Wysochanski
17c9975c0b
Fix compile warnings / minor errors introduced recently.
2007-11-12 20:02:55 +00:00
Alasdair Kergon
6c1cdff912
Remove new mirror logs when creation fails.
2007-11-12 14:36:57 +00:00
Alasdair Kergon
705b96c6f9
Fix orphan-related locking in pvdisplay and pvs.
...
Fix missing VG unlocks in some pvchange error paths.
Add some missing validation of VG names.
Rename validate_vg_name() to validate_new_vg_name().
Change orphan lock to VG_ORPHANS.
Change format1 to use ORPHAN as orphan VG name.
2007-11-02 20:40:05 +00:00
Bryn M. Reeves
ee79277774
Add is_orphan_vg() and change all hardcoded checks to use it.
2007-11-02 13:06:42 +00:00
Dave Wysochanski
9691ecc839
Add pv_dev_name() to access PV device name.
...
Patch by Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
2007-10-12 14:29:32 +00:00
Dave Wysochanski
fe7cd72cff
Non-functional change - refactor lv_create_empty().
...
Remove struct format_instance param - we can safely obtain
this from vg->fid inside the function.
2007-10-11 19:20:38 +00:00
Jim Meyering
d3380f41de
Diagnose invalid PE values given on the pvmove command line (64-bit systems).
...
* tools/toollib.c (xstrtouint32): New function.
(_parse_pes): Use xstrtouint32; don't cast strtoul's unsigned
long to uint32_t. Detect overflow.
Author: Jim Meyering <jim@meyering.net>
2007-09-11 20:12:54 +00:00
Alasdair Kergon
d080291150
Clean up numerous compiler warnings that crept in recently.
...
Remove several unused parameters from _allocate().
2007-08-22 14:38:18 +00:00
Alasdair Kergon
3f507a26fb
Fix inconsistent licence notices: executables are GPLv2; libraries LGPLv2.1.
2007-08-20 20:55:30 +00:00
Jim Meyering
7454664997
Add "const" attributes where possible: first cut.
2007-08-07 09:06:05 +00:00
Alasdair Kergon
341bdc93e2
Call dev_iter_destroy() if _process_all_devs() is interrupted by sigint.
2007-07-10 17:51:26 +00:00
Dave Wysochanski
d2cb05988d
Convert vg->status checks to use vg_check_status function.\nRename status_flags to status in vg_check_status.
2007-06-19 04:36:12 +00:00
Petr Rockai
10e4254e7d
Allow keyboard interrupts in yes_no_prompt(). Add code to toollib.c
...
loops and to pvcreate.c, lvchange.c and lvresize.c to handle
interrupted prompts.
2007-06-15 10:11:14 +00:00
Dave Wysochanski
8b370b7cc1
Add vg_check_status to consolidate vg status flags checks and error messages.
2007-06-06 19:40:28 +00:00
Milan Broz
fa9407089c
Fix creation and conversion of mirrors with tags.
2007-03-26 16:10:10 +00:00
Alasdair Kergon
9a8f21aa03
Support the /dev/mapper prefix on most command lines.
2007-03-09 20:47:41 +00:00
Alasdair Kergon
edb9c3cc9f
Fix partition table processing after sparc changes (introduced in 2.02.16).
...
Fix cmdline PE range processing segfault (introduced in 2.02.13).
2007-01-15 21:55:11 +00:00
Alasdair Kergon
e76a9c2618
fix shift
2006-11-03 21:23:06 +00:00
Alasdair Kergon
45be8a836b
fix last check-in: lv->size is in sectors
2006-11-03 21:07:15 +00:00
Alasdair Kergon
954b6032e7
Fix mirror log LV writing to set all bits in whole LV.
2006-11-02 23:33:20 +00:00
Alasdair Kergon
fefa8e9b4d
Add dev_flush() to set_lv()
2006-10-24 18:25:30 +00:00
Alasdair Kergon
85e6042941
Cope if same PV is included more than once in cmdline PE range list.
2006-10-21 23:18:43 +00:00
