shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity
19,472 Commits 425 Branches 667 Tags 54 MiB
aa75e1f0bf
Commit Graph

32 Commits

Author SHA1 Message Date
Zdenek Kabelac
b1d80a0ffd gcc: pipe error path 
Close opened descriptors on failed fork path.
 2024-06-19 14:28:02 +02:00
Zdenek Kabelac
4d2311655b lvm-exec: refactor code 
Add prepare_exec_args() for reading option list for
thin/cache_repair, thin/cache_check.
 2023-07-17 12:44:23 +02:00
Zdenek Kabelac
a8ee13900d cov: initialize attr 2021-09-13 12:34:41 +02:00
Joe Thornber
89fdc0b588 Merge branch 'master' into 2018-05-11-fork-libdm 2018-05-16 13:43:02 +01:00
Joe Thornber
7f97c7ea9a build: Don't generate symlinks in include/ dir 
As we start refactoring the code to break dependencies (see doc/refactoring.txt),
I want us to use full paths in the includes (eg, #include "base/data-struct/list.h").
This makes it more obvious when we're breaking abstraction boundaries, eg, including a file in
metadata/ from base/
 2018-05-14 10:30:20 +01:00
David Teigland
bbb8040456 dev_cache: drop open_list 
devices are now held open only in bcache,
so drop the dev_cache list of open devices
which is unused.
 2018-05-11 12:47:56 -05:00
Zdenek Kabelac
fcbef05aae doc: change fsf address 
Hmm rpmlint suggest fsf is using a different address these days,
so lets keep it up-to-date
 2016-01-21 12:11:37 +01:00
Zdenek Kabelac
22e19cb354 cleanup: reoder rstatus init 
In all error paths always initialize *rstatus.
 2015-11-09 10:22:52 +01:00
Alasdair G Kergon
4c629a5257 locking: Add missing error handling. 
Add missing error logging and detection to unlock_vg and callers
of sync_local_dev_names etc.
 2015-06-30 18:54:38 +01:00
Zdenek Kabelac
89615af349 exec_cmd: skip fork when argv[0] is null 
Skip whole fork code path if the arg would be null.
 2014-04-08 11:00:13 +02:00
Zdenek Kabelac
9d69585b82 cleanup: remove unneeded header files 2014-02-11 19:00:06 +01:00
Peter Rajnoha
0563bd0037 fix: some issues reported by coverity 
- null_fd resource leak on error path in _reopen_fd_null fn
  - dead code in verify_message in clvmd code
  - dead code in _init_filter_components in toolcontext code
  - null dereference in dm_prepare_selinux_context on error path if
    setfscreatecon fails while resetting SELinux context
 2013-08-15 12:23:49 +02:00
Zdenek Kabelac
f6dd5a294b exec: pipe open 
Function replaces popen() system and avoids shell execution
and argument parsing (no surprices).
 2013-08-06 16:18:43 +02:00
Zdenek Kabelac
b6437a6180 cleanup: update exec_cmd comment and error 
Use log_sys_error for reporting error of system call.
Fix comment for return value.
 2013-08-06 16:16:57 +02:00
Zdenek Kabelac
dfca5dac9c cleanup: explicit check for nonnull pointer 
Since execvp requires nonnull args - add explicit check.
 2013-04-21 23:14:05 +02:00
Zdenek Kabelac
f194dabb09 Just space moving 
Don't leave space on EOL.
 2012-03-02 22:58:23 +00:00
Zdenek Kabelac
ce840163c0 Revert patch 
Caller of exec must report log_error when rstatus is passed.
 2011-09-19 18:38:43 +00:00
Zdenek Kabelac
4eeff46bf2 Use log_error instead of log_verbose when executed command fails 2011-09-19 14:54:23 +00:00
Zdenek Kabelac
5f3f06db66 Move debug message 
so it does not look like we are executing command in the middle of
critical_section in log trace.
 2011-09-19 12:48:02 +00:00
Zdenek Kabelac
586f310618 Remove meaningless const type qualifiers on cast type 
Static analyzis noticed we do not really need them - so removing.
 2011-08-04 14:30:51 +00:00
Zdenek Kabelac
b1b38215ba Add exec_cmd paramater sync_needed 
As sync_local_dev_names() cannot be called within activation context,
add new parametr which allows to select if the sync call is needed
before executing new command.
 2011-01-13 14:51:32 +00:00
Alasdair Kergon
a8de276520 Replace fs_unlock by sync_local_dev_names to notify local clvmd. (2.02.80) 
Introduce sync_local_dev_names and CLVMD_CMD_SYNC_NAMES to issue fs_unlock.
 2011-01-12 20:42:50 +00:00
Zdenek Kabelac
22b06cdcce Fix missing declaration for fs_unlock 2011-01-10 19:49:42 +00:00
Zdenek Kabelac
ad50450a22 Avoid cookie sharing between forked processes 
Before fork, ensure cookie is reset so it's not shared between processes.
 2011-01-10 19:31:02 +00:00
Zdenek Kabelac
2955b913ea Use new status code from fsadm check 
Patch updates exec_cmd() and adds 3rd parameter with pointer for
status value, so caller might examine returned status code.
If the passed pointer is NULL, behavior is unmodified.

Patch allows to confinue with lvresize if the failure from fsadm check is
caused by mounted filesystem as many of filesystem resize tools do support
online filesystem resize. (originally user had to use flag '-n' to bypass
this filesystem check)
 2010-11-01 14:17:35 +00:00
Mikulas Patocka
3395d72881 Change exit() to _exit() in the child process. exit flushes stdio file buffers, 
_exit doesn't. If there were some open files, an error in exec and subsequent
exit() would cause the buffers to be flushed twice.

Example:

#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>
#include <sys/wait.h>

int main()
{
	printf("buu");
	if (!fork()) {
		execl("/bin/true-not-exists", "/bin/true", NULL);
		exit(1);
	}
	wait(NULL);
	return 0;
}

Signed-off-by: Mikulas Patocka <mpatocka@redhat.com

---
 daemons/dmeventd/libdevmapper-event.c |    2 +-
 lib/misc/lvm-exec.c                   |    2 +-
 test/harness.c                        |    3 ++-
 tools/dmsetup.c                       |    2 +-
 4 files changed, 5 insertions(+), 4 deletions(-)
 2009-07-13 21:26:41 +00:00
Alasdair Kergon
ed82bfd2ba Attempt cleanup in child before execing new binary in exec_cmd() 2009-02-28 00:54:06 +00:00
Alasdair Kergon
bc175d2870 fsadm cleanups & release prep 2009-02-27 23:40:11 +00:00
Zdenek Kabelac
c8669f6b13 Fixed bug where lvresize option -t was not properly passed to fsadm. 
Using argv[] list in exec_cmd() to allow more params for external commands.
Fsadm does not allow checking mounted filesystem.
Fsadm no longer accepts 'any other key' as 'no' answer to y/n.
Fsadm improved handling of command line options.
 2009-02-24 15:48:00 +00:00
Alasdair Kergon
67cdbd7e4d Some whitespace tidy-ups. 2008-01-30 14:00:02 +00:00
Alasdair Kergon
be6845999b Fix inconsistent licence notices: executables are GPLv2; libraries LGPLv2.1. 2007-08-20 20:55:30 +00:00
Alasdair Kergon
a653923fe7 Attempt to load missing targets using modprobe. 2005-10-17 17:56:27 +00:00