Dave Wysochanski
3a30d1db20
Fix return values for reporting commands when run with no PVs, LVs, or VGs.
...
The new error checking code caught some commands that were returning '0' as
an exit status for success. This is incorrect and resulted in a benign error
message displayed (see below). As of today, all commands should return a
value defined in lib/commands/errors.h (1-5). This results in an exit code of
0 on success, or > 0 on failure (as stated in the lvm.8 man page).
Before change:
1. Make sure no PVs are on the system
2. Run 'pvs'
Command failed with status code 0.
After change:
<no output>
2008-06-10 20:07:04 +00:00
Dave Wysochanski
a3678fa186
Add ommitted unlock_vg() call when sigint_caught() during vg processing.
...
Specific test case:
1. pvcreate /dev/loop1; vgcreate vg1 /dev/loop1; lvcreate -L 64M -n lv1 vg1
2. vgremove vg1 (will prompt user)
3. CTRL-C
Code will exit with:
Do you really want to remove volume group "vg2" containing 2 logical volumes? [y/n]:
Volume group "vg2" not removed
Command failed with status code 5.
Internal error: Volume Group vg2 was not unlocked
Device '/dev/loop1' has been left open.
After change:
Do you really want to remove volume group "vg2" containing 2 logical volumes? [y/n]:
Volume group "vg2" not removed
Command failed with status code 5.
2008-06-10 15:25:38 +00:00
Zdenek Kabelac
d9c8469363
Fix wrong free_count on imported volume group from pool device
...
Fix segfault when calling pvcreate on the pool device
2008-06-10 14:55:14 +00:00
Alasdair Kergon
afbf31eba9
Fix inverted no_flush debug message. (mpatocka)
2008-06-10 11:19:19 +00:00
Alasdair Kergon
80b7fe0e88
Fix segfault after _free_vginfo by remembering to remove vginfo from list.
2008-06-09 16:22:33 +00:00
Dave Wysochanski
3a152aea38
Add simple test case to repro pvs segfault with duplicate vgnames.
2008-06-09 15:31:58 +00:00
Alasdair Kergon
fb7487a9aa
bring list.h into line with lvm2
2008-06-08 14:53:51 +00:00
Alasdair Kergon
bfadd2133e
Tweak detection of invalid fid after changes to PVs in VG in _vg_read.
2008-06-08 14:18:44 +00:00
Alasdair Kergon
424dd43e6f
Revert assuming precommitted metadata is live when activating (unnecessary).
2008-06-08 11:33:15 +00:00
Alasdair Kergon
034ceb60ab
.
2008-06-06 20:45:41 +00:00
Alasdair Kergon
2bd5b63f4a
rename some config vars
2008-06-06 20:44:35 +00:00
Alasdair Kergon
8bea657cac
Bring configure.in into line with the lvm2 version.
2008-06-06 20:33:13 +00:00
Alasdair Kergon
aa76972385
Drop cached metadata for disappearing VG in vgmerge.
2008-06-06 19:32:35 +00:00
Alasdair Kergon
ec40d92889
post-release
2008-06-06 19:28:35 +00:00
Alasdair Kergon
bccf22f6b4
pre-release
2008-06-06 19:09:19 +00:00
Alasdair Kergon
9df5c6e987
switch to single quotes rather than double for nameprefixes
2008-06-06 19:07:47 +00:00
Alasdair Kergon
0f4355d518
nameprefixes
2008-06-06 18:53:26 +00:00
Alasdair Kergon
db6056516e
change --prefixes to --nameprefixes
2008-06-06 18:53:08 +00:00
Alasdair Kergon
697e3bb2df
back out unnecessary changes for this release
2008-06-06 17:36:19 +00:00
Alasdair Kergon
0b1a6c4b0f
pre-release
2008-06-06 17:24:28 +00:00
Alasdair Kergon
cbb0489782
cleaner LCK_LV decoding
2008-06-06 16:37:51 +00:00
Alasdair Kergon
167c1633f2
cache dropping needs to use old name not new
...
rename variable to reduce confusion
2008-06-06 16:13:35 +00:00
Jim Meyering
644d83fb04
* lvm-utils.sh (init_root_dir_): Correct a diagnostic.
...
Author: Jim Meyering <meyering@redhat.com>
2008-06-06 13:48:57 +00:00
Alasdair Kergon
179b9822b4
Drop cached metadata when renaming a VG.
2008-06-06 13:04:44 +00:00
Alasdair Kergon
f0dfe9dcda
fix _free_vginfo not to remove a ref to a *different* vginfo from the vgid cache
2008-06-06 12:43:40 +00:00
Alasdair Kergon
d0de492ff3
cope with volatile vginfo in vg_read
2008-06-06 11:12:50 +00:00
Alasdair Kergon
57d0dc0db2
Allow for vginfo changing during _vg_read.
2008-06-06 09:48:04 +00:00
Alasdair Kergon
12ea7cb133
Initialise params buffer to empty string in _emit_segment.
2008-06-05 19:10:35 +00:00
Alasdair Kergon
e350c2f648
Decode numbers in clvmd debugging output.
2008-06-05 14:24:28 +00:00
Alasdair Kergon
bdf8c02f80
Add missing deactivation after activation failure in lvcreate -Zy.
2008-06-05 13:38:30 +00:00
Alasdair Kergon
e4b34bfad0
When activating, if precommitted metadata is still cached, assume it's live.
2008-06-05 13:06:39 +00:00
Alasdair Kergon
4bfa132445
When removing LV symlinks, skip any where the VG name is not determined.
2008-06-05 12:45:55 +00:00
Alasdair Kergon
ad134662a2
Drop metadata cache if update fails in vg_revert or vg_commit.
2008-06-03 17:56:54 +00:00
Alasdair Kergon
dcd5353502
Correct config file line numbers in messages when parsing comments. (kabi)
2008-06-03 17:51:04 +00:00
Alasdair Kergon
50fd61eb8d
suppress warning on silent failure with ECMD_PROCESSED
2008-06-03 17:48:13 +00:00
Dave Wysochanski
b2d6cb06c5
Trivial fix to lvchange man pg for consistency.
2008-06-02 15:54:32 +00:00
Alasdair Kergon
de24008109
In script-processing mode, stop if any command fails.
...
Warn if command exits with non-zero status code without a prior log_error.
2008-05-30 15:27:44 +00:00
Alasdair Kergon
0a5b690b70
fix setpriority int error
2008-05-28 23:12:45 +00:00
Alasdair Kergon
bdce11cb30
Avoid spurious duplicate VG messages referring to VGs that are gone.
...
(untested)
2008-05-28 22:27:47 +00:00
Alasdair Kergon
b947f34393
Skip add_dev_node when ioctls disabled.
...
Make dm_hash_iter safe against deletion.
Accept a NULL pointer to dm_free silently.
2008-05-21 16:14:46 +00:00
Alasdair Kergon
ace5664e7d
Temporarily disable dmeventd mirror monitoring during lvchange --resync.
2008-05-21 14:10:11 +00:00
Alasdair Kergon
25fbec5be1
revert accidental checkin
2008-05-19 20:06:34 +00:00
Alasdair Kergon
fc54be1062
Refactor some vginfo manipulation code.
2008-05-19 19:49:56 +00:00
Alasdair Kergon
3dfd8f12dc
more cleanup
2008-05-09 19:26:58 +00:00
Alasdair Kergon
98fd1ce332
More P_ and V_ lock cleanup.
2008-05-09 18:45:15 +00:00
Alasdair Kergon
3d6af3e35e
Add missing mutex around clvmd lvmcache_drop_metadata library call.
2008-05-09 15:13:20 +00:00
Christine Caulfield
5e91e174d3
Fix uninitialised mutex in clvmd if all daemons are not running at startup.
...
Thanks to Mark Hlawatschek for pointing this out.
2008-05-09 09:59:39 +00:00
Christine Caulfield
b1bf5f1738
Make clvmd-cman use a hash rather than an array for node updown info.
...
This will allow it to cope with very large nodeids such as those
generated by clusters using cman_tool join -X
2008-05-09 07:20:04 +00:00
Alasdair Kergon
1a20d53171
Avoid unnecessary unlock attempts with LCK_CACHE pseudo-locks.
2008-05-08 18:35:58 +00:00
Alasdair Kergon
3835ad6b1c
When asked to drop cached committed VG metadata, invalidate cached PV labels.
2008-05-08 18:28:27 +00:00
