Zdenek Kabelac
bc10d0373a
tests: fix working with devs in array
...
Also fixes one instance of invalid 'mirror_image_on' test
and places there correct indexed set of PVs.
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
fdbb680531
tests: check mirror_images_on fixed
...
Fix mirror_images_on() to actually report something useful (thought
it might be tuned later).
So for now the function got through all '_mimages_' and compares
where the order of them is matching given list of devices.
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
91d6a62fc5
tests: correcting usage of $@
...
Use "$@" (with quotes) to prevent whitespace problems.
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
f161c6ee9f
tests: assign as string
...
Assigning an array to a string! Assign as array, or use * instead of @ to concatenate.
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
2e47ab9b8c
tests: secure rm call
...
Use "${var:?}" to ensure this never expands to / .
(Should never happen as 'dir' was supposed to exist from preceding
test.)
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
4ed3f1bee3
tests: improve loop
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
e68d986cd5
tests: check result directly
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
160cb1e713
tests: replace cat usage
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
e11de5847d
tests: add space to split words
...
Fixing shellcheck warning:
This word is outside of quotes. Did you intend to 'nest '"'single quotes'"' instead'?
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
270e526734
tests: fix tests variable
...
Actually check $r instead or 'r' for test failure.
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
38917ee51c
tests: replace legacy code
...
Use $(..) instead of legacy `..`.
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
d606891e4a
tests: fix quoting
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
494d819a6f
tests: drop extra sourcing of utils
...
This sourceing is automatic by . lib/inittest
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
ff2242036b
tests: drop useless literal
...
Here was usage of '\' unneeded.
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
5214e62f09
tests: drop unneeded ;
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
c3d8ee4da2
tests: drop unneeded check
...
Test should actually fail in this condition as it's testing lvmetad.
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
4a5eea7758
tests: drop unneeded echo
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
2d96b758e4
tests: drop unneeded cat
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
eba96a9720
tests: fix possible misspelling
...
Possible misspelling: FAILED_MIXED_STR may not be assigned, but FAIL_MIXED_STR is.
Possible misspelling: FAILED_MULTI_STR may not be assigned, but FAIL_MULTI_STR is.
Possible misspelling: FAILED_BLACK_STR may not be assigned, but FAIL_BLACK_STR is.
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
d4345220cc
tests: avoid masking return values
...
Declare and assign separately to avoid masking return values.
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
146bfb2417
tests: math drop uncessary $/${}
...
$/${} is unnecessary on arithmetic variables.
Use $((..)) instead of deprecated $[..]
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
72e82b42a9
tests: aux.sh tweaks
...
Some improvements.
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
73cb5b486a
tests: aus.sh avoid duplicating arg list
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
f612fdd1dd
tests: aux.sh common pattern for starting daemons
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
4fc0166ca9
tests: aux.sh move corosyn
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
408e3b84f6
tests: cleanup msg
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
73bbd5528c
tests: scripts double quote
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
74ef5f07d0
tests: use read -r
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
7a8f87d28b
tests: replace egrep
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
bdd95051ed
tests: use bash array
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
efcbad25ee
tests: drop wc -l when grep -c works
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
e55bae2b2c
tests: use bash
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
24751b45bd
tests: double quote
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
5ca4fd0478
tests: correcting usage of '==' in bash
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
d12c0ae163
tests: utils.sh assign directly
...
Assign properly quoted vars in eval directly.
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
f21d812127
tests: get.sh use simplier tr
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
d426d7e709
tests: aux.sh check for already present config
...
'aux lvmconf' detects if new config needs to be regenerated.
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
32c0dc3549
tests: aux.sh double quote
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
84e83ac37e
tests: aux.sh replace sed call
...
Use internal shell vars manips
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
928a49a7c8
tests: aux.sh use grep -E
...
egrep is nonstandard.
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
5bd09cb79d
tests: aux.sh drop useless echo
...
Simply trim on space.
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
6be61bf044
tests: aux.sh check cd result
...
Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
2017-07-10 14:23:53 +02:00
Zdenek Kabelac
c87e1afa03
tests: export many shell vars with 1 command
2017-07-10 14:23:53 +02:00
Heinz Mauelshagen
70c340dbc2
test: return 0 if ignoring 'a' device health chars is requested
...
This allows lvconvert-raid-reshape-striped_to_linear.sh to succeed when
it reduces raid5 to two stripes before converting to raid1 and linear.
2017-07-04 19:34:10 +02:00
Zdenek Kabelac
006a9eaada
tests: aux.sh fix pattern
...
Commit 72a58ce4b0f68f6e45ae30606fe5af21caa42b43 fixed 'translation' of
pattern by bash by using "" - so we need to drop '\' here to get
wanted behavior.
2017-06-30 21:13:07 +02:00
Zdenek Kabelac
c31614eccc
tests: aux.sh use subshell for simple redirection
2017-06-30 17:08:47 +02:00
Zdenek Kabelac
57779e39ec
tests: correcting globbing usage
...
Ensure globbing uses current dir.
Break loop when no match is found.
Let STACKTRACE finish its output when gdb fails.
2017-06-30 14:40:50 +02:00
Zdenek Kabelac
9348ad4f16
tests: aux prepares lvmdbusd
...
Correctly skip the test when lvmdbusd is found already running.
For pgrep usage we need to add '-f -l' options to get python3 name
printed.
Remove no longer used 'pids' local var.
2017-06-30 12:12:16 +02:00
Zdenek Kabelac
674a93ffe3
tests: aux do not specify bitmap for raid0
2017-06-30 12:09:10 +02:00
Zdenek Kabelac
596cf2c6fa
tests: check LV in proper VG
2017-06-30 12:09:10 +02:00