Alasdair Kergon
f3f6c17250
use stack consistently if 0 is considered an error
2012-02-12 21:42:43 +00:00
Alasdair Kergon
2a434c479d
missing error mesg
2012-02-12 21:37:03 +00:00
Alasdair Kergon
10670c641b
remove unused bits after fid changes
2012-02-12 20:19:39 +00:00
Alasdair Kergon
72b50d7fd2
give standard error message if lstat fails unexpectedly
2012-02-12 20:17:12 +00:00
Petr Rockai
6e41729eb8
Keep a global (per-format) orphan_vg and keep any and all orphan PVs linked to
...
it. Avoids the need for FMT_INSTANCE_PV and enables further simplifications. No
functional change, internal refactor only.
2012-02-10 02:53:03 +00:00
Petr Rockai
8e5f7cf3dc
Move lvmcache data structures behind an API (making the structures private to
...
lvmcache.c). No functional change.
2012-02-10 01:28:27 +00:00
Peter Rajnoha
5fa417a9c0
Stop processing lvextend if trying to extend a mirror that is being recovered.
...
Missing correct return value in lv_extend fn.
2012-02-09 15:13:42 +00:00
Zdenek Kabelac
b93c1332d1
Move label_init up in code stack
...
label_exit() is called destroy_toolcontext() and we are now
using standard dm_list function for destroy, we have to make sure
dm_list gets initialized properly.
2012-02-08 13:44:49 +00:00
Zdenek Kabelac
a7e2da0585
Thin add pool_below_threshold
...
Test both data and metadata percent usage.
2012-02-08 13:05:38 +00:00
Zdenek Kabelac
94f88a4f14
Fix test for lv_snapshot_percent
...
Do not check for PERCENT_MERGE_FAILED if the lv_snapshot_percent() failed.
(test for snap_percent would be testing uninitialized value).
2012-02-08 13:02:07 +00:00
Zdenek Kabelac
9278655de1
Some fixmes
...
'len' calculation is unused ?
Unreachable code could be removed or moved upward ?
2012-02-08 12:57:15 +00:00
Zdenek Kabelac
462835faa0
Switch to return void
...
List delete cannot fail, so there is no reason to test for error.
2012-02-08 12:52:58 +00:00
Zdenek Kabelac
33dea28e23
Use dm_snprintf and improve error handling
...
Add standard error reporting with error logging.
Use plain alloc instead of zalloc for string buffer.
Use dm_snprintf with valid test for <0.
2012-02-08 12:50:10 +00:00
Zdenek Kabelac
7ffca95bb6
Add range test for device number
...
Check the output of atoi is in valid range.
2012-02-08 12:48:14 +00:00
Zdenek Kabelac
d75c5f06f0
Replace snprintf with dm_snprintf
...
snprintf testing for negative is replaced with dm_snprintf where this
test really works.
Add missing test for result of dm_snprintf().
2012-02-08 11:40:02 +00:00
Zdenek Kabelac
84fd8ea4bd
Move done jump lower
...
Since before 'goto done' is bufused zeroed, it would otherwise write 1
byte in front of buffer.
2012-02-08 11:31:29 +00:00
Zdenek Kabelac
b63b775143
Add boundary test for number of mirror devs and logs
...
As atoi may return negative value - test for both limits.
Test log_args for limits before calling alloca().
Code from dmeventd mirror plugin should probably share same code as
we have in mirrored.c.
2012-02-08 11:29:13 +00:00
Zdenek Kabelac
0154bcf0a7
Check that whole locking_dir fits _lock_dir buffer
2012-02-08 11:17:34 +00:00
Zdenek Kabelac
1a39fa0073
Move close few lines
...
Since the function dev_close() has code path, which really could close
file (for unlocked vg) and destroy dev handler, stay on safe side and move
the close few lines later, even our current use case shouldn't trigger
such scenario.
2012-02-08 11:15:38 +00:00
Zdenek Kabelac
02aeb23f1f
Use dm_list_iterate_items_safe
...
And avoid direct access to list member variables.
Inline _free_li().
2012-02-08 11:12:18 +00:00
Zdenek Kabelac
5dfd775384
Ensure strncpy() function always ends with '\0'
...
Since last character needs to be \0 for string,
pass buffer size smaller by 1 byte.
2012-02-08 11:05:04 +00:00
Zdenek Kabelac
ee54e43702
Fix resource leaks for failing allocation
...
In case, something would fail during format initialization,
return allocated memory.
2012-02-08 10:49:36 +00:00
Zdenek Kabelac
12ac6f9f11
Release allocated resources in error path
...
If composite_filter_create() fails, release filters.
2012-02-08 10:46:24 +00:00
Zdenek Kabelac
7b408a08ef
Check result of lstat
...
If lstat returns errno different from ENOENT, do not use the content of
struct stat 'buf'.
2012-02-08 10:43:42 +00:00
Alasdair Kergon
b167ca28b0
Adjust comments
2012-02-01 15:05:53 +00:00
Zdenek Kabelac
42b5c54092
Add synchornization point in mirror log init.
...
Put extra sync point when mirror log is deactivated and before
it's activated for the second time.
2012-02-01 13:50:36 +00:00
Zdenek Kabelac
ab852ffe66
Disable partial activation for thin LVs and LVs with all missing segments
...
Count number of error and existing areas and if there is no existing area
for the LV avoid its activation.
Always disable partial activatio for thin volumes.
For mirrors currently put in hack to let it pass with a special name
since current mirror code needs to activate such LV during some operations.
2012-02-01 13:47:27 +00:00
Zdenek Kabelac
dfb679e5c7
Avoid warning for small pv_min_size
...
Do not print warning for pv_min_size set in range between 512KB and 2MB.
2012-02-01 13:42:18 +00:00
Zdenek Kabelac
489bf2fbdf
Minor consistency update for debugging messages
...
Use mlock/munlock for debugging lines.
2012-02-01 10:48:22 +00:00
Alasdair Kergon
1368dc905a
lost line
2012-02-01 02:11:43 +00:00
Alasdair Kergon
72abf1d880
Track unreserved space for all alloc policies and then permit NORMAL to place
...
log and data on same single PV.
2012-02-01 02:10:45 +00:00
Alasdair Kergon
b6d7a48480
Automatically detect whether corosync clvmd needs to use confdb or cmap. (fabio)
2012-01-31 21:21:53 +00:00
Zdenek Kabelac
15fd61e492
Fix data% reporting
...
For reading % of mapped size of thin volume use as origin for
old style snapshot '-real' device needs to be queried.
Fix log_error report given for lvs -a in this case.
2012-01-28 20:12:26 +00:00
Zdenek Kabelac
7012268499
Thin for_each_sub_lv
...
Adapt to scan thin dependency LVs
2012-01-26 21:39:32 +00:00
Alasdair Kergon
a1991f101d
pre-release
2012-01-26 14:02:42 +00:00
Zdenek Kabelac
42beb34826
Set missing header define
2012-01-25 22:37:48 +00:00
Zdenek Kabelac
96bffe6a4a
Instrument code that pointer are already released
...
Set pointers to NULL since on the function exit they are no longer valid.
2012-01-25 22:35:36 +00:00
Zdenek Kabelac
209da6efee
Fix missing dmt destructor
...
Also always initialize maj,min,patchlevel when success is returned.
2012-01-25 22:16:04 +00:00
Zdenek Kabelac
a980f56d2a
Free allocated segment type in error path
2012-01-25 21:54:00 +00:00
Zdenek Kabelac
e6771e50a9
Check for correctness of uint64 value if exists
2012-01-25 21:43:51 +00:00
Alasdair Kergon
a2167d2d1d
& -> &&
2012-01-25 17:14:56 +00:00
Zdenek Kabelac
b185993628
Fix compilation with disabled devmapper
...
During release preparation things has changed, so making sure
we are compilable with --disable-devmapper.
2012-01-25 13:12:59 +00:00
Zdenek Kabelac
ca12090800
Thin read percent info from layered device
...
Since we only need layered device - check for tpool device presence,
so user doesn't need to activate thin pool explicitely for percent info.
2012-01-25 13:11:52 +00:00
Zdenek Kabelac
e8905d9816
Rename origin_only to more generic use_layer flag
...
Since now we have more layered devices i.e. thin volumes - support
selection of layer via flag.
2012-01-25 13:10:26 +00:00
Zdenek Kabelac
10e80a212f
Update verbose lvs to print metadata_percent info
...
Update lvs -o fields in WHATS_NEW.
2012-01-25 11:32:41 +00:00
Zdenek Kabelac
9b1fe5a062
Thin clear stacked message for thin pool
...
Before removing thin pool LV always make sure, stacked message
for previous run are cleared - but allow to remove any
device that should have been created
(i.e. creation of snapshot failed - so the message for snapshot creation
may be replaced with delete message within unfinished transaction).
Also commit messages after lv remove - so free space is released in pool.
2012-01-25 11:27:42 +00:00
Alasdair Kergon
c3f0ed04a6
Make commented out code more obvious
2012-01-25 11:10:06 +00:00
Zdenek Kabelac
89764fd494
Thin skip activation when there are no thin message
...
If the list with thin messages is empty, do not touch thin pool device.
2012-01-25 09:17:15 +00:00
Zdenek Kabelac
c771a70882
Thin correct activation order
...
When the message is passed only in resume path the order needs
to be corrected.
2012-01-25 09:15:44 +00:00
Zdenek Kabelac
3dadb176ce
Thin use suspend/resume_lv_origin
...
Use origin_only support for thin volume when thin snapshot is created.
2012-01-25 09:14:25 +00:00