Alasdair Kergon
906935e580
Add some basic internal VG lock validation.
2008-04-03 18:56:40 +00:00
Alasdair Kergon
c6cb6ddfb2
.
2008-04-03 14:40:34 +00:00
Alasdair Kergon
ea0e92830a
.
2008-04-03 14:32:31 +00:00
Alasdair Kergon
810e500118
fix vd->virtblk
2008-04-03 10:29:00 +00:00
Alasdair Kergon
bae74dff07
enable vg metadata cache by default
2008-04-02 21:31:14 +00:00
Alasdair Kergon
bf7dea978e
Add per-command flags to control which commands use the VG metadata cache.
2008-04-02 21:23:39 +00:00
Dave Wysochanski
cbfbc6766e
Fix vgsplit locking and remove unneeded error messages when split into new VG.
...
When vg_lock_and_read() calls were added, they were done so incorrectly for
the destination VG (vg_to). This resulted in the VG lock not obtained when
a new VG was the destination (vg_lock_and_read() would fail in the vg_read()
clause, which would then release the lock before returning NULL), and could
result in corrupted destination VG.
The fix was to put back the original lock_vol() and vg_read() calls for 'vg_to'.
The failure of vg_read() indicates "vg does not exist", and we key off that
to determine whether we are dealing with a new or existing VG as the
destination.
The first two error messages were also the result of the incorrect
vg_lock_and_read() calls:
Volume group "new" not found
cluster request failed: Invalid argument
New volume group "new" successfully split from "vg"
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=438249
2008-04-02 19:30:12 +00:00
Dave Wysochanski
e283bda91d
Suppress "Volume group not found" message when vgsplit of new VG.
2008-04-02 13:08:49 +00:00
Dave Wysochanski
d0bf2f3fa0
Fix lvresize to dump stack if vg_lock_and_read() fails.
...
Necessary because vg_lock_and_read() may fail silently if the vg_check_status() call fails.
Also add lvresize tests.
2008-04-02 12:17:30 +00:00
Alasdair Kergon
6e210a6c54
Cache VG metadata internally while VG lock is held.
2008-04-01 22:40:13 +00:00
Dave Wysochanski
33842916b0
Fix redundant lvresize message if vg doesn't exist.
...
BEFORE:
tools/lvm lvresize -l +4 vg22/lv1linear
Volume group "vg22" not found
Volume group vg22 doesn't exist
AFTER:
tools/lvm lvresize -l +4 vg22/lv1linear
Volume group "vg22" not found
2008-04-01 22:15:16 +00:00
Christine Caulfield
611c0689fc
Fix another allocation bug with clvmd and large node IDs.`
2008-04-01 15:01:30 +00:00
Dave Wysochanski
9332d2cb9d
Add find_lv_in_lv_list() and find_pv_in_pv_list().
...
Update _add_pvs() to call find_pv_in_pv_list().
2008-03-28 19:08:23 +00:00
Dave Wysochanski
a16d7d46dd
Enhance test debugging by updating verbose mode of check_*_field_ functions.
...
Author: Dave Wysochanski <dwysocha@redhat.com>
2008-03-28 18:02:22 +00:00
Christine Caulfield
2aa5120e82
Fix a couple of uninitialised variables. The newfd one could cause
...
some obscure hangs.
2008-03-28 12:58:09 +00:00
Dave Wysochanski
4f618eba00
Add vgmerge tests.
2008-03-26 18:03:35 +00:00
Dave Wysochanski
8e32e58e00
Use list_move() in applicable places.
2008-03-26 17:26:32 +00:00
Dave Wysochanski
052bbfba3a
Add pvseg_is_allocated() for identifying a PV segment allocated to a LV.
2008-03-26 16:48:10 +00:00
Dave Wysochanski
43aa463780
Add list_move() support function for list manipulation.
2008-03-26 16:20:54 +00:00
Dave Wysochanski
293db73c76
Add 'is_reserved_lvname()' helper function.
...
Very similar to apply_lvname_restrictions but without the error messages.
2008-03-25 15:24:59 +00:00
Alasdair Kergon
83465fde9b
Correct command name in lvmdiskscan man page.
2008-03-25 12:37:48 +00:00
Christine Caulfield
7750a1ade6
When reallocating the node IDs array, make it bigger rather than smaller!
2008-03-25 10:41:59 +00:00
Dave Wysochanski
c206c19c19
Add vgsplit tests to verfy attributes of new VG match source VG.
...
Author: Dave Wysochanski <dwysocha@redhat.com>
2008-03-23 15:40:35 +00:00
Dave Wysochanski
8a4c2b13bd
Fixup vgsplit tests in preparation for vgsplit changes.
2008-03-21 22:00:29 +00:00
Dave Wysochanski
dff4e43269
Update vgsplit tests to execute twice (existing and new VG as destination).
2008-03-21 21:14:38 +00:00
Dave Wysochanski
ec977d4c4f
Add LV and VG name restrictions to the lvm man page.
...
Original patch by: Gerrard Geldenhuis <Gerrard.Geldenhuis@datacash.com>
2008-03-20 18:34:29 +00:00
Alasdair Kergon
7284f3f966
preparation for vg cache
2008-03-17 16:51:31 +00:00
Christine Caulfield
ed070f4105
Fix potential thread deadlock.
...
Also make local sockets non-blocking.
2008-03-17 09:37:47 +00:00
Dave Wysochanski
ad8f37df1b
Const cleanups in find_* functions.
2008-03-13 22:51:24 +00:00
Alasdair Kergon
dc2bdce11e
Refactor text format initialisation into _init_text_import.
2008-03-13 12:33:22 +00:00
Milan Broz
94d271ff7b
Add metadata test for escaping double quotes in device names (bz431474).
2008-03-12 17:34:58 +00:00
Alasdair Kergon
d4ce89d9da
Escape double quotes and backslashes in external metadata and config data.
...
Add functions for escaping double quotes in strings.
Rename count_chars_len to count_chars.
2008-03-12 16:03:22 +00:00
Alasdair Kergon
bcacf9d0e3
Use return_0 in a couple more places.
...
Correct a function name typo in _line_append error message.
2008-03-10 18:51:27 +00:00
Christine Caulfield
66db5dd894
Include limits.h so it compiles with newer headers.
2008-03-06 08:41:05 +00:00
Alasdair Kergon
7eda3692f6
add vd to filters
2008-03-05 18:15:04 +00:00
Dave Wysochanski
3fa875dd79
Update vgsplit tests.
...
- Add validation on pv_count, lv_count, and snap_count after split
NOTE: Some of these counts are misleading. If you compare "lvs" output
with these counts you will be left scratching your head what a "logical volume"
really is. ;-)
2008-03-04 22:49:00 +00:00
Dave Wysochanski
da73d34264
Update vgsplit tests.
...
- Divide into 'usage' and 'operation' tests.
- Add operation tests for specific LV types.
2008-03-04 19:48:32 +00:00
Dave Wysochanski
a8bffd6c70
Refactor _move_pv() in vgsplit.
...
Should be no functional change.
2008-02-29 00:13:48 +00:00
Dave Wysochanski
8f613692fd
Add vgsplit test to check failure when PV not in source volume group.
2008-02-29 00:09:21 +00:00
Dave Wysochanski
c383a8717b
Fix t-vgsplit-operation.sh lv2-3 definitions to include test signature.
2008-02-28 17:39:47 +00:00
Dave Wysochanski
81625d8f65
Fix t-vgsplit-operation.sh lv1 definition to include test signature.
2008-02-28 16:48:09 +00:00
Alasdair Kergon
60be88a0a6
Fix resetting of MIRROR_IMAGE and VISIBLE_LV after removal of LV.
2008-02-22 13:28:29 +00:00
Alasdair Kergon
4c0f4125ec
Fix remove_layer_from_lv to empty the LV before removing it. (2.02.30)
2008-02-22 13:22:44 +00:00
Alasdair Kergon
39d3ec0b51
Add missing no-longer-used segs_using_this_lv test to check_lv_segments.
2008-02-22 13:22:21 +00:00
Jim Meyering
448ef456ff
Remove redundant if-before-free tests.
2008-02-15 14:14:58 +00:00
Jim Meyering
4349becadc
Remove redundant if-before-free tests in clvmd.c.
2008-02-15 14:12:32 +00:00
Jim Meyering
a34a6a3f71
is_orphan: make parameter "const" to avoid compiler warning
2008-02-13 20:01:48 +00:00
Alasdair Kergon
9790f608e9
Fix lvconvert detection of mirror conversion in progress.
2008-02-12 13:29:08 +00:00
Alasdair Kergon
b1ec1f87a4
Avoid automatic lvconvert polldaemon invocation when -R specified.
2008-02-12 13:26:53 +00:00
Dave Wysochanski
bcc4a38c1a
Reflect actual default setting of preferred_names in example.conf and
...
update comments.
2008-02-11 16:57:40 +00:00