Zdenek Kabelac
c5957ee2ff
cleanup: easier to read loop code
...
buffer_write now accepts const pointer
Simplify loops and drop goto when not needed.
2013-06-18 22:13:41 +02:00
Zdenek Kabelac
155841c349
lvmetad: fix compare function
...
Check for enough space in preallocated buffer.
Fixes problem, when lvm code started to suddenly allocate
too big memory chunks.
TODO: lvmetad protocol should announce needed size ahead,
so if metadata have 1MB we are not reallocating memory...
2013-06-18 22:12:51 +02:00
Zdenek Kabelac
e3d3921779
lvmetad: use dm_ malloc wrappers
...
Use matching dm_ functions for internally used buffers.
2013-06-18 22:11:31 +02:00
Alasdair G Kergon
981962b339
libdaemon: add logging to daemon_open
...
Log all conditions encountered in daemon_open().
Only store errno when known to be set.
2013-01-04 23:29:59 +00:00
Zdenek Kabelac
3e8dbfaecf
lvmetad: add check for failure dm_config_write_node
...
Detect if dm_config_write_node failed and fail correctly.
2012-12-15 17:23:27 +01:00
Zdenek Kabelac
399fc1bb33
lvmetad: keep returned struct fully initialized
...
Always clear the response structure.
Simplify daemon_reply initialization.
2012-12-15 17:23:27 +01:00
Zdenek Kabelac
788ac7fa54
libdaemon: check for strdup result
...
Detect failure of dm_pool_strdup() and print error in fail path.
Save one extra strchr call - since we already know the distance
for the '=' character.
Drop stack trace from return after log_error().
2012-12-15 17:23:26 +01:00
Zdenek Kabelac
920352da70
lvmetad: fix leak of append on error path
2012-10-14 23:14:48 +02:00
Zdenek Kabelac
4379365cae
lvmetad: fix memory leaks in error paths
...
Destroy interator in error path.
Releasy any possible allocated buffer from buffer_append_f
and buffer_append_vf in error path.
2012-10-13 19:19:50 +02:00
Zdenek Kabelac
88c547d1ca
lvmetad: move initialization in the inner loop
...
Set append to NULL in the front of cycle, so the INTERNAL error path
is not leading to double-free of append pointer.
2012-10-13 19:15:15 +02:00
Zdenek Kabelac
feea5003cc
cleanup: remove unneeded headers
...
Header do not provide any needed symbols.
2012-10-13 19:13:25 +02:00
Zdenek Kabelac
5a958655dd
lvmetad: fix test for dm_asprintf
2012-10-12 11:36:01 +02:00
Zdenek Kabelac
f2a5d3ae3a
lvmetad: validate dm_asprintf in buffer_append_vf
...
Check result of dm_asprintf
Check buffer_append result
Declare vars in front
2012-10-12 10:59:10 +02:00
Zdenek Kabelac
5c792f620b
lvmetad: check result of buffer_realloc
2012-10-12 10:59:10 +02:00
Zdenek Kabelac
9ee071705b
cleanup: fix compiler warnings
...
remove unused vars
move var declarations into the front of functions.
fix some sign warnings
2012-10-12 10:25:07 +02:00
Petr Rockai
b07df8850a
libdaemon: Make buffer handling asymptotically more efficient.
2012-10-11 18:09:41 +02:00
Petr Rockai
a19a595343
libdaemon-client: Fix a memory leak in daemon_send.
2012-10-08 20:35:29 +02:00
Petr Rockai
662a2122f6
libdaemon: Split daemon-shared.[hc] into daemon-io.[hc] and config-util.[hc].
2012-09-26 17:26:23 +02:00
Petr Rockai
4ece923a4b
libdaemonclient: Use log_sys_error in place of perror.
2012-09-26 17:26:23 +02:00
Petr Rockai
7a2a1a7456
libdaemonclient: Use dm_{malloc,free} in place of {malloc,free}.
2012-09-26 17:26:23 +02:00
Petr Rockai
c731bb1ee1
lvmetad: Fix #845269 : SEGV on corrupt lvmetad response.
2012-09-26 17:26:23 +02:00
Petr Rockai
c9f56d639b
lvmetad: Use "%" PRId64 in place of "%d" for extra clarity.
2012-09-26 17:26:16 +02:00
Petr Rockai
c7b17836ea
Implement devices/global_filter.
...
The global filter is applied first, and is also applied in pvscan --cache (which
is called from udev rules to keep lvmetad updated). Cf. example.conf.
2012-09-26 14:49:15 +02:00
Petr Rockai
ea14d5159c
libdaemon: Extend and refactor APIs.
...
- move common dm_config_tree manipulation functions from lvmetad-core to
daemon-shared
- add config-tree-based request manipulation APIs to daemon-client
- factor out _v (va_list) variants of most variadic functions in libdaemon
2012-09-26 14:49:09 +02:00
Marian Csontos
3843f54974
[lvmetad] Continue reading/writing on EINTR
2012-08-02 16:50:37 +02:00
Marian Csontos
49ae67cba3
lvmetad: Skip redundant checks on no input
2012-08-02 16:50:37 +02:00
Zdenek Kabelac
6f3cd63551
cleanup: replace memset with struct initilization
...
Simplifies the code, properly detects too long socket paths,
drops unused parameter.
2012-06-22 13:23:03 +02:00
Peter Rajnoha
bf29fa49d3
Use dm_strncpy instead of plain strncpy while setting the socket path.
...
Also check the return value as it meaningless to work with truncated strings.
2012-04-27 09:52:33 +00:00
Peter Rajnoha
9a2b6bda59
strcpy -> strncpy in common daemon code.
2012-04-10 12:55:37 +00:00
Zdenek Kabelac
c452307543
Few more close and dev_close trace
...
Adding (void) where we cannot really report an error.
2012-03-01 21:12:37 +00:00
Petr Rockai
823268475c
Use 64 bit integers whenever extracting numbers from daemon replies.
2012-03-01 19:54:53 +00:00
Alasdair Kergon
7126d8c21b
Reflect new file locations, include file updates etc.
2012-02-28 18:35:04 +00:00
Alasdair Kergon
ec6559c93e
move daemon files
2012-02-28 18:30:39 +00:00
Alasdair Kergon
6d41ef6ce5
new makefiles
2012-02-28 18:26:40 +00:00
