shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-01-11 09:18:25 +03:00
Code Releases Activity
6,492 Commits 426 Branches 667 Tags 54 MiB
fa73b2ee3d
Commit Graph

6492 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jonathan Earl Brassow
d6f91a013b Change confusing message that is printed when a RAID device fails. 
s/Issue/Use/, otherwise it is easy to misread "Issue" as "Issuing" - causing
the user confusion as to whether the action was performed automatically or
whether they need to issue the command.
 2012-02-13 18:38:36 +00:00
Jonathan Earl Brassow
7daa233e48 Fix possible NULL pointer dereferences when updating mirror log. 
'_lv_update_log_type' takes a lvconvert_params argument so that it can pass
down the user's preference of 'region_size' and allocation_policy.  When
'mirror_remove_missing' was introduced (commit ID
95986e42a1) it didn't make sense to pass down
user preferences - so NULL was given instead.  While it may never happen in
practice, static analysis reveals that this argument could be dereferenced.
So, if the user preferences were not passed in, glean the necessary fields
from what is already set in the LV.

Reported-by: Zdenek Kabelac <zkabelac@redhat.com>
Signed-off-by: Jonathan Brassow <jbrassow@redhat.com>

(Not updating WHATSNEW for this simple clean-up.)
 2012-02-13 18:36:55 +00:00
Jonathan Earl Brassow
9159aec6f1 Fix bug that caused RAID devices to be unable to activate if sub-LV was missing. 
Commit 02f6f4902f introduced a bug that caused
RAID devices to fail to activate if the device for a single sub-LV failed.
The special case of LVM mirror was handled, but not LVM RAID.
EXAMPLE:
[root@bp-01 ~]# devices vg
  LV            Copy%  Devices
  lv            100.00 lv_rimage_0(0),lv_rimage_1(0)
  [lv_rimage_0]        /dev/sde1(1)
  [lv_rimage_1]        /dev/sdh1(1)
  [lv_rmeta_0]         /dev/sde1(0)
  [lv_rmeta_1]         /dev/sdh1(0)
[root@bp-01 ~]# vgchange -an vg
  0 logical volume(s) in volume group "vg" now active
[root@bp-01 ~]# off.sh sdh
Turning off sdh
[root@bp-01 ~]# vgchange -ay vg --partial
  Partial mode. Incomplete logical volumes will be processed.
  Couldn't find device with uuid fbI0YO-GX7x-firU-Vy5o-vzwx-vAKZ-feRxfF.
  Cannot activate vg/lv_rimage_1: all segments missing.
  0 logical volume(s) in volume group "vg" now active

AFTER this patch:
[root@bp-01 ~]# vgchange -ay vg --partial
  Partial mode. Incomplete logical volumes will be processed.
  Couldn't find device with uuid fbI0YO-GX7x-firU-Vy5o-vzwx-vAKZ-feRxfF.
  1 logical volume(s) in volume group "vg" now active
[root@bp-01 ~]# devices vg
  Couldn't find device with uuid fbI0YO-GX7x-firU-Vy5o-vzwx-vAKZ-feRxfF.
  LV            Copy%  Devices
  lv            100.00 lv_rimage_0(0),lv_rimage_1(0)
  [lv_rimage_0]        /dev/sde1(1)
  [lv_rimage_1]        unknown device(1)
  [lv_rmeta_0]         /dev/sde1(0)
  [lv_rmeta_1]         unknown device(0)
[root@bp-01 ~]# dmsetup table vg-lv; dmsetup status vg-lv
0 1024000 raid raid1 3 0 region_size 1024 2 253:2 253:3 - -
0 1024000 raid raid1 2 AD 1024000/1024000

No WHATSNEW update necessary because this is an intrarelease fix.

 brassow
 2012-02-13 17:59:21 +00:00
Peter Rajnoha
c5d7b90b2a Superfluous '/' in systemd_dir path. 2012-02-13 17:31:14 +00:00
Zdenek Kabelac
35d3d400ec Fix missing temp_buf init for error path 
In previous commit this was missing, also deallocate in reversed order.
 2012-02-13 14:39:24 +00:00
Zdenek Kabelac
0d38ef9273 Add internal error to guard vgname2 NULL dereference 2012-02-13 14:26:15 +00:00
Zdenek Kabelac
2b62c3ed69 Add some FIXME around allocation code 
Remove also unreachable break..
 2012-02-13 14:25:14 +00:00
Zdenek Kabelac
cc05bde071 Never try to test character past given buffer 
In case units[0] would be already '\0', do not check units[1].
 2012-02-13 14:23:40 +00:00
Zdenek Kabelac
27d46fc686 Make sure dereferenced words[0] and words[1] are defined 2012-02-13 14:17:04 +00:00
Peter Rajnoha
07d54dd4a7 Add configure --with-systemdsystemunitdir. 2012-02-13 13:02:47 +00:00
Zdenek Kabelac
e975f85035 Handle all succefull values from open() 2012-02-13 12:07:51 +00:00
Zdenek Kabelac
c868f0ebf0 Ensure allocated device does not leak on error path 
For unimplementd canonicalize_file_name set to NULL
 2012-02-13 12:06:39 +00:00
Zdenek Kabelac
5a4638e22b Add internal error for unsupported code paths 
Patch mainly helps static analyzers to better work with code paths
lvm code should never trigger.
 2012-02-13 11:25:56 +00:00
Zdenek Kabelac
afed769d42 Check for missing reply_uuid 2012-02-13 11:24:09 +00:00
Zdenek Kabelac
a140caa666 Check for allocation failure 2012-02-13 11:18:45 +00:00
Zdenek Kabelac
dab4bb3bdf Add check for allocation failure 2012-02-13 11:16:42 +00:00
Zdenek Kabelac
2833f81fb3 Add few missing allocation failures tests 2012-02-13 11:13:44 +00:00
Zdenek Kabelac
bbf912b644 Add check for rimage name allocation failure 2012-02-13 11:10:37 +00:00
Zdenek Kabelac
05e8ec79e0 Add check for mda_copy failure 2012-02-13 11:09:25 +00:00
Zdenek Kabelac
78188982d6 Add check for failure 2012-02-13 11:07:55 +00:00
Zdenek Kabelac
6890aea4ca Add free_orphan_vg 
Move commod code to destroy orphan VG into free_orphan_vg() function.
Use orphan vgmem for creation of PV lists.
Remove some free_pv_fid() calls (FIXME: check all of them)
FIXME: Check whether we could merge release_vg back again for all VGs.
 2012-02-13 11:03:59 +00:00
Zdenek Kabelac
b2b5a2268a If the same fid is already same avoid ref_counting 2012-02-13 11:01:34 +00:00
Zdenek Kabelac
5ca11ba420 Add missing test for failure of lvmcache_foreach_pv 2012-02-13 10:58:20 +00:00
Zdenek Kabelac
c227ad23cc Clean error paths for format instance 
With updated orphan VG code this code needed some updates.
Add missing log_error for allocation failures.
 2012-02-13 10:56:31 +00:00
Zdenek Kabelac
5dc08c01d3 Release_vg instead of plain free in error path 2012-02-13 10:53:31 +00:00
Zdenek Kabelac
ec6a14f40a Log error reporting for failing _alloc_pv 
Drop unneeded zeroing of zalloced memory region.
 2012-02-13 10:51:52 +00:00
Zdenek Kabelac
7cf73cbc1f Do not write to -1 buffer address 
In case of zero bytes would be read from sysfs, it would store '\0' on
temp_buf[-1] address.

Simplify some buffer length calculation and use strcpy if we've just
checked string fits in give buffer.

Replace jump label error: with bad: commonly used in libdm.
 2012-02-13 10:49:28 +00:00
Zdenek Kabelac
193c832d12 Remove duplicit test 
When it's space it's also not a '\0'.
 2012-02-13 10:45:26 +00:00
Milan Broz
82e18a35a9 Update autoconf. 2012-02-13 07:30:24 +00:00
Fabio M. Di Nitto
69b9a614c7 In the new corosync world, dlm is a standalone service. 
Fix clvmd init script to Require dlm service when building for the
new corosync or clvmd will fail to start.
 2012-02-13 05:24:57 +00:00
Alasdair Kergon
52fdced782 post-release 2012-02-13 00:23:21 +00:00
Alasdair Kergon
2a7e2fe2d3 pre-release 2012-02-12 23:02:52 +00:00
Alasdair Kergon
3b6c6f1319 FMT_INSTANCE_VG is redundant now 2012-02-12 23:01:19 +00:00
Alasdair Kergon
11b3b12336 FMT_INSTANCE_PV is no longer used 2012-02-12 22:37:24 +00:00
Alasdair Kergon
b8a4a2b40b use stack consistently if 0 is considered an error 2012-02-12 21:42:43 +00:00
Alasdair Kergon
3e15add713 missing error mesg 2012-02-12 21:37:03 +00:00
Alasdair Kergon
06eaf8974a remove unused bits after fid changes 2012-02-12 20:19:39 +00:00
Alasdair Kergon
4ceec2023f give standard error message if lstat fails unexpectedly 2012-02-12 20:17:12 +00:00
Zdenek Kabelac
777a797ec3 Fix message check 
Check pointer from strchr for NULL instead of crash later.
Badly formated message would have crash dmeventd otherwise.
 2012-02-10 15:17:52 +00:00
Zdenek Kabelac
c559180cca Check for deps pointer before dererence 
As _deps() call may return NULL - check for it.
 2012-02-10 14:48:28 +00:00
Zdenek Kabelac
9fde529762 Add validation of name and uuid 
Do not accept NULL pointers.
 2012-02-10 14:42:28 +00:00
Zdenek Kabelac
50504ab73e Do not crash for NULL sort_key 
Guard against NULL pointer for sort_key and let it behave like an empty
string would have been passed in (i.e. no key).
 2012-02-10 14:00:07 +00:00
Zdenek Kabelac
514976816d Return error for failing allocation 
Fix case, where final strdup would have failed and it would miss to return
failure for this case and return success and NULL pointer.
 2012-02-10 13:56:19 +00:00
Zdenek Kabelac
00067fb64a Add test for failing allocation 
Avoid memcpy to NULL if realloc fails.
 2012-02-10 13:52:05 +00:00
Zdenek Kabelac
f6aab411f8 Add test for memory allocation failures 
Replace asserts with test for failing memory allocation.
Add at least stack traces.
Index counter starts from 1 (0 reserved for error), so replacing fingerprint.
 2012-02-10 13:49:29 +00:00
Zdenek Kabelac
c966f07bbd Remove unreachable code 2012-02-10 13:46:23 +00:00
Petr Rockai
e8ada4a717 What's new. 2012-02-10 02:56:54 +00:00
Petr Rockai
14d7b7b4e9 Keep a global (per-format) orphan_vg and keep any and all orphan PVs linked to 
it. Avoids the need for FMT_INSTANCE_PV and enables further simplifications. No
functional change, internal refactor only.
 2012-02-10 02:53:03 +00:00
Petr Rockai
395ee036d7 What's new: lvmcache. 2012-02-10 01:29:46 +00:00
Petr Rockai
1a28df6bb4 Move lvmcache data structures behind an API (making the structures private to 
lvmcache.c). No functional change.
 2012-02-10 01:28:27 +00:00