Jonathan Earl Brassow
579d086d7a
- cleanup excessive indentation in tools/lvconvert.c:lvconvert_mirrors
2007-08-01 20:54:28 +00:00
Jonathan Earl Brassow
5efd97f108
lib/activate/activate.c:_lv_activate tries to monitor a device
...
regardless of whether it was successfully activated. Now fixed
to only monitor if it was successfully activated.
2007-08-01 20:29:07 +00:00
Jim Meyering
b58a94fed4
Don't leak a file descriptor in fcntl_lock_file(), when fcntl fails.
2007-07-28 15:20:36 +00:00
Jim Meyering
941e4f5567
Remove create_dir function; use now-equivalent dm_create_dir instead.
...
* lib/misc/lvm-file.c (_create_dir_recursive, create_dir): Remove functions.
* lib/misc/lvm-file.h (create_dir): Remove declaration.
* lib/commands/toolcontext.c (create_toolcontext): s/create_dir/dm_create_dir/
* lib/format_text/archiver.c (archive, backup): Likewise.
* lib/format_text/format-text.c (_add_dir): Likewise.
* lib/locking/file_locking.c (init_file_locking): Likewise.
Patch by Jun'ichi Nomura.
2007-07-28 12:26:21 +00:00
Jim Meyering
3f311f1daa
Export dm_create_dir (was create_dir) to help fix LVM2 link error
...
* lib/libdm-file.c (dm_create_dir): Rename from create_dir.
* lib/libdevmapper.h (dm_create_dir): Declare.
* lib/.exported_symbols: Add dm_create_dir.
* lib/ioctl/libdm-iface.c (_create_control): Update sole use.
Patch by Jun'ichi Nomura. Details in
http://www.redhat.com/archives/lvm-devel/2007-July/msg00040.html
2007-07-28 10:48:36 +00:00
Jim Meyering
1c200869d9
Make the libdevmapper version of create_dir equivalent to the LVM2 one.
...
(_create_dir_recursive): Refrain from logging a mkdir failure due to EROFS.
Patch by Jun'ichi Nomura.
2007-07-28 10:27:34 +00:00
Jim Meyering
87518d850b
Introduce log_sys_* macros from LVM2.
...
Convert existing "<string>: <function> failed: <strerror>" type messages
to use this macro. Patch by Jun'ichi Nomura.
2007-07-28 10:23:02 +00:00
Alasdair Kergon
3579b652e7
Add ps3disk devices.
2007-07-26 13:28:32 +00:00
Jim Meyering
1a5d6bd23d
Detect stream write failure reliably; new fn: lvm_fclose; use dm_fclose
...
* lib/misc/lvm-file.c (lvm_fclose): New function.
* lib/misc/lvm-file.h (lvm_fclose): Declare it.
* lib/config/config.c (write_config_file): Use the new function to detect
and diagnose unlikely write failure.
* lib/filters/filter-persistent.c (persistent_filter_dump): Likewise.
* lib/format_text/archive.c (archive_vg): Likewise.
* lib/format_text/format-text.c (_vg_write_file): Likewise.
* lib/log/log.c (fin_log): Similar, but use dm_fclose directly.
Include "\n" at end of each fprintf format string.
2007-07-24 17:48:08 +00:00
Milan Broz
3c11686036
Fix clvmd if compiled with gulm support. (2.02.26)
2007-07-24 15:35:11 +00:00
Jim Meyering
f28fd56f76
libdevmapper, dmeventd: be paranoid about detecting write failure
...
* dmeventd/dmeventd.c (_set_oom_adj): When writing to /proc/self/oom_adj,
detect failure even if it's hidden behind ferror. [Using dm_fclose's
extra ferror test here is probably not needed, since the amount written
is nowhere near BUFSIZ, but use it regardless, for consistency. ]
* lib/fs/libdevmapper.c (do_suspend): Detect fclose failure when
writing to suspend.
2007-07-24 14:16:48 +00:00
Jim Meyering
0c3cd7e292
dm_fclose: new function
...
* lib/libdevmapper.h: Declare it.
* lib/libdm-file.c (dm_fclose): Define it.
* lib/.exported_symbols: Add dm_fclose.
2007-07-24 14:15:45 +00:00
Dave Wysochanski
b07dabbe80
Trivial fix to lvdisplay man pg to recommend lvs
2007-07-24 11:29:55 +00:00
Dave Wysochanski
7a22df7be3
Trivial fix to lvdisplay man pg to correct volume size units
2007-07-24 10:58:01 +00:00
Dave Wysochanski
0c8b215a60
Update lvconvert and lvrename to use vg_lock_and_read
2007-07-23 22:20:42 +00:00
Dave Wysochanski
d2f218cc46
Fix error introduced with previous checkin
2007-07-23 21:10:36 +00:00
Dave Wysochanski
4f629c3bba
Add CORRECT_INCONSISTENT and FAIL_INCONSISTENT flags to vg_lock_and_read
2007-07-23 21:03:42 +00:00
Dave Wysochanski
891c3d298b
Add vg_lock_and_read() external library function.
2007-07-23 17:27:55 +00:00
Milan Broz
8a0de6c333
Fix loading of persistent cache if cache_dir is used. (2.02.23)
...
Move lstat warning in _compare_paths to verbose output only.
2007-07-23 10:45:49 +00:00
Milan Broz
622703467c
Fix compilation warning in util.c.
2007-07-23 10:41:19 +00:00
Jim Meyering
6c35e3c84c
Eliminate uses of strdup+basename. Use last_path_component instead.
...
* lib/misc/util.c, lib/misc/util.h (last_path_component): New files.
* lib/Makefile.in (SOURCES): Add misc/util.c.
* lib/misc/lib.h: Include "util.h".
* tools/fsadm/fsadm.c: Include "util.h". (_usage): Use last_path_component,
not basename.
* tools/lvmcmdline.c (_find_command, lvm2_main): Likewise.
* include/.symlinks: Add lib/misc/util.h.
2007-07-20 15:48:39 +00:00
Jim Meyering
bbcd24607c
Use gcc's printf attribute wherever possible.
...
* daemons/clvmd/clvmd.h (debuglog): Add __attribute__((printf)).
* lib/config/config.c (_line_append): Likewise.
* lib/misc/lvm-string.h (emit_to_buffer): Likewise.
2007-07-20 15:38:19 +00:00
Jim Meyering
e732de541e
In _line_append, use "sizeof buf - 1" rather than equivalent "4095"
...
* lib/config/config.c:
2007-07-20 15:26:39 +00:00
Jim Meyering
c93e6b5f79
Introduce is_same_inode macro, now including a comparison of st_dev.
...
* lib/misc/lvm-file.h (is_same_inode): Define.
* lib/filters/filter-persistent.c (persistent_filter_dump): Use is_same_inode
in place of a direct st_ino-only comparison.
* lib/locking/file_locking.c (_release_lock, _lock_file): Likewise.
2007-07-20 15:22:46 +00:00
Jim Meyering
57015b12e2
Don't leak a file descriptor in _lock_file when flock fails.
...
* lib/locking/file_locking.c (_lock_file): Close fd upon flock failure.
2007-07-20 12:12:52 +00:00
Patrick Caulfield
35b13fdb5e
Add SUN's LDOM virtual block device to filters
...
Thanks to Fabio Massimo Di Nitto
2007-07-19 07:06:47 +00:00
Alasdair Kergon
03eee0e2ed
Split metadata-external.h out from metadata.h for the tools to use.
2007-07-18 15:38:58 +00:00
Alasdair Kergon
f5840016f3
post-release
2007-07-17 20:53:51 +00:00
Alasdair Kergon
6fb02eb2d9
pre-release
2007-07-17 20:45:17 +00:00
Milan Broz
5b7d162947
Fix snapshot cow area deactivation if origin is not active. (2.02.13)
2007-07-17 16:13:12 +00:00
Alasdair Kergon
d1158c75e8
Fix configure libdevmapper.h check when --with-dmdir is used.
2007-07-13 17:08:00 +00:00
Alasdair Kergon
a7ed0103ef
post-release
2007-07-13 16:10:24 +00:00
Alasdair Kergon
10fb6b1b93
pre-release
2007-07-13 16:07:30 +00:00
Dave Wysochanski
33e5601937
Change pv_read_path to pv_by_path
2007-07-12 15:38:53 +00:00
Dave Wysochanski
0c795e2e18
Turn _add_pv_to_vg() into external library function add_pv_to_vg()
2007-07-12 05:04:42 +00:00
Dave Wysochanski
30303765a3
Refactor vg_extend error path.
2007-07-12 04:12:04 +00:00
Dave Wysochanski
c254039677
Add pv_read_path, a proposed external LVM library function to take a device path and return a PV handle
2007-07-11 23:33:12 +00:00
Patrick Caulfield
b3ae66ae58
Tidy bits of clvmd-openais and improve an error report.
2007-07-11 12:07:39 +00:00
Alasdair Kergon
3c21da1797
Cope with find_seg_by_le() failure in check_lv_segments().
2007-07-10 18:50:03 +00:00
Alasdair Kergon
eac952f3fe
tidy
2007-07-10 18:20:00 +00:00
Alasdair Kergon
19fa139341
Fix pv_mda_count to cope with missing PV.
...
[vgcreate vg1 pv1 pv2; pvremove -ff pv1; pvs -P -o+pv_mda_count =>segfault]
2007-07-10 18:18:33 +00:00
Alasdair Kergon
fb697f281b
Call dev_iter_destroy() if _process_all_devs() is interrupted by sigint.
2007-07-10 17:51:26 +00:00
Alasdair Kergon
d27e123310
Add vg_mda_count and pv_mda_count columns to reports.
2007-07-09 15:40:43 +00:00
Alasdair Kergon
68c87619bd
Fix dumpconfig to use log_print instead of stdout directly.
2007-07-08 22:51:20 +00:00
Dave Wysochanski
fba549f8c2
Fix WHATS_NEW for last checkin until further patches for LVM library are ready.
2007-07-03 13:10:14 +00:00
Dave Wysochanski
ea8a12dbc1
Convert _add_pv_to_vg to usable LVM library function.
2007-07-02 21:48:30 +00:00
Milan Broz
32998a5e4f
Add kernel and device-mapper targets versions report to lvmdump.
2007-07-02 20:18:38 +00:00
Dave Wysochanski
13835b5f6c
Don't use index and rindex functions marked by SUSv3 as legacy - Jakub Bogusz <qboosh@pld-linux.org>
2007-07-02 11:17:21 +00:00
Milan Broz
b9567c9561
Fix vgsplit if splitting all PVs from VG.
2007-06-28 17:59:34 +00:00
Petr Rockai
e7ddf4168d
Make warnings go to stderr. Change log_warn to that effect, log_print
...
continues to send messages to stdout.
2007-06-28 17:33:44 +00:00