shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity
19,490 Commits 425 Branches 667 Tags 54 MiB
ff2cadbf18
Commit Graph

288 Commits

Author SHA1 Message Date
Zdenek Kabelac
7f8badfe5e Use memcpy and add error message 
strncpy (which check each byte for \0) is not need as we always copy
the length size - so using memcpy is a bit cheaper.

Add missing log_error message for failed allocation.
 2011-01-28 10:19:00 +00:00
Zdenek Kabelac
f7e7f3e3ed Add checks for allocation errors in config node clonning. 
Add checks for clonning allocation a fail-out when something is
not allocated correctly.

Also move var declaration to the begining of the function
and fix log_error messages.
 2010-12-20 13:53:10 +00:00
Zdenek Kabelac
ba96eb24fa Some const cleanups 
Minor const warning fixes and internal API updates.
 2010-12-20 13:19:13 +00:00
Zdenek Kabelac
760d1fac55 Add more strict const pointers around config tree 
To have better control were the config tree could be modified use more
const pointers and very carefully downcast them back to non-const
(for config tree merge).
 2010-12-20 13:12:55 +00:00
Zdenek Kabelac
14caa4a2d0 Add missing test for failed pool allocation 
Add test for NULL from dm_poll_create.
Reorder dm_pool_destroy() before file close and add label out:.
Avoid leaking file descriptor if the allocation fails.
 2010-11-30 22:23:35 +00:00
Zdenek Kabelac
7d11d708d8 Move va_end() so it is also used before error path return 2010-11-23 15:08:57 +00:00
Alasdair Kergon
ac0252ca07 Add dm_zalloc and use it and dm_pool_zalloc throughout. 2010-09-30 21:06:50 +00:00
Alasdair Kergon
44a31a9c2f Speed up CRC32 calculations by using a larger lookup table. 
Use -DDEBUG_CRC32 to revert to old function and check new one gives same result.
 2010-09-27 19:09:34 +00:00
Alasdair Kergon
08f1ddea6c Use __attribute__ consistently throughout. 2010-07-09 15:34:40 +00:00
Alasdair Kergon
0693099223 Don't ignore error if resuming any LV fails in resume_lvs. 
Skip closing persistent filter cache file if open failed.
 2010-04-12 11:52:53 +00:00
Alasdair Kergon
258db3ad8e Change most remaining log_error WARNING messages to log_warn. 2010-04-01 10:34:09 +00:00
Petr Rockai
6ce24f679a Fix the "const discarded" warnings introduced in the unknown segment patch. 2009-10-22 10:38:07 +00:00
Petr Rockai
b4048242f5 Handle metadata with unknown segment types more gracefully. 2009-10-16 17:41:49 +00:00
Dave Wysochanski
9085c301e0 Rename _override_settings into override_config_tree_from_string and move. 
Move _override_settings from tools/lvmcmdline.c into lib/config/config.c
and export so we can re-use in liblvm.
 2009-07-27 21:01:56 +00:00
Milan Broz
25497e2fa5 Fix confusing metadata syntax error messages. 
If there is syntax error in metadata, it now prints messages
like:
  Couldn't read 'start_extent' for segment 'extent_count'.
  Couldn't read all logical volumes for volume group vg_test.

The segment specification is wrong and confusing.

Patch fixes it by introducing "parent" member in config_node which
points to parent section and config_parent_name function, which
provides pointer to node section name.

Also it adds several LV references where possible.
 2009-07-09 11:29:00 +00:00
Milan Broz
aa8111b3cd fix some issues when compiling with -D DEBUG_POOL 
- fix compilation issues
- fix wrong pool object maipulation (lvm dumpconfig triggers assert)
- second iteration in loop _log_parallel_areas operates on non-existing object
 2009-03-26 09:25:18 +00:00
Alasdair Kergon
2c44337bd5 Right, a simple build (without options) is working again. 2008-11-03 22:14:30 +00:00
Zdenek Kabelac
74b91fad28 * more strict const 2008-08-07 14:02:32 +00:00
Alasdair Kergon
131bc6f091 Avoid looping forever in _pv_analyze_mda_raw used by pvck. 2008-07-31 13:07:01 +00:00
Alasdair Kergon
dcd5353502 Correct config file line numbers in messages when parsing comments. (kabi) 2008-06-03 17:51:04 +00:00
Alasdair Kergon
d4ce89d9da Escape double quotes and backslashes in external metadata and config data. 
Add functions for escaping double quotes in strings.
Rename count_chars_len to count_chars.
 2008-03-12 16:03:22 +00:00
Alasdair Kergon
bcacf9d0e3 Use return_0 in a couple more places. 
Correct a function name typo in _line_append error message.
 2008-03-10 18:51:27 +00:00
Alasdair Kergon
c51b9fff19 Use stack return macros throughout. 2008-01-30 13:19:47 +00:00
Alasdair Kergon
21bc366486 Clean up numerous compiler warnings that crept in recently. 
Remove several unused parameters from _allocate().
 2007-08-22 14:38:18 +00:00
Alasdair Kergon
be6845999b Fix inconsistent licence notices: executables are GPLv2; libraries LGPLv2.1. 2007-08-20 20:55:30 +00:00
Jim Meyering
1a5d6bd23d Detect stream write failure reliably; new fn: lvm_fclose; use dm_fclose 
* lib/misc/lvm-file.c (lvm_fclose): New function.
* lib/misc/lvm-file.h (lvm_fclose): Declare it.
* lib/config/config.c (write_config_file): Use the new function to detect
and diagnose unlikely write failure.
* lib/filters/filter-persistent.c (persistent_filter_dump): Likewise.
* lib/format_text/archive.c (archive_vg): Likewise.
* lib/format_text/format-text.c (_vg_write_file): Likewise.
* lib/log/log.c (fin_log): Similar, but use dm_fclose directly.
Include "\n" at end of each fprintf format string.
 2007-07-24 17:48:08 +00:00
Jim Meyering
bbcd24607c Use gcc's printf attribute wherever possible. 
* daemons/clvmd/clvmd.h (debuglog): Add __attribute__((printf)).
* lib/config/config.c (_line_append): Likewise.
* lib/misc/lvm-string.h (emit_to_buffer): Likewise.
 2007-07-20 15:38:19 +00:00
Jim Meyering
e732de541e In _line_append, use "sizeof buf - 1" rather than equivalent "4095" 
* lib/config/config.c:
 2007-07-20 15:26:39 +00:00
Alasdair Kergon
68c87619bd Fix dumpconfig to use log_print instead of stdout directly. 2007-07-08 22:51:20 +00:00
Dave Wysochanski
7da624db7b Fix a couple benign warnings by adding variable initializations. 2007-06-13 15:11:19 +00:00
Alasdair Kergon
19eb95f72f Fix get_config_uint64() to read a 64-bit value not a 32-bit one. 2007-04-27 20:41:50 +00:00
Dave Wysochanski
867c3249cb Fix warnings on x86_64 involving ptrdiff_t: 
config/config.c:493: warning: format '%d' expects type 'int', but argument 5 has type 'long int'

Modified original patch from Jim Meyering <jim@meyering.net>
 2007-04-26 16:40:46 +00:00
Dave Wysochanski
084a8bdcbc Add support functions for analysis of config sections, 
and hence, on-disk LVM2 metadata.

--
 2007-04-25 20:38:39 +00:00
Dave Wysochanski
662e0238f0 Add dev_read_circular, read 2 regions on same device. 2007-04-19 02:10:42 +00:00
Alasdair Kergon
af91456949 Fix two more segfaults if an empty config file section encountered. 2007-03-08 19:22:52 +00:00
Alasdair Kergon
2e1b92e3ea Add some missing close() and fclose() return code checks. 
Fix exit statuses of reporting tools (2.02.19).
 2007-01-25 14:37:48 +00:00
Alasdair Kergon
6a91a99b1b Fix a segfault if an empty config file section encountered. 2007-01-17 16:22:59 +00:00
Alasdair Kergon
2eeb2a1f54 dumpconfig accepts a list of configuration variables to display. 
Change dumpconfig to use --file to redirect output to a file.
 2007-01-09 23:22:31 +00:00
Alasdair Kergon
9ce2c9bfc1 fix _find_config_node: null parameter is permitted 2006-11-21 15:13:36 +00:00
Alasdair Kergon
9f7e77099b Warn if certain duplicate config file entries are seen. 
(not thoroughly tested)
 2006-11-16 17:36:00 +00:00
Alasdair Kergon
c1c16a8f01 Protect .cache manipulations with fcntl locking. 
Change .cache timestamp comparisons to use ctime.
 2006-11-04 03:34:10 +00:00
Alasdair Kergon
916490f8bf Add lvm_getpagesize wrapper. 2006-08-17 18:23:44 +00:00
Alasdair Kergon
2293567c8c Fix lvcreate corelog validation. 
Add --config for overriding most config file settings from cmdline.
  Quote arguments when printing command line.
  Remove linefeed from 'initialising logging' message.
  Add 'Completed' debug message.
  Don't attempt library exit after reloading config files.
  Always compile with libdevmapper, even if device-mapper is disabled.
 2006-05-16 16:48:31 +00:00
Alasdair Kergon
2c7fbadeef more coverity fixes 2006-05-10 17:49:25 +00:00
Alasdair Kergon
8b4273d298 missing { 2006-04-28 21:07:19 +00:00
Alasdair Kergon
81b4308bde Ignore empty strings in config files. 2006-04-28 13:30:59 +00:00
Alasdair Kergon
2262b32057 Use hash, bitset, malloc, pool from libdevmapper. 2005-10-16 23:03:59 +00:00
Alasdair Kergon
15db9fcfbf Reinstate full PV size when removing from VG. 
Support loopfiles for testing.
Complete the pv_segment support.
 2005-05-03 17:28:23 +00:00
Alasdair Kergon
bd46a496c7 pool debugging 2004-11-23 18:23:23 +00:00
Alasdair Kergon
25579907fc Support tagged config files. 2004-05-04 18:28:15 +00:00
Alasdair Kergon
6606c3ae81 Update copyright notices. 2004-03-30 19:35:44 +00:00
Alasdair Kergon
814643d8a2 rename config file vars & always use / as separator 2004-03-08 18:28:45 +00:00
Alasdair Kergon
dcc31da516 dumpconfig to dump active configuration 2003-10-15 20:17:19 +00:00
Alasdair Kergon
21a1fa4701 Accept signed numbers in config file. 2003-07-15 16:32:20 +00:00
Alasdair Kergon
914c97239f Another sync point - numerous fixes & clean ups. 2003-07-04 22:34:56 +00:00
Alasdair Kergon
26e7f2e0c4 Tidy various pre-processing incl. making libdl optional. 2003-03-24 18:08:53 +00:00
Alasdair Kergon
3a1703294b Fix incomplete munmap. (pjc) 2003-03-20 14:29:28 +00:00
Alasdair Kergon
c0002e576e Identifiers may now start with digits etc. 2003-02-03 20:08:45 +00:00
Alasdair Kergon
efb63f4740 Allow strings in single quotes too 2003-01-28 17:20:11 +00:00
Alasdair Kergon
41102098e5 Treat 'section{' as equivalent to 'section {' 2003-01-28 16:07:04 +00:00
Alasdair Kergon
fdf481c665 Ignore filter cache at startup if config file is newer than cache. 2003-01-06 21:09:04 +00:00
Alasdair Kergon
8ef2b021ed Default stripesize 64k & config file setting for it; 
Clear many compiler warnings (i386) & associated bugs - hopefully without
introducing too many new bugs:-)  (Same exercise required for other archs.)
Default compilation has optimisation - or else use ./configure --enable-debug
 2002-12-19 23:25:55 +00:00
Alasdair Kergon
4c64ed4ced New column-based reporting tools: lvs, pvs & vgs. 2002-12-12 20:55:49 +00:00
Alasdair Kergon
22d2827b41 Skip config file reload attempt if no config file location. 2002-11-26 12:14:37 +00:00
Alasdair Kergon
d1d9800ef1 Refactoring. 2002-11-18 14:01:16 +00:00
Joe Thornber
07bb413a8f o Added new value type CFG_EMPTY_ARRAY, to indicate '[]', useful since we use 
the arrays to hold a symbolic set of flags.
 2002-08-01 12:46:52 +00:00
Joe Thornber
ffa879d092 o 0 was used rather than NULL in a couple of places. 
o  Indent output with tabs rather than single spaces.
 2002-08-01 08:22:09 +00:00
Alasdair Kergon
48450b8f43 Add get_config_str 2002-07-11 14:07:43 +00:00
Alasdair Kergon
25b733809a Merge with text format branch. 
Lots of changes/very little testing so far => there'll be bugs!

Use 'vgcreate -M text' to create a volume group with its metadata stored
in text files.  Text format metadata changes should be reasonably atomic,
with a (basic) automatic recovery mechanism if the system crashes while a
change is in progress.

Add a metadata section to lvm.conf to specify multiple directories if
you want (recommended) to keep multiple copies of the metadata (eg on
different filesystems).

e.g. metadata {
        dirs = ["/etc/lvm/metadata1","/usr/local/lvm/metadata2"]
}

Plenty of refinements still in the pipeline.
 2002-04-24 18:20:51 +00:00
Alasdair Kergon
1176eb2597 Tweak some error message levels. 2002-01-27 21:30:47 +00:00
Alasdair Kergon
48a00f1320 o More comprehensive config parameter debugging messages. 
o Make /proc configurable.
 o Review hard-coded "/dev"s - made 2 more of them configurable.
 2002-01-15 23:34:13 +00:00
Alasdair Kergon
2801ddcacc Add 'get' functions. 2002-01-10 16:47:58 +00:00
Alasdair Kergon
4bbf2c3418 Accept octal values for numbers (such as umask). 2002-01-09 18:53:07 +00:00
Joe Thornber
330c46317c o Added find_config_bool 2002-01-07 10:23:52 +00:00
Joe Thornber
1b9fcf48b1 o LGPL list implementation 2001-10-31 12:47:01 +00:00
Joe Thornber
b892f8ecb6 o random little fixes 2001-10-30 17:53:21 +00:00
Joe Thornber
3cfae6cfce o Remove a couple of warnings, and one bug in ttree. Spotted by the optimiser 2001-10-25 13:08:29 +00:00
Joe Thornber
890b537974 o added aliases list to struct device. 2001-10-25 11:34:55 +00:00
Alasdair Kergon
4790fce2ad persistent filter & some log message changes 2001-10-23 18:20:27 +00:00
Alasdair Kergon
20a2b71c9c filter integration into tools 2001-10-23 11:50:49 +00:00
Alasdair Kergon
2d9133bbbd standardise some log messages 2001-10-10 16:36:32 +00:00
Joe Thornber
e6efb2b0bd o got dbg_malloc_t working, Alasdair could you look at the Makefile.in it 
seems to be having trouble with the dependencies.

o removed some files from the lib makefile that don't compile yet.
 2001-10-04 10:13:07 +00:00
Joe Thornber
b8e4e502d3 o code sync for dev-cache.c 
o made copyright headers the same

o added __attribute ((format ... to print_log so we'll get better compile errors

o added iterator to the hash table
 2001-10-03 11:06:31 +00:00
Alasdair Kergon
b8ef655fb7 Tidy include files 2001-10-01 15:14:39 +00:00
Alasdair Kergon
b5ab48be2a Initialise root node pointer. 2001-09-21 12:32:37 +00:00
Patrick Caulfield
e8cd263509 Fix includes so that string functions get prototyped 2001-09-13 12:38:31 +00:00
AJ Lewis
bb6ddc2de7 o Added a basic makefile to build liblvm.a again 
o Modified source files so that this works
 2001-08-21 15:23:45 +00:00
Joe Thornber
df88dece8b o Populating with stuff from experimental 2001-08-21 12:56:08 +00:00