Petr Rockai 9b2800e861 Fix a double close in clvmd. ...

The management threads (main_loop, the socket thread) could close a single fd
twice in a row sometimes. At least one other thread can be running at the same
time as the threads doing the double close. That one running thread also
happens to do some IO (namely, open /proc/devices, read from it, close it). If
there was enough "demand" for the local socket, this could happen:

- a connection to clvmd is about to finish, let's say the fd is 13 (it often
  happens to be in my test script, don't ask why)
- the local_sock thread calls close(13)
- the lvm thread calls open("/proc/devices"...) and gets 13
- the main_loop thread calls close(13) [OOPS!]
- new connection arrives, and is accept'd by a (new) local_sock thread
- the accept gives an fd of 13 (since it's the lowest free fd at this point)
- the lvm thread gets around to read from it's /proc/devices handle... 13,
  again
- the lvm thread hangs forever trying to read from the socket instead of
  /proc/devices

Signed-off-by: Petr Rockai <prockai@redhat.com>
Reviewed-by: Milan Broz <mbroz@redhat.com>

2010-10-27 09:13:37 +00:00

..

clvmd

Fix a double close in clvmd.

2010-10-27 09:13:37 +00:00

cmirrord

Add missing return for NULL passed buffer

2010-10-26 10:14:41 +00:00

dmeventd

Update C declaration () -> (void)

2010-10-26 08:54:37 +00:00

Makefile.in

Use vpath instead of VPATH.

2010-04-09 21:34:25 +00:00