David Teigland 0d0d50182d toollib: fix duplicate handling in process_each_pv ...

With use_lvmetad=0, duplicate PVs /dev/loop0 and /dev/loop1,
where in this example, /dev/loop1 is the cached device
referenced by pv->dev, the command 'pvs /dev/loop0' reports:

Failed to find physical volume "/dev/loop0".

This is because the duplicate PV detection by pvid is
not working because _get_all_devices() is not setting
any dev->pvid for any entries.  This is because the
pvid information has not yet been saved in lvmcache.
This is fixed by calling _get_vgnameids_on_system()
before _get_all_devices(), which has the effect of
caching the necessary pvid information.

With this fix, running pvs /dev/loop0, or pvs /dev/loop1,
produces no error and one line of output for the PV (the
device printed is the one cached in pv->dev, in this
example /dev/loop1.)

Running 'pvs /dev/loop0 /dev/loop1' produces no error
and two lines of output, with each device displayed
on one of the lines.

Running 'pvs -a' shows two PVs, one with loop0 and one
with loop1, and both shown as a member of the same VG.

Running 'pvs' shows only one of the duplicate PVs,
and that shows the device cached in pv->dev (loop1).

The above output is what the duplicate handling code
was previously designed to output in commits:

b64da4d8b521 toollib: search for duplicate PVs only when needed
3a7c47af0e88 toollib: pvs -a should display VG name for each duplicate PV
57d74a45a05e toollib: override the PV device with duplicates
c1f246fedfc3 toollib: handle duplicate pvs in process_in_pv

As a further step after this, we may choose to change
some of those.

For all of these commands, a warning is printed about
the existence of the duplicate PVs:

Found duplicate PV ...: using /dev/loop1 not /dev/loop0

2015-04-20 17:07:58 -05:00

..

.exported_symbols

generate liblvm2cmd exported symbols too

2010-06-25 18:23:10 +00:00

.gitignore

More .gitignore files for an in-source-tree build.

2012-06-08 16:34:43 +01:00

args.h

dumpconfig: add --unconfigured option

2015-04-17 11:35:34 -05:00

cmdnames.h

Fix inconsistent licence notices: executables are GPLv2; libraries LGPLv2.1.

2007-08-20 20:55:30 +00:00

commands.h

dumpconfig: add --unconfigured option

2015-04-17 11:35:34 -05:00

dmsetup.c

cleanup: validate pointers

2014-11-13 17:49:42 +01:00

dumpconfig.c

dumpconfig: add --unconfigured option

2015-04-17 11:35:34 -05:00

errors.h

lvresize: separate validation from action

2013-07-06 03:28:21 +01:00

formats.c

Use __attribute__ consistently throughout.

2010-07-09 15:34:40 +00:00

lvchange.c

toollib: do not spawn polling in lv_change_activate

2015-04-13 20:52:22 +02:00

lvconvert_poll.c

lvconvert: move poll code in before refactoring

2015-04-01 20:40:50 +02:00

lvconvert_poll.h

lvconvert: move poll code in before refactoring

2015-04-01 20:40:50 +02:00

lvconvert.c

lvconvert: move poll code in before refactoring

2015-04-01 20:40:50 +02:00

lvcreate.c

lvcreate: do not silently accept '-m #' with raid4/5/6

2015-04-07 14:32:25 +02:00

lvdisplay.c

tools: allow -S|--select for vgdisplay, lvdisplay and pvdisplay without -C

2015-02-10 16:09:40 +01:00

lvextend.c

Some whitespace tidy-ups.

2008-01-30 14:00:02 +00:00

lvm2cmd-static.c

Fix inconsistent licence notices: executables are GPLv2; libraries LGPLv2.1.

2007-08-20 20:55:30 +00:00

lvm2cmd.c

Use __attribute__ consistently throughout.

2010-07-09 15:34:40 +00:00

lvm2cmd.h

lvresize: separate validation from action

2013-07-06 03:28:21 +01:00

lvm2cmdline.h

Support repetition of --addtag and --deltag arguments.

2010-11-11 17:29:05 +00:00

lvm-static.c

Use __attribute__ consistently throughout.

2010-07-09 15:34:40 +00:00

lvm.c

readline: switch to new-style readline typedef

2014-03-06 17:28:40 +01:00

lvmchange.c

Use __attribute__ consistently throughout.

2010-07-09 15:34:40 +00:00

lvmcmdlib.c

cleanup: drop unneeded included header files

2012-08-23 14:37:20 +02:00

lvmcmdline.c

debug: add new envvar

2015-04-20 12:12:22 +02:00

lvmdiskscan.c

filters: add cmd->full_filter - composite of cmd->filter and cmd->lvmetad_filter

2014-10-02 13:06:46 +02:00

lvreduce.c

Some whitespace tidy-ups.

2008-01-30 14:00:02 +00:00

lvremove.c

cleanup: tools: "or use -S for selection" --> "or use --select for selection"

2015-03-04 14:40:58 +01:00

lvrename.c

cleanup: Use lv_is_ macros.

2014-09-15 21:33:53 +01:00

lvresize.c

cleanup: use logical_volume* directly

2014-11-03 14:19:34 +01:00

lvscan.c

reporting: should not fail with foreign option if lvm1 pvs exist

2015-03-10 13:56:25 -05:00

Makefile.in

lvconvert: move poll code in before refactoring

2015-04-01 20:40:50 +02:00

polldaemon.c

pvmove: don't crash when name is not found

2015-04-03 17:18:11 +02:00

polldaemon.h

cleanup: constify activation usage of lv pointer

2014-09-24 10:54:47 +02:00

pvchange.c

cleanup: tools: "or use -S for selection" --> "or use --select for selection"

2015-03-04 14:40:58 +01:00

pvck.c

pvck: Use non-zero exit status after failure.

2014-11-13 12:26:43 +00:00

pvcreate.c

vgextend: Use process_each_vg.

2015-02-13 14:58:51 +00:00

pvdisplay.c

tools: allow -S|--select for vgdisplay, lvdisplay and pvdisplay without -C

2015-02-10 16:09:40 +01:00

pvmove_poll.c

pvmove: split pvmove_update_metadata function

2015-04-01 20:41:03 +02:00

pvmove_poll.h

pvmove: split pvmove_update_metadata function

2015-04-01 20:41:03 +02:00

pvmove.c

pvmove: fix wrong error path in _update_metadata

2015-04-16 17:54:00 +02:00

pvremove.c

pvremove: Avoid metadata re-reads & related error messages.

2015-01-06 14:27:30 +01:00

pvresize.c

cleanup: drop unused value assign

2015-02-19 14:43:25 +01:00

pvscan.c

reporting: should not fail with foreign option if lvm1 pvs exist

2015-03-10 13:56:25 -05:00

reporter.c

report: check value of args_are_pvs, not the pointer (fix for commit 9ea77b7)

2015-03-02 10:36:32 +01:00

segtypes.c

Use __attribute__ consistently throughout.

2010-07-09 15:34:40 +00:00

stub.h

Use __attribute__ consistently throughout.

2010-07-09 15:34:40 +00:00

tags.c

tools: Add internal tags command.

2014-01-30 13:09:15 +00:00

toollib.c

toollib: fix duplicate handling in process_each_pv

2015-04-20 17:07:58 -05:00

toollib.h

system_id: use for VG ownership

2015-02-13 10:10:27 -06:00

tools.h

systemid: silently ignore foreign vgs unless named

2015-02-25 10:53:52 -06:00

vgcfgbackup.c

cleanup: remove deallocate_handle_root arg from destroy_procesing_handle fnw

2015-02-13 11:27:09 +01:00

vgcfgrestore.c

vgcfgrestore: return invalid cmd line

2014-05-21 23:14:41 +02:00

vgchange.c

vgchange: remove redundant check

2015-04-13 20:52:12 +02:00

vgck.c

toollib: replace void *handle with struct processing_handle for use in processing functions (process_each_*/process_single_* and related)

2015-02-10 16:05:24 +01:00

vgconvert.c

vgconvert: require lvmetad to not be used

2015-03-10 09:31:54 -05:00

vgcreate.c

systemid: Extend --foreign to reporting commands.

2015-02-23 23:41:38 +00:00

vgdisplay.c

tools: allow -S|--select for vgdisplay, lvdisplay and pvdisplay without -C

2015-02-10 16:09:40 +01:00

vgexport.c

cleanup: tools: "or use -S for selection" --> "or use --select for selection"

2015-03-04 14:40:58 +01:00

vgextend.c

vgextend: Use process_each_vg.

2015-02-13 14:58:51 +00:00

vgimport.c

systemid: silently ignore foreign vgs unless named

2015-02-25 10:53:52 -06:00

vgmerge.c

vgsplit: Fix VG component of lvid.

2014-07-03 19:06:04 +01:00

vgmknodes.c

toollib: replace void *handle with struct processing_handle for use in processing functions (process_each_*/process_single_* and related)

2015-02-10 16:05:24 +01:00

vgreduce.c

toollib: replace void *handle with struct processing_handle for use in processing functions (process_each_*/process_single_* and related)

2015-02-10 16:05:24 +01:00

vgremove.c

cleanup: tools: "or use -S for selection" --> "or use --select for selection"

2015-03-04 14:40:58 +01:00

vgrename.c

report: select: refactor: move str_list to libdm

2014-06-17 16:27:20 +02:00

vgscan.c

pvscan, vgscan: include foreign vgs with --cache

2015-02-25 15:46:27 -06:00

vgsplit.c

systemid: Extend --foreign to reporting commands.

2015-02-23 23:41:38 +00:00