mirror of
git://sourceware.org/git/lvm2.git
synced 2025-01-03 05:18:29 +03:00
6a00a7e33d
There are typically 2 functions for the more advanced segment types that deal with parameters in lvcreate.c: _get_*_params() and _check_*_params(). (Not all segment types name their functions according to this scheme.) The former function is responsible for reading parameters before the VG has been read. The latter is for sanity checking and possibly setting parameters after the VG has been read. This patch adds a _check_raid_parameters() function that will determine if the user has specified 'stripe' or 'mirror' parameters. If not, the proper number is computed from the list of PVs the user has supplied or the number that are available in the VG. Now that _check_raid_parameters() is available, we move the check for proper number of stripes from _get_* to _check_*. This gives the user the ability to create RAID LVs as follows: # 5-device RAID5, 4-data, 1-parity (i.e. implicit '-i 4') ~> lvcreate --type raid5 -L 100G -n lv vg /dev/sd[abcde]1 # 5-device RAID6, 3-data, 2-parity (i.e. implicit '-i 3') ~> lvcreate --type raid6 -L 100G -n lv vg /dev/sd[abcde]1 # If 5 PVs in VG, 4-data, 1-parity RAID5 ~> lvcreate --type raid5 -L 100G -n lv vg Considerations: This patch only affects RAID. It might also be useful to apply this to the 'stripe' segment type. LVM RAID may include RAID0 at some point in the future and the implicit stripes would apply there. It would be odd to have RAID0 be able to auto-determine the stripe count while 'stripe' could not. The only draw-back of this patch that I can see is that there might be less error checking. Rather than informing the user that they forgot to supply an argument (e.g. '-i'), the value would be computed and it may differ from what the user actually wanted. I don't see this as a problem, because the user can check the device count after creation and remove the LV if they have made an error. |
||
---|---|---|
.. | ||
.exported_symbols | ||
.gitignore | ||
args.h | ||
cmdnames.h | ||
commands.h | ||
dmsetup.c | ||
dumpconfig.c | ||
errors.h | ||
formats.c | ||
lvchange.c | ||
lvconvert.c | ||
lvcreate.c | ||
lvdisplay.c | ||
lvextend.c | ||
lvm2cmd-static.c | ||
lvm2cmd.c | ||
lvm2cmd.h | ||
lvm2cmdline.h | ||
lvm-static.c | ||
lvm.c | ||
lvmchange.c | ||
lvmcmdlib.c | ||
lvmcmdline.c | ||
lvmdiskscan.c | ||
lvreduce.c | ||
lvremove.c | ||
lvrename.c | ||
lvresize.c | ||
lvscan.c | ||
Makefile.in | ||
polldaemon.c | ||
polldaemon.h | ||
pvchange.c | ||
pvck.c | ||
pvcreate.c | ||
pvdisplay.c | ||
pvmove.c | ||
pvremove.c | ||
pvresize.c | ||
pvscan.c | ||
reporter.c | ||
segtypes.c | ||
stub.h | ||
tags.c | ||
toollib.c | ||
toollib.h | ||
tools.h | ||
vgcfgbackup.c | ||
vgcfgrestore.c | ||
vgchange.c | ||
vgck.c | ||
vgconvert.c | ||
vgcreate.c | ||
vgdisplay.c | ||
vgexport.c | ||
vgextend.c | ||
vgimport.c | ||
vgmerge.c | ||
vgmknodes.c | ||
vgreduce.c | ||
vgremove.c | ||
vgrename.c | ||
vgscan.c | ||
vgsplit.c |