mirror of
git://sourceware.org/git/lvm2.git
synced 2024-12-21 13:34:40 +03:00
2d48ef7f04
A field where it has no meaning to do any type of comparison is the implicit "help" or "?" field. The error given was a bit cryptic before this patch, the FLD_UNCOMPARABLE flag makes it easier to identify this situation anywhere in the code and provide much better error message. This flag can be applied to other fields that may appear in the future - mostly usable for implicit fields as they always have special purpose (so we're not exporting it in libdevmapper for now - usual reporting fields don't need this). Before this patch: $ vgs -S help=1 dm_report_object: no data assigned to field help dm_report_object: no data assigned to field help (...which is true actually, but let's provide something better...) With this patch applied: $vgs -S help=1 Selection field is uncomparable: help. Selection syntax error at 'help=1'. $vgs -S '(name=vg && help=1) || vg_size > 1g' Selection field is uncomparable: help. Selection syntax error at 'help=1) || vg_size > 1g'. |
||
|---|---|---|
| .. | ||
| datastruct | ||
| ioctl | ||
| misc | ||
| mm | ||
| regex | ||
| .exported_symbols | ||
| libdevmapper.h | ||
| libdevmapper.pc.in | ||
| libdm-common.c | ||
| libdm-common.h | ||
| libdm-config.c | ||
| libdm-deptree.c | ||
| libdm-file.c | ||
| libdm-report.c | ||
| libdm-string.c | ||
| Makefile.in | ||