mirror of
git://sourceware.org/git/lvm2.git
synced 2024-12-22 17:35:59 +03:00
da52655315
Prior to this patch, "lvremove -f vgname" would fail if vgname contained one or more snapshot LVs. Now this passes, but has a side-effect. If you issue "lvremove vgname" where vgname contains one or more snaps, you will get an extra "y/n" prompt to remove the same snapshot. Example: $ lvs LV VG Attr LSize Origin Snap% Move Log Copy% Convert lvsnap vgtest swi-a- 16.00M lvtest 0.05 lvtest vgtest owi-a- 64.00M $ lvremove vgtest Do you really want to remove active logical volume "lvsnap"? [y/n]: n Logical volume "lvsnap" not removed Do you really want to remove active logical volume "lvsnap"? [y/n]: n Logical volume "lvsnap" not removed Command failed with status code 5. Fixing this will most likely require modification of the iterator function, process_each_lvs_in_vg() to iterate over snaps in some cases (e.g. lvs, vgdisplay -v) but not in others (lvremove).
39 lines
1.1 KiB
C
39 lines
1.1 KiB
C
/*
|
|
* Copyright (C) 2001-2004 Sistina Software, Inc. All rights reserved.
|
|
* Copyright (C) 2004-2007 Red Hat, Inc. All rights reserved.
|
|
*
|
|
* This file is part of LVM2.
|
|
*
|
|
* This copyrighted material is made available to anyone wishing to use,
|
|
* modify, copy, or redistribute it subject to the terms and conditions
|
|
* of the GNU Lesser General Public License v.2.1.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public License
|
|
* along with this program; if not, write to the Free Software Foundation,
|
|
* Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
*/
|
|
|
|
#include "tools.h"
|
|
|
|
static int lvremove_single(struct cmd_context *cmd, struct logical_volume *lv,
|
|
void *handle __attribute((unused)))
|
|
{
|
|
if (!lv_remove_with_dependencies(cmd, lv, arg_count(cmd, force_ARG)))
|
|
return ECMD_FAILED;
|
|
|
|
return ECMD_PROCESSED;
|
|
}
|
|
|
|
int lvremove(struct cmd_context *cmd, int argc, char **argv)
|
|
{
|
|
if (!argc) {
|
|
log_error("Please enter one or more logical volume paths");
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
|
|
cmd->handles_missing_pvs = 1;
|
|
|
|
return process_each_lv(cmd, argc, argv, LCK_VG_WRITE, NULL,
|
|
&lvremove_single);
|
|
}
|