mirror of
git://sourceware.org/git/lvm2.git
synced 2025-03-11 20:58:50 +03:00
42a871b3df
This addresses a a large amount of Alasdair's review. Subsequent patches will address remaining issues. Addressed: // FIXME Mention that's also required on error. // FIXME Be consistent in terminology. It's called "system_dir" then last sentence says "system directory setting". Is it referring to "system_dir" there or something else? // FIXME Mention it frees all resources and cannot be used subsequently? // FIXME What does "any system configuration" mean? // FIXME Expand on that explanation a bit, now that we know what the other fns look like. // FIXME Not sure about that - it needs to scan sometimes. "will not" or "might not" ? // FIXME: That's a FIXME in the code!!! // FIXME What does "copied" mean in this context??? // FIXME Say what struct the returned struct dm_list is a list of... // FIXME "This API" ? This function creates an object in memory? // FIXME This function commits the Volume Group object referenced by the VG handle to disk? // FIXME Where is "Name" defined? Absolute pathname? Outstanding: // FIXME Version function first? No structs or handles needed for that. // FIXME Sort out this alignment. "Set an" directly below "system_dir" looks awful. Indent differently? More blank lines? // FIXME Check how doxygen processes this. E.g. "return: LVM handle. You must use lvm_error() to check there were no errors and confirm that the handle is valid for passing to other functions." // FIXME Find a better name. lvm_init. // FIXME Consider renaming according to the new name for lvm_create. // FIXME Please can we use dm_malloc throughout?
This tree contains the LVM2 and device-mapper tools and libraries. For more information about LVM2 read the changelog in the WHATS_NEW file. Installation instructions are in INSTALL. There is no warranty - see COPYING and COPYING.LIB. Tarballs are available from: ftp://sources.redhat.com/pub/lvm2/ To access the CVS tree use: cvs -d :pserver:cvs@sources.redhat.com:/cvs/lvm2 login CVS password: cvs cvs -d :pserver:cvs@sources.redhat.com:/cvs/lvm2 co LVM2 Mailing list for general discussion related to LVM2: linux-lvm@redhat.com Subscribe from https://www.redhat.com/mailman/listinfo/linux-lvm Mailing list for LVM2 development, patches and commits: lvm-devel@redhat.com Subscribe from https://www.redhat.com/mailman/listinfo/linux-lvm Mailing list for device-mapper development, including kernel patches and multipath-tools: dm-devel@redhat.com Subscribe from https://www.redhat.com/mailman/listinfo/dm-devel