mirror of
git://sourceware.org/git/lvm2.git
synced 2024-12-21 13:34:40 +03:00
4bc7a86f3a
Coverity flags a user-after-free in _stats_histograms_destroy(): >>> Calling "dm_pool_free" frees pointer "mem->chunk" which has >>> already been freed. This should not be possible since the histograms are destroyed in reverse order of allocation: 203 for (n = _nr_areas_region(region) - 1; n; n--) 204 if (region->counters[n].histogram) 205 dm_pool_free(mem, region->counters[n].histogram); It appears that Coverity is unaware that pool->chunk is updated during the call to dm_pool_free() and valgrind flags no errors in this function when called with multiple allocated histograms. Since there is no actual need to free the histograms individually in this way simplify the code and just free the first allocated object (which will also free all later allocated histograms in a single call). |
||
|---|---|---|
| .. | ||
| datastruct | ||
| ioctl | ||
| misc | ||
| mm | ||
| regex | ||
| .exported_symbols | ||
| .exported_symbols.Base | ||
| .exported_symbols.DM_1_02_97 | ||
| .exported_symbols.DM_1_02_98 | ||
| .exported_symbols.DM_1_02_99 | ||
| .exported_symbols.DM_1_02_100 | ||
| .exported_symbols.DM_1_02_101 | ||
| .exported_symbols.DM_1_02_103 | ||
| .exported_symbols.DM_1_02_104 | ||
| .exported_symbols.DM_1_02_105 | ||
| .exported_symbols.DM_1_02_106 | ||
| .exported_symbols.DM_1_02_107 | ||
| libdevmapper.h | ||
| libdevmapper.pc.in | ||
| libdm-common.c | ||
| libdm-common.h | ||
| libdm-config.c | ||
| libdm-deptree.c | ||
| libdm-file.c | ||
| libdm-report.c | ||
| libdm-stats.c | ||
| libdm-string.c | ||
| libdm-timestamp.c | ||
| Makefile.in | ||