mirror of
git://sourceware.org/git/lvm2.git
synced 2025-01-23 02:05:07 +03:00
6b12930860
For a long time there has been a bug in the activation done by the initial pvscan (which scans all devs to initialize the lvmetad cache.) It was attempting to activate all VGs, even those that were not complete. lvmetad tells pvscan when a VG is complete, and pvscan needs to use this information to decide which VGs to activate. When there are problems that prevent lvmetad from being used (e.g. lvmetad is disabled or not running), pvscan activation cannot use lvmetad to determine when a VG is complete, so it now checks if devices are present for all PVs in the VG before activating. (The recent commit "pvscan: avoid redundant activation" could make this bug more apparent because redundant activations can cover up the effect of activating an incomplete VG and missing some LV activations.)
124 lines
3.5 KiB
C
124 lines
3.5 KiB
C
/*
|
|
* Copyright (C) 2001-2004 Sistina Software, Inc. All rights reserved.
|
|
* Copyright (C) 2004-2006 Red Hat, Inc. All rights reserved.
|
|
*
|
|
* This file is part of LVM2.
|
|
*
|
|
* This copyrighted material is made available to anyone wishing to use,
|
|
* modify, copy, or redistribute it subject to the terms and conditions
|
|
* of the GNU Lesser General Public License v.2.1.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public License
|
|
* along with this program; if not, write to the Free Software Foundation,
|
|
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
|
|
*/
|
|
|
|
#include "tools.h"
|
|
|
|
static int _lvscan_single_lvmetad(struct cmd_context *cmd, struct logical_volume *lv)
|
|
{
|
|
struct pv_list *pvl;
|
|
struct dm_list all_pvs;
|
|
char pvid_s[64] __attribute__((aligned(8)));
|
|
|
|
if (!lvmetad_used())
|
|
return ECMD_PROCESSED;
|
|
|
|
dm_list_init(&all_pvs);
|
|
|
|
if (!get_pv_list_for_lv(lv->vg->vgmem, lv, &all_pvs))
|
|
return ECMD_FAILED;
|
|
|
|
dm_list_iterate_items(pvl, &all_pvs) {
|
|
if (!pvl->pv->dev) {
|
|
if (!id_write_format(&pvl->pv->id, pvid_s, sizeof(pvid_s)))
|
|
stack;
|
|
else
|
|
log_warn("WARNING: Device for PV %s already missing, skipping.",
|
|
pvid_s);
|
|
continue;
|
|
}
|
|
if (!lvmetad_pvscan_single(cmd, pvl->pv->dev, NULL, NULL))
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
return ECMD_PROCESSED;
|
|
}
|
|
|
|
static int _lvscan_single(struct cmd_context *cmd, struct logical_volume *lv,
|
|
struct processing_handle *handle __attribute__((unused)))
|
|
{
|
|
struct lvinfo info;
|
|
int inkernel, snap_active = 1;
|
|
dm_percent_t snap_percent; /* fused, fsize; */
|
|
|
|
const char *active_str, *snapshot_str;
|
|
|
|
if (arg_is_set(cmd, cache_long_ARG))
|
|
return _lvscan_single_lvmetad(cmd, lv);
|
|
|
|
if (!arg_is_set(cmd, all_ARG) && !lv_is_visible(lv))
|
|
return ECMD_PROCESSED;
|
|
|
|
inkernel = lv_info(cmd, lv, 0, &info, 0, 0) && info.exists;
|
|
if (lv_is_cow(lv)) {
|
|
if (inkernel &&
|
|
(snap_active = lv_snapshot_percent(lv, &snap_percent)))
|
|
if (snap_percent == DM_PERCENT_INVALID)
|
|
snap_active = 0;
|
|
}
|
|
|
|
/* FIXME Add -D arg to skip this! */
|
|
if (inkernel && snap_active)
|
|
active_str = "ACTIVE ";
|
|
else
|
|
active_str = "inactive ";
|
|
|
|
if (lv_is_origin(lv))
|
|
snapshot_str = "Original";
|
|
else if (lv_is_cow(lv))
|
|
snapshot_str = "Snapshot";
|
|
else
|
|
snapshot_str = " ";
|
|
|
|
log_print_unless_silent("%s%s '%s%s/%s' [%s] %s", active_str, snapshot_str,
|
|
cmd->dev_dir, lv->vg->name, lv->name,
|
|
display_size(cmd, lv->size),
|
|
get_alloc_string(lv->alloc));
|
|
|
|
return ECMD_PROCESSED;
|
|
}
|
|
|
|
int lvscan(struct cmd_context *cmd, int argc, char **argv)
|
|
{
|
|
const char *reason = NULL;
|
|
|
|
if (argc && !arg_is_set(cmd, cache_long_ARG)) {
|
|
log_error("No additional command line arguments allowed");
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
|
|
if (!lvmetad_used() && arg_is_set(cmd, cache_long_ARG))
|
|
log_verbose("Ignoring lvscan --cache because lvmetad is not in use.");
|
|
|
|
/* Needed because this command has NO_LVMETAD_AUTOSCAN. */
|
|
if (lvmetad_used() && (!lvmetad_token_matches(cmd) || lvmetad_is_disabled(cmd, &reason))) {
|
|
if (lvmetad_used() && !lvmetad_pvscan_all_devs(cmd, 0, NULL)) {
|
|
log_warn("WARNING: Not using lvmetad because cache update failed.");
|
|
lvmetad_make_unused(cmd);
|
|
}
|
|
|
|
if (lvmetad_used() && lvmetad_is_disabled(cmd, &reason)) {
|
|
log_warn("WARNING: Not using lvmetad because %s.", reason);
|
|
lvmetad_make_unused(cmd);
|
|
}
|
|
|
|
/*
|
|
* FIXME: doing lvscan --cache after a full scan is pointless.
|
|
* Should the cache case just exit here?
|
|
*/
|
|
}
|
|
|
|
return process_each_lv(cmd, argc, argv, NULL, NULL, 0, NULL, NULL, &_lvscan_single);
|
|
}
|