1
0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-23 21:35:29 +03:00
lvm2/liblvm
Dave Wysochanski 59ffb010c4 Update lvm.h to address feeback.
This addresses a a large amount of Alasdair's review.  Subsequent patches
will address remaining issues.
Addressed:
// FIXME Mention that's also required on error.
// FIXME Be consistent in terminology.  It's called "system_dir" then last sentence says "system directory setting".  Is it referring to "system_dir" there or something else?
// FIXME Mention it frees all resources and cannot be used subsequently?
// FIXME What does "any system configuration" mean?
// FIXME Expand on that explanation a bit, now that we know what the other fns look like.
// FIXME Not sure about that - it needs to scan sometimes.  "will not" or "might not" ?
// FIXME: That's a FIXME in the code!!!
// FIXME What does "copied" mean in this context???
// FIXME Say what struct the returned struct dm_list is a list of...
// FIXME "This API" ?  This function creates an object in memory?
// FIXME This function commits the Volume Group object referenced by the VG handle to disk?
// FIXME Where is "Name" defined?  Absolute pathname?

Outstanding:
// FIXME Version function first?  No structs or handles needed for that.
// FIXME Sort out this alignment.  "Set an" directly below "system_dir" looks awful.  Indent differently?  More blank lines?
// FIXME Check how doxygen processes this.  E.g. "return: LVM handle.  You must use lvm_error() to check there were no errors and confirm that the handle is valid for passing to other functions."
// FIXME Find a better name.  lvm_init.
// FIXME Consider renaming according to the new name for lvm_create.
// FIXME Please can we use dm_malloc throughout?
2009-07-28 00:36:58 +00:00
..
.exported_symbols Add lvm_config_override - allow caller to override config, similar to --config. 2009-07-27 21:02:17 +00:00
liblvm2app.pc.in check in the correct pkgconfig file 2009-07-23 01:41:53 +00:00
lvm_base.c Update return code for lvm_config_reload. 2009-07-27 21:02:35 +00:00
lvm_lv.c Remove unnecessary \n's from log_error in liblvm. 2009-07-27 21:03:15 +00:00
lvm_pv.c Remove unnecessary \n's from log_error in liblvm. 2009-07-27 21:03:15 +00:00
lvm_vg.c Remove unnecessary \n's from log_error in liblvm. 2009-07-27 21:03:15 +00:00
lvm.h Update lvm.h to address feeback. 2009-07-28 00:36:58 +00:00
Makefile.in Add lvm_{pv|vg|lv}_get_{uuid|name}. 2009-07-23 23:40:05 +00:00