mirror of
git://sourceware.org/git/lvm2.git
synced 2024-10-28 03:27:58 +03:00
5c93cdba2d
The dataalign value must always be aligned according to MDA area. The currect code checks if calculated value collides with MDA area but not if the value is so small that it is located before MDA starts. Unfortunatelly there can be also MDA in the end of the device. The patch adds simple check to avoid this miscalculation. Patch expects that first MDA always starts on <= pagesize boundary (this is true for all allowed label sector parameters).
130 lines
4.2 KiB
Bash
Executable File
130 lines
4.2 KiB
Bash
Executable File
#!/bin/sh
|
|
# Copyright (C) 2008 Red Hat, Inc. All rights reserved.
|
|
#
|
|
# This copyrighted material is made available to anyone wishing to use,
|
|
# modify, copy, or redistribute it subject to the terms and conditions
|
|
# of the GNU General Public License v.2.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program; if not, write to the Free Software Foundation,
|
|
# Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
|
|
test_description='Test pvcreate option values'
|
|
|
|
. ./test-utils.sh
|
|
|
|
aux prepare_devs 4
|
|
|
|
#COMM 'pvcreate rejects negative setphysicalvolumesize'
|
|
not pvcreate --setphysicalvolumesize -1024 $dev1
|
|
|
|
#COMM 'pvcreate rejects negative metadatasize'
|
|
not pvcreate --metadatasize -1024 $dev1
|
|
|
|
# x. metadatasize 0, defaults to 255
|
|
# FIXME: unable to check default value, not in reporting cmds
|
|
# should default to 255 according to code
|
|
# check_pv_field_ pv_mda_size 255
|
|
#COMM 'pvcreate accepts metadatasize 0'
|
|
pvcreate --metadatasize 0 $dev1
|
|
pvremove $dev1
|
|
|
|
# x. metadatasize too large
|
|
# For some reason we allow this, even though there's no room for data?
|
|
##COMM 'pvcreate rejects metadatasize too large'
|
|
#not pvcreate --metadatasize 100000000000000 $dev1
|
|
|
|
#COMM 'pvcreate rejects metadatacopies < 0'
|
|
not pvcreate --metadatacopies -1 $dev1
|
|
|
|
#COMM 'pvcreate accepts metadatacopies = 0, 1, 2'
|
|
pvcreate --metadatacopies 0 $dev1
|
|
pvcreate --metadatacopies 1 $dev2
|
|
pvcreate --metadatacopies 2 $dev3
|
|
check_pv_field_ $dev1 pv_mda_count 0
|
|
check_pv_field_ $dev2 pv_mda_count 1
|
|
check_pv_field_ $dev3 pv_mda_count 2
|
|
pvremove $dev1
|
|
pvremove $dev2
|
|
pvremove $dev3
|
|
|
|
#COMM 'pvcreate rejects metadatacopies > 2'
|
|
not pvcreate --metadatacopies 3 $dev1
|
|
|
|
#COMM 'pvcreate rejects invalid device'
|
|
not pvcreate $dev1bogus
|
|
|
|
#COMM 'pvcreate rejects labelsector < 0'
|
|
not pvcreate --labelsector -1 $dev1
|
|
|
|
#COMM 'pvcreate rejects labelsector > 1000000000000'
|
|
not pvcreate --labelsector 1000000000000 $dev1
|
|
|
|
# other possibilites based on code inspection (not sure how hard)
|
|
# x. device too small (min of 512 * 1024 KB)
|
|
# x. device filtered out
|
|
# x. unable to open /dev/urandom RDONLY
|
|
# x. device too large (pe_count > UINT32_MAX)
|
|
# x. device read-only
|
|
# x. unable to open device readonly
|
|
# x. BLKGETSIZE64 fails
|
|
# x. set size to value inconsistent with device / PE size
|
|
|
|
#COMM 'pvcreate basic dataalignment sanity checks'
|
|
not pvcreate --dataalignment -1 $dev1
|
|
not pvcreate -M 1 --dataalignment 1 $dev1
|
|
not pvcreate --dataalignment 1E $dev1
|
|
|
|
#COMM 'pvcreate always rounded up to page size for start of device'
|
|
#pvcreate --metadatacopies 0 --dataalignment 1 $dev1
|
|
# amuse shell experts
|
|
#check_pv_field_ $dev1 pe_start $(($(getconf PAGESIZE)/1024))".00K"
|
|
|
|
#COMM 'pvcreate sets data offset directly'
|
|
pvcreate --dataalignment 512k $dev1
|
|
check_pv_field_ $dev1 pe_start 512.00K
|
|
|
|
#COMM 'vgcreate/vgremove do not modify data offset of existing PV'
|
|
vgcreate $vg $dev1 --config 'devices { data_alignment = 1024 }'
|
|
check_pv_field_ $dev1 pe_start 512.00K
|
|
vgremove $vg --config 'devices { data_alignment = 1024 }'
|
|
check_pv_field_ $dev1 pe_start 512.00K
|
|
|
|
#COMM 'pvcreate sets data offset next to mda area'
|
|
pvcreate --metadatasize 100k --dataalignment 100k $dev1
|
|
check_pv_field_ $dev1 pe_start 200.00K
|
|
|
|
pvcreate --metadatasize 128k --dataalignment 3.5k $dev1
|
|
check_pv_field_ $dev1 pe_start 133.00K
|
|
|
|
pvcreate --metadatasize 128k --metadatacopies 2 --dataalignment 3.5k $dev1
|
|
check_pv_field_ $dev1 pe_start 133.00K
|
|
|
|
#COMM 'pv with LVM1 compatible data alignment can be convereted'
|
|
#compatible == LVM1_PE_ALIGN == 64k
|
|
pvcreate --dataalignment 256k $dev1
|
|
vgcreate -s 1M $vg $dev1
|
|
vgconvert -M1 $vg
|
|
vgconvert -M2 $vg
|
|
check_pv_field_ $dev1 pe_start 256.00K
|
|
vgremove $vg
|
|
|
|
#COMM 'pv with LVM1 incompatible data alignment cannot be convereted'
|
|
pvcreate --dataalignment 10k $dev1
|
|
vgcreate -s 1M $vg $dev1
|
|
not vgconvert -M1 $vg
|
|
vgremove $vg
|
|
|
|
#COMM 'vgcfgrestore allows pe_start=0'
|
|
#basically it produces nonsense, but it tests vgcfgrestore,
|
|
#not that final cfg is usable...
|
|
pvcreate --metadatacopies 0 $dev1
|
|
pvcreate $dev2
|
|
vgcreate $vg $dev1 $dev2
|
|
vgcfgbackup -f "$(pwd)/backup.$$" $vg
|
|
sed 's/pe_start = [0-9]*/pe_start = 0/' "$(pwd)/backup.$$" > "$(pwd)/backup.$$1"
|
|
vgcfgrestore -f "$(pwd)/backup.$$1" $vg
|
|
check_pv_field_ $dev1 pe_start 0
|
|
check_pv_field_ $dev2 pe_start 0
|
|
vgremove $vg
|