mirror of
git://sourceware.org/git/lvm2.git
synced 2024-12-22 17:35:59 +03:00
5042463c50
As pmspare is an invisible LV it's not getting automatically removed since vgremove removes only visible LVs and it depending LVs. If there was no other thin/cache pool volume, such pmspare stayed undeleted and caused command failure. So handle explicitelly such forgotten pmspare and remove it.
112 lines
3.2 KiB
C
112 lines
3.2 KiB
C
/*
|
|
* Copyright (C) 2001-2004 Sistina Software, Inc. All rights reserved.
|
|
* Copyright (C) 2004-2014 Red Hat, Inc. All rights reserved.
|
|
*
|
|
* This file is part of LVM2.
|
|
*
|
|
* This copyrighted material is made available to anyone wishing to use,
|
|
* modify, copy, or redistribute it subject to the terms and conditions
|
|
* of the GNU Lesser General Public License v.2.1.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public License
|
|
* along with this program; if not, write to the Free Software Foundation,
|
|
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
|
|
*/
|
|
|
|
#include "tools.h"
|
|
|
|
static int _vgremove_single(struct cmd_context *cmd, const char *vg_name,
|
|
struct volume_group *vg,
|
|
struct processing_handle *handle __attribute__((unused)))
|
|
{
|
|
/*
|
|
* Though vgremove operates per VG by definition, internally, it
|
|
* actually means iterating over each LV it contains to do the remove.
|
|
*
|
|
* Use processing handle with void_handle.internal_report_for_select=0
|
|
* for the process_each_lv_in_vg that is called later in this fn.
|
|
* We need to disable internal selection for process_each_lv_in_vg
|
|
* here as selection is already done by process_each_vg which calls
|
|
* vgremove_single. Otherwise selection would be done per-LV and
|
|
* not per-VG as we intend!
|
|
*/
|
|
struct processing_handle void_handle = {0};
|
|
|
|
/*
|
|
* Single force is equivalent to sinle --yes
|
|
* Even multiple --yes are equivalent to single --force
|
|
* When we require -ff it cannot be replaces with -f -y
|
|
*/
|
|
force_t force = (force_t) arg_count(cmd, force_ARG)
|
|
? : (arg_is_set(cmd, yes_ARG) ? DONT_PROMPT : PROMPT);
|
|
unsigned lv_count, missing;
|
|
int ret;
|
|
|
|
lv_count = vg_visible_lvs(vg);
|
|
|
|
if (lv_count) {
|
|
if (force == PROMPT) {
|
|
if ((missing = vg_missing_pv_count(vg)))
|
|
log_warn("WARNING: %d physical volumes are currently missing "
|
|
"from the system.", missing);
|
|
if (yes_no_prompt("Do you really want to remove volume "
|
|
"group \"%s\" containing %u "
|
|
"logical volumes? [y/n]: ",
|
|
vg_name, lv_count) == 'n') {
|
|
log_error("Volume group \"%s\" not removed", vg_name);
|
|
return ECMD_FAILED;
|
|
}
|
|
}
|
|
|
|
if ((ret = process_each_lv_in_vg(cmd, vg, NULL, NULL, 1, &void_handle,
|
|
NULL, (process_single_lv_fn_t)lvremove_single)) != ECMD_PROCESSED) {
|
|
stack;
|
|
return ret;
|
|
}
|
|
}
|
|
|
|
if (vg->pool_metadata_spare_lv &&
|
|
!lvremove_single(cmd, vg->pool_metadata_spare_lv, &void_handle))
|
|
return_ECMD_FAILED;
|
|
|
|
if (!lockd_free_vg_before(cmd, vg, 0))
|
|
return_ECMD_FAILED;
|
|
|
|
if (!force && !vg_remove_check(vg))
|
|
return_ECMD_FAILED;
|
|
|
|
vg_remove_pvs(vg);
|
|
|
|
if (!vg_remove(vg))
|
|
return_ECMD_FAILED;
|
|
|
|
lockd_free_vg_final(cmd, vg);
|
|
|
|
return ECMD_PROCESSED;
|
|
}
|
|
|
|
int vgremove(struct cmd_context *cmd, int argc, char **argv)
|
|
{
|
|
int ret;
|
|
|
|
if (!argc && !arg_is_set(cmd, select_ARG)) {
|
|
log_error("Please enter one or more volume group paths "
|
|
"or use --select for selection.");
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
|
|
if (!lock_global(cmd, "ex"))
|
|
return_ECMD_FAILED;
|
|
|
|
clear_hint_file(cmd);
|
|
|
|
cmd->wipe_outdated_pvs = 1;
|
|
|
|
cmd->handles_missing_pvs = 1;
|
|
ret = process_each_vg(cmd, argc, argv, NULL, NULL,
|
|
READ_FOR_UPDATE, 0,
|
|
NULL, &_vgremove_single);
|
|
|
|
return ret;
|
|
}
|