mirror of
git://sourceware.org/git/lvm2.git
synced 2025-01-03 05:18:29 +03:00
2282f53ac7
Add new logic to identify each unique operation and route it to the correct function to perform it. The functions that perform the conversions remain unchanged. This new code checks every allowed combination of LV type and requested operation, and for each valid combination calls the function that performs that conversion. The first stage of option validation which checks for incompatible combinations of command line options, is done done before process_each is called. This is unchanged. (This new code will allow that first stage validation to be simplified in a future commit.) The second stage of checking options against the specific LV type is done by this new code. For each valid combination of operation + LV type, the new code calls an existing function that implements it. With this in place, the ad hoc checks for valid combinations of LV types and operations can be removed from the existing code in a future commit. (The #if 0 is used to keep the patch clean, and the disabled code will be removed by a following patch.)
170 lines
5.7 KiB
Bash
170 lines
5.7 KiB
Bash
#!/bin/sh
|
|
# Copyright (C) 2014-2016 Red Hat, Inc. All rights reserved.
|
|
#
|
|
# This copyrighted material is made available to anyone wishing to use,
|
|
# modify, copy, or redistribute it subject to the terms and conditions
|
|
# of the GNU General Public License v.2.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program; if not, write to the Free Software Foundation,
|
|
# Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
|
|
|
|
# Exercise conversion of cache and cache pool
|
|
|
|
SKIP_WITH_LVMLOCKD=1
|
|
SKIP_WITH_LVMPOLLD=1
|
|
|
|
. lib/inittest
|
|
|
|
aux have_cache 1 3 0 || skip
|
|
|
|
aux prepare_vg 5 80
|
|
|
|
lvcreate --type cache-pool -an -v -L 2 -n cpool $vg
|
|
lvcreate -H -L 4 -n corigin --cachepool $vg/cpool
|
|
|
|
fail lvcreate -s -L2 $vg/corigin
|
|
fail lvcreate -s -L2 $vg/cpool
|
|
fail lvcreate -s -L2 $vg/cpool_cdata
|
|
fail lvcreate -s -L2 $vg/cpool_cmeta
|
|
|
|
###########################
|
|
# Check regular converion #
|
|
###########################
|
|
# lvcreate origin, lvcreate cache-pool, and lvconvert to cache
|
|
lvcreate -an -Zn -L 2 -n $lv1 $vg
|
|
lvcreate -L 8 -n $lv2 $vg
|
|
lvcreate -an -Zn -L 8 -n $lv3 $vg
|
|
lvcreate -an -Zn -L 8 -n $lv4 $vg
|
|
lvcreate -an -Zn -L 16 -n $lv5 $vg
|
|
|
|
# check validation of cachemode arg works
|
|
invalid lvconvert --yes --type cache-pool --cachemode writethroughX --cachepool $vg/$lv1
|
|
|
|
# by default no cache settings are attached to converted cache-pool
|
|
lvconvert --yes --type cache-pool --chunksize 256 $vg/$lv1
|
|
check inactive $vg ${lv1}_cdata
|
|
check lv_field $vg/$lv1 cache_mode ""
|
|
check lv_field $vg/$lv1 cache_policy ""
|
|
check lv_field $vg/$lv1 cache_settings ""
|
|
check lv_field $vg/$lv1 chunk_size "256.00k"
|
|
|
|
# but allow to set them when specified explicitely on command line
|
|
lvconvert --yes --type cache-pool --cachemode writeback --cachepolicy mq \
|
|
--cachesettings sequential_threshold=1234 --cachesettings random_threshold=56 \
|
|
--cachepool $vg/$lv2
|
|
check inactive $vg ${lv2}_cdata
|
|
check lv_field $vg/$lv2 cache_mode "writeback"
|
|
check lv_field $vg/$lv2 cache_policy "mq"
|
|
check lv_field $vg/$lv2 cache_settings "random_threshold=56,sequential_threshold=1234"
|
|
|
|
# Check swap of cache pool metadata
|
|
lvconvert --yes --type cache-pool --poolmetadata $lv4 $vg/$lv3
|
|
UUID=$(get lv_field $vg/$lv5 uuid)
|
|
lvconvert --yes --cachepool $vg/$lv3 --poolmetadata $lv5
|
|
check lv_field $vg/${lv3}_cmeta uuid "$UUID"
|
|
|
|
|
|
#fail lvconvert --cachepool $vg/$lv1 --poolmetadata $vg/$lv2
|
|
#lvconvert --yes --type cache-pool --poolmetadata $vg/$lv2 $vg/$lv1
|
|
#lvconvert --yes --poolmetadata $vg/$lv2 --cachepool $vg/$lv1
|
|
|
|
lvremove -ff $vg
|
|
|
|
lvcreate -L 2 -n $lv1 $vg
|
|
lvcreate --type cache-pool -l 1 -n ${lv1}_cachepool $vg
|
|
lvconvert --cache --cachepool $vg/${lv1}_cachepool --cachemode writeback $vg/$lv1
|
|
check lv_field $vg/$lv1 cache_mode "writeback"
|
|
dmsetup table ${vg}-$lv1 | grep cache # ensure it is loaded in kernel
|
|
|
|
#lvconvert --cachepool $vg/${lv1}_cachepool $vg/$lv1
|
|
#lvconvert --cachepool $vg/${lv1}_cachepool --poolmetadatasize 20 "$dev3"
|
|
|
|
|
|
fail lvconvert --type cache --cachepool $vg/${lv1}_cachepool $vg/$lv1
|
|
|
|
# Test --splitcache leaves both cache origin and cache pool
|
|
lvconvert --splitcache $vg/$lv1
|
|
check lv_exists $vg $lv1 ${lv1}_cachepool
|
|
lvremove -f $vg
|
|
|
|
|
|
lvcreate -n corigin -l 10 $vg
|
|
lvcreate -n pool -l 10 $vg
|
|
lvs -a -o +devices
|
|
fail lvconvert --type cache --cachepool $vg/pool $vg/corigin
|
|
lvconvert --yes --cache --cachepool $vg/pool $vg/corigin
|
|
lvremove -ff $vg
|
|
|
|
|
|
#######################
|
|
# Invalid conversions #
|
|
#######################
|
|
lvcreate -an -Zn -L 2 -n $lv1 $vg
|
|
lvcreate -an -Zn -L 8 -n $lv2 $vg
|
|
lvcreate -an -Zn -L 8 -n $lv3 $vg
|
|
lvcreate -an -Zn -L 8 -n $lv4 $vg
|
|
|
|
# Undefined cachepool
|
|
invalid lvconvert --type cache --poolmetadata $vg/$lv2 $vg/$lv1
|
|
|
|
# Cannot mix with thins
|
|
invalid lvconvert --type cache --poolmetadata $vg/$lv2 --thinpool $vg/$lv1
|
|
invalid lvconvert --type cache --thin --poolmetadata $vg/$lv2 $vg/$lv1
|
|
|
|
# Undefined cached volume
|
|
invalid lvconvert --type cache --cachepool $vg/$lv1
|
|
invalid lvconvert --cache --cachepool $vg/$lv1
|
|
|
|
# Single vg is required
|
|
invalid lvconvert --type cache --cachepool $vg/$lv1 --poolmetadata $vg1/$lv2 $vg/$lv3
|
|
invalid lvconvert --type cache --cachepool $vg/$lv1 --poolmetadata $lv2 $vg1/$lv3
|
|
invalid lvconvert --type cache --cachepool $vg1/$lv1 --poolmetadata $vg2/$lv2 $vg/$lv3
|
|
invalid lvconvert --type cache-pool --poolmetadata $vg2/$lv2 $vg1/$lv1
|
|
|
|
invalid lvconvert --cachepool $vg1/$lv1 --poolmetadata $vg2/$lv2
|
|
|
|
# Invalid syntax, vg is unknown
|
|
invalid lvconvert --yes --cachepool $lv3 --poolmetadata $lv4
|
|
|
|
# Invalid chunk size is <32KiB >1GiB
|
|
invalid lvconvert --type cache-pool --chunksize 16 --poolmetadata $lv2 $vg/$lv1
|
|
invalid lvconvert --type cache-pool --chunksize 2G --poolmetadata $lv2 $vg/$lv1
|
|
|
|
# Invalid chunk size is bigger then data size, needs to open VG
|
|
fail lvconvert --yes --type cache-pool --chunksize 16M --poolmetadata $lv2 $vg/$lv1
|
|
|
|
lvremove -f $vg
|
|
|
|
########################
|
|
# Repair of cache pool #
|
|
########################
|
|
lvcreate --type cache-pool -an -v -L 2 -n cpool $vg
|
|
lvcreate -H -L 4 -n corigin --cachepool $vg/cpool
|
|
|
|
# unsupported yet
|
|
fail lvconvert --repair $vg/cpool 2>&1 | tee out
|
|
grep "Cannot convert internal LV" out
|
|
|
|
lvremove -f $vg
|
|
|
|
##########################
|
|
# Prohibited conversions #
|
|
##########################
|
|
lvcreate --type cache-pool -L10 $vg/$lv1
|
|
lvcreate --cache -L20 $vg/$lv1
|
|
lvcreate -L10 -n $lv2 $vg
|
|
|
|
fail lvconvert --yes --type cache $vg/$lv2 --cachepool $vg/$lv1
|
|
fail lvconvert --yes --type cache $vg/$lv1 --cachepool $vg/$lv2
|
|
fail lvconvert --yes --type cache-pool $vg/$lv1
|
|
fail lvconvert --yes --type mirror -m1 $vg/$lv1
|
|
not aux have_raid 1 0 0 || fail lvconvert --yes --type raid1 -m1 $vg/$lv1
|
|
fail lvconvert --yes --type snapshot $vg/$lv1 $vg/$lv2
|
|
fail lvconvert --yes --type snapshot $vg/$lv2 $vg/$lv1
|
|
not aux have_thin 1 0 0 || fail lvconvert --yes -T --thinpool $vg/$lv2 $vg/$lv1
|
|
|
|
lvremove -f $vg
|
|
|
|
vgremove -f $vg
|