mirror of
git://sourceware.org/git/lvm2.git
synced 2024-12-22 17:35:59 +03:00
2691f1d764
Creation, deletion, [de]activation, repair, conversion, scrubbing and changing operations are all now available for RAID LVs in a cluster - provided that they are activated exclusively. The code has been changed to ensure that no LV or sub-LV activation is attempted cluster-wide. This includes the often overlooked operations of activating metadata areas for the brief time it takes to clear them. Additionally, some 'resume_lv' operations were replaced with 'activate_lv_excl_local' when sub-LVs were promoted to top-level LVs for removal, clearing or extraction. This was necessary because it forces the appropriate renaming actions the occur via resume in the single-machine case, but won't happen in a cluster due to the necessity of acquiring a lock first. The *raid* tests have been updated to allow testing in a cluster. For the most part, this meant creating devices with '-aey' if they were to be converted to RAID. (RAID requires the converting LV to be EX because it is a condition of activation for the RAID LV in a cluster.)
1253 lines
32 KiB
C
1253 lines
32 KiB
C
/*
|
|
* Copyright (C) 2001-2004 Sistina Software, Inc. All rights reserved.
|
|
* Copyright (C) 2004-2011 Red Hat, Inc. All rights reserved.
|
|
*
|
|
* This file is part of LVM2.
|
|
*
|
|
* This copyrighted material is made available to anyone wishing to use,
|
|
* modify, copy, or redistribute it subject to the terms and conditions
|
|
* of the GNU Lesser General Public License v.2.1.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public License
|
|
* along with this program; if not, write to the Free Software Foundation,
|
|
* Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
*/
|
|
|
|
#include "tools.h"
|
|
|
|
static int lvchange_permission(struct cmd_context *cmd,
|
|
struct logical_volume *lv)
|
|
{
|
|
uint32_t lv_access;
|
|
struct lvinfo info;
|
|
int r = 0;
|
|
|
|
lv_access = arg_uint_value(cmd, permission_ARG, 0);
|
|
|
|
if ((lv_access & LVM_WRITE) && (lv->status & LVM_WRITE)) {
|
|
log_error("Logical volume \"%s\" is already writable",
|
|
lv->name);
|
|
return 0;
|
|
}
|
|
|
|
if (!(lv_access & LVM_WRITE) && !(lv->status & LVM_WRITE)) {
|
|
log_error("Logical volume \"%s\" is already read only",
|
|
lv->name);
|
|
return 0;
|
|
}
|
|
|
|
if (lv_is_external_origin(lv)) {
|
|
log_error("Cannot change permissions of external origin "
|
|
"\"%s\".", lv->name);
|
|
return 0;
|
|
}
|
|
|
|
if ((lv->status & MIRRORED) && (vg_is_clustered(lv->vg)) &&
|
|
lv_info(cmd, lv, 0, &info, 0, 0) && info.exists) {
|
|
log_error("Cannot change permissions of mirror \"%s\" "
|
|
"while active.", lv->name);
|
|
return 0;
|
|
}
|
|
|
|
/* Not allowed to change permissions on RAID sub-LVs directly */
|
|
if ((lv->status & RAID_META) || (lv->status & RAID_IMAGE)) {
|
|
log_error("Cannot change permissions of RAID %s \"%s\"",
|
|
(lv->status & RAID_IMAGE) ? "image" :
|
|
"metadata area", lv->name);
|
|
return 0;
|
|
}
|
|
|
|
if (!(lv_access & LVM_WRITE) && lv_is_thin_pool(lv)) {
|
|
log_error("Change permissions of thin pool \"%s\" not "
|
|
"yet supported.", lv->name);
|
|
return 0;
|
|
}
|
|
|
|
if (lv_access & LVM_WRITE) {
|
|
lv->status |= LVM_WRITE;
|
|
log_verbose("Setting logical volume \"%s\" read/write",
|
|
lv->name);
|
|
} else {
|
|
lv->status &= ~LVM_WRITE;
|
|
log_verbose("Setting logical volume \"%s\" read-only",
|
|
lv->name);
|
|
}
|
|
|
|
log_very_verbose("Updating logical volume \"%s\" on disk(s)", lv->name);
|
|
if (!vg_write(lv->vg))
|
|
return_0;
|
|
|
|
if (!suspend_lv(cmd, lv)) {
|
|
log_error("Failed to lock %s", lv->name);
|
|
vg_revert(lv->vg);
|
|
goto out;
|
|
}
|
|
|
|
if (!vg_commit(lv->vg)) {
|
|
if (!resume_lv(cmd, lv))
|
|
stack;
|
|
goto_out;
|
|
}
|
|
|
|
log_very_verbose("Updating permissions for \"%s\" in kernel", lv->name);
|
|
if (!resume_lv(cmd, lv)) {
|
|
log_error("Problem reactivating %s", lv->name);
|
|
goto out;
|
|
}
|
|
|
|
r = 1;
|
|
out:
|
|
backup(lv->vg);
|
|
return r;
|
|
}
|
|
|
|
static int lvchange_pool_update(struct cmd_context *cmd,
|
|
struct logical_volume *lv)
|
|
{
|
|
int r = 0;
|
|
int update = 0;
|
|
unsigned val;
|
|
thin_discards_t discards;
|
|
|
|
if (!lv_is_thin_pool(lv)) {
|
|
log_error("Logical volume \"%s\" is not a thin pool.", lv->name);
|
|
return 0;
|
|
}
|
|
|
|
if (arg_count(cmd, discards_ARG)) {
|
|
discards = (thin_discards_t) arg_uint_value(cmd, discards_ARG, THIN_DISCARDS_IGNORE);
|
|
if (discards != first_seg(lv)->discards) {
|
|
if (((discards == THIN_DISCARDS_IGNORE) ||
|
|
(first_seg(lv)->discards == THIN_DISCARDS_IGNORE)) &&
|
|
pool_is_active(lv))
|
|
log_error("Cannot change discards state for active "
|
|
"pool volume \"%s\".", lv->name);
|
|
else {
|
|
first_seg(lv)->discards = discards;
|
|
update++;
|
|
}
|
|
} else
|
|
log_error("Logical volume \"%s\" already uses --discards %s.",
|
|
lv->name, get_pool_discards_name(discards));
|
|
}
|
|
|
|
if (arg_count(cmd, zero_ARG)) {
|
|
val = arg_uint_value(cmd, zero_ARG, 1);
|
|
if (val != first_seg(lv)->zero_new_blocks) {
|
|
first_seg(lv)->zero_new_blocks = val;
|
|
update++;
|
|
} else
|
|
log_error("Logical volume \"%s\" already %szero new blocks.",
|
|
lv->name, val ? "" : "does not ");
|
|
}
|
|
|
|
if (!update)
|
|
return 0;
|
|
|
|
log_very_verbose("Updating logical volume \"%s\" on disk(s).", lv->name);
|
|
if (!vg_write(lv->vg))
|
|
return_0;
|
|
|
|
if (!suspend_lv_origin(cmd, lv)) {
|
|
log_error("Failed to update active %s/%s (deactivation is needed).",
|
|
lv->vg->name, lv->name);
|
|
vg_revert(lv->vg);
|
|
goto out;
|
|
}
|
|
|
|
if (!vg_commit(lv->vg)) {
|
|
if (!resume_lv_origin(cmd, lv))
|
|
stack;
|
|
goto_out;
|
|
}
|
|
|
|
if (!resume_lv_origin(cmd, lv)) {
|
|
log_error("Problem reactivating %s.", lv->name);
|
|
goto out;
|
|
}
|
|
|
|
r = 1;
|
|
out:
|
|
backup(lv->vg);
|
|
return r;
|
|
}
|
|
|
|
static int lvchange_monitoring(struct cmd_context *cmd,
|
|
struct logical_volume *lv)
|
|
{
|
|
struct lvinfo info;
|
|
|
|
if (!lv_info(cmd, lv, lv_is_thin_pool(lv) ? 1 : 0,
|
|
&info, 0, 0) || !info.exists) {
|
|
log_error("Logical volume, %s, is not active", lv->name);
|
|
return 0;
|
|
}
|
|
|
|
/* do not monitor pvmove lv's */
|
|
if (lv->status & PVMOVE)
|
|
return 1;
|
|
|
|
if ((dmeventd_monitor_mode() != DMEVENTD_MONITOR_IGNORE) &&
|
|
!monitor_dev_for_events(cmd, lv, 0, dmeventd_monitor_mode()))
|
|
return_0;
|
|
|
|
return 1;
|
|
}
|
|
|
|
static int lvchange_background_polling(struct cmd_context *cmd,
|
|
struct logical_volume *lv)
|
|
{
|
|
struct lvinfo info;
|
|
|
|
if (!lv_info(cmd, lv, 0, &info, 0, 0) || !info.exists) {
|
|
log_error("Logical volume, %s, is not active", lv->name);
|
|
return 0;
|
|
}
|
|
|
|
if (background_polling())
|
|
lv_spawn_background_polling(cmd, lv);
|
|
|
|
return 1;
|
|
}
|
|
|
|
static int _lvchange_activate(struct cmd_context *cmd, struct logical_volume *lv)
|
|
{
|
|
activation_change_t activate;
|
|
|
|
activate = (activation_change_t) arg_uint_value(cmd, activate_ARG, CHANGE_AY);
|
|
|
|
if (lv_activation_skip(lv, activate, arg_count(cmd, ignoreactivationskip_ARG), 0)) {
|
|
log_verbose("ACTIVATON_SKIP flag set for LV %s/%s, skipping activation.",
|
|
lv->vg->name, lv->name);
|
|
return 1;
|
|
}
|
|
|
|
if (lv_is_cow(lv) && !lv_is_virtual_origin(origin_from_cow(lv)))
|
|
lv = origin_from_cow(lv);
|
|
|
|
if ((activate == CHANGE_AAY) &&
|
|
!lv_passes_auto_activation_filter(cmd, lv))
|
|
return 1;
|
|
|
|
if (!lv_change_activate(cmd, lv, activate))
|
|
return_0;
|
|
|
|
return 1;
|
|
}
|
|
|
|
static int detach_metadata_devices(struct lv_segment *seg, struct dm_list *list)
|
|
{
|
|
uint32_t s;
|
|
uint32_t num_meta_lvs;
|
|
struct lv_list *lvl;
|
|
|
|
num_meta_lvs = seg_is_raid(seg) ? seg->area_count : !!seg->log_lv;
|
|
|
|
if (!num_meta_lvs)
|
|
return_0;
|
|
|
|
if (!(lvl = dm_pool_alloc(seg->lv->vg->vgmem, sizeof(*lvl) * num_meta_lvs)))
|
|
return_0;
|
|
|
|
if (seg_is_raid(seg)) {
|
|
for (s = 0; s < seg->area_count; s++) {
|
|
if (!seg_metalv(seg, s))
|
|
return_0; /* Trap this future possibility */
|
|
|
|
lvl[s].lv = seg_metalv(seg, s);
|
|
lv_set_visible(lvl[s].lv);
|
|
|
|
dm_list_add(list, &lvl[s].list);
|
|
}
|
|
return 1;
|
|
}
|
|
|
|
lvl[0].lv = detach_mirror_log(seg);
|
|
dm_list_add(list, &lvl[0].list);
|
|
|
|
return 1;
|
|
}
|
|
|
|
static int attach_metadata_devices(struct lv_segment *seg, struct dm_list *list)
|
|
{
|
|
struct lv_list *lvl;
|
|
|
|
if (seg_is_raid(seg)) {
|
|
dm_list_iterate_items(lvl, list)
|
|
lv_set_hidden(lvl->lv);
|
|
return 1;
|
|
}
|
|
|
|
dm_list_iterate_items(lvl, list)
|
|
break; /* get first item */
|
|
|
|
if (!attach_mirror_log(seg, lvl->lv))
|
|
return_0;
|
|
|
|
return 1;
|
|
}
|
|
|
|
/*
|
|
* lvchange_refresh
|
|
* @cmd
|
|
* @lv
|
|
*
|
|
* Suspend and resume a logical volume.
|
|
*/
|
|
static int lvchange_refresh(struct cmd_context *cmd, struct logical_volume *lv)
|
|
{
|
|
log_verbose("Refreshing logical volume \"%s\" (if active)", lv->name);
|
|
|
|
return lv_refresh(cmd, lv);
|
|
}
|
|
|
|
static int _reactivate_lv(struct logical_volume *lv,
|
|
int active, int exclusive)
|
|
{
|
|
struct cmd_context *cmd = lv->vg->cmd;
|
|
|
|
if (!active)
|
|
return 1;
|
|
|
|
if (exclusive)
|
|
return activate_lv_excl_local(cmd, lv);
|
|
|
|
return activate_lv(cmd, lv);
|
|
}
|
|
|
|
/*
|
|
* lvchange_resync
|
|
* @cmd
|
|
* @lv
|
|
*
|
|
* Force a mirror or RAID array to undergo a complete initializing resync.
|
|
*/
|
|
static int lvchange_resync(struct cmd_context *cmd, struct logical_volume *lv)
|
|
{
|
|
int active = 0;
|
|
int exclusive = 0;
|
|
int monitored;
|
|
struct lvinfo info;
|
|
struct lv_segment *seg = first_seg(lv);
|
|
struct dm_list device_list;
|
|
struct lv_list *lvl;
|
|
|
|
dm_list_init(&device_list);
|
|
|
|
if (!(lv->status & MIRRORED) && !seg_is_raid(seg)) {
|
|
log_error("Unable to resync %s. It is not RAID or mirrored.",
|
|
lv->name);
|
|
return 0;
|
|
}
|
|
|
|
if (lv->status & PVMOVE) {
|
|
log_error("Unable to resync pvmove volume %s", lv->name);
|
|
return 0;
|
|
}
|
|
|
|
if (lv->status & LOCKED) {
|
|
log_error("Unable to resync locked volume %s", lv->name);
|
|
return 0;
|
|
}
|
|
|
|
if (lv_info(cmd, lv, 0, &info, 1, 0)) {
|
|
if (info.open_count) {
|
|
log_error("Can't resync open logical volume \"%s\"",
|
|
lv->name);
|
|
return 0;
|
|
}
|
|
|
|
if (info.exists) {
|
|
if (!arg_count(cmd, yes_ARG) &&
|
|
yes_no_prompt("Do you really want to deactivate "
|
|
"logical volume %s to resync it? [y/n]: ",
|
|
lv->name) == 'n') {
|
|
log_error("Logical volume \"%s\" not resynced",
|
|
lv->name);
|
|
return 0;
|
|
}
|
|
|
|
if (sigint_caught())
|
|
return_0;
|
|
|
|
active = 1;
|
|
if (lv_is_active_exclusive_locally(lv))
|
|
exclusive = 1;
|
|
}
|
|
}
|
|
|
|
if (seg_is_raid(seg) && active && !exclusive) {
|
|
log_error("RAID logical volume %s/%s cannot be active remotely.",
|
|
lv->vg->name, lv->name);
|
|
return 0;
|
|
}
|
|
|
|
/* Activate exclusively to ensure no nodes still have LV active */
|
|
monitored = dmeventd_monitor_mode();
|
|
if (monitored != DMEVENTD_MONITOR_IGNORE)
|
|
init_dmeventd_monitor(0);
|
|
|
|
if (!deactivate_lv(cmd, lv)) {
|
|
log_error("Unable to deactivate %s for resync", lv->name);
|
|
return 0;
|
|
}
|
|
|
|
if (vg_is_clustered(lv->vg) && lv_is_active(lv)) {
|
|
log_error("Can't get exclusive access to clustered volume %s",
|
|
lv->name);
|
|
return 0;
|
|
}
|
|
|
|
if (monitored != DMEVENTD_MONITOR_IGNORE)
|
|
init_dmeventd_monitor(monitored);
|
|
init_mirror_in_sync(0);
|
|
|
|
log_very_verbose("Starting resync of %s%s%s%s \"%s\"",
|
|
(active) ? "active " : "",
|
|
vg_is_clustered(lv->vg) ? "clustered " : "",
|
|
(seg->log_lv) ? "disk-logged " :
|
|
seg_is_raid(seg) ? "" : "core-logged ",
|
|
seg->segtype->ops->name(seg), lv->name);
|
|
|
|
/*
|
|
* If this mirror has a core log (i.e. !seg->log_lv),
|
|
* then simply deactivating/activating will cause
|
|
* it to reset the sync status. We only need to
|
|
* worry about persistent logs.
|
|
*/
|
|
if (!seg_is_raid(seg) && !seg->log_lv) {
|
|
if (lv->status & LV_NOTSYNCED) {
|
|
lv->status &= ~LV_NOTSYNCED;
|
|
log_very_verbose("Updating logical volume \"%s\""
|
|
" on disk(s)", lv->name);
|
|
if (!vg_write(lv->vg) || !vg_commit(lv->vg)) {
|
|
log_error("Failed to update metadata on disk.");
|
|
return 0;
|
|
}
|
|
}
|
|
|
|
if (!_reactivate_lv(lv, active, exclusive)) {
|
|
log_error("Failed to reactivate %s to resynchronize "
|
|
"mirror", lv->name);
|
|
return 0;
|
|
}
|
|
|
|
return 1;
|
|
}
|
|
|
|
/*
|
|
* Now we handle mirrors with log devices
|
|
*/
|
|
lv->status &= ~LV_NOTSYNCED;
|
|
|
|
/* Separate mirror log or metadata devices so we can clear them */
|
|
if (!detach_metadata_devices(seg, &device_list)) {
|
|
log_error("Failed to clear %s %s for %s",
|
|
seg->segtype->name, seg_is_raid(seg) ?
|
|
"metadata area" : "mirror log", lv->name);
|
|
return 0;
|
|
}
|
|
|
|
if (!vg_write(lv->vg)) {
|
|
log_error("Failed to write intermediate VG metadata.");
|
|
if (!attach_metadata_devices(seg, &device_list))
|
|
stack;
|
|
if (!_reactivate_lv(lv, active, exclusive))
|
|
stack;
|
|
return 0;
|
|
}
|
|
|
|
if (!vg_commit(lv->vg)) {
|
|
log_error("Failed to commit intermediate VG metadata.");
|
|
if (!attach_metadata_devices(seg, &device_list))
|
|
stack;
|
|
if (!_reactivate_lv(lv, active, exclusive))
|
|
stack;
|
|
return 0;
|
|
}
|
|
|
|
backup(lv->vg);
|
|
|
|
dm_list_iterate_items(lvl, &device_list) {
|
|
if (!activate_lv_excl_local(cmd, lvl->lv)) {
|
|
log_error("Unable to activate %s for %s clearing",
|
|
lvl->lv->name, (seg_is_raid(seg)) ?
|
|
"metadata area" : "mirror log");
|
|
return 0;
|
|
}
|
|
|
|
log_very_verbose("Clearing %s device %s",
|
|
(seg_is_raid(seg)) ? "metadata" : "log",
|
|
lvl->lv->name);
|
|
if (!set_lv(cmd, lvl->lv, lvl->lv->size, 0)) {
|
|
log_error("Unable to reset sync status for %s",
|
|
lv->name);
|
|
if (!deactivate_lv(cmd, lvl->lv))
|
|
log_error("Failed to deactivate log LV after "
|
|
"wiping failed");
|
|
return 0;
|
|
}
|
|
|
|
if (!deactivate_lv(cmd, lvl->lv)) {
|
|
log_error("Unable to deactivate %s LV %s "
|
|
"after wiping for resync",
|
|
(seg_is_raid(seg)) ? "metadata" : "log",
|
|
lvl->lv->name);
|
|
return 0;
|
|
}
|
|
}
|
|
|
|
/* Put metadata sub-LVs back in place */
|
|
if (!attach_metadata_devices(seg, &device_list)) {
|
|
log_error("Failed to reattach %s device after clearing",
|
|
(seg_is_raid(seg)) ? "metadata" : "log");
|
|
return 0;
|
|
}
|
|
|
|
log_very_verbose("Updating logical volume \"%s\" on disk(s)", lv->name);
|
|
if (!vg_write(lv->vg) || !vg_commit(lv->vg)) {
|
|
log_error("Failed to update metadata on disk.");
|
|
return 0;
|
|
}
|
|
|
|
if (!_reactivate_lv(lv, active, exclusive)) {
|
|
log_error("Failed to reactivate %s after resync",
|
|
lv->name);
|
|
return 0;
|
|
}
|
|
|
|
return 1;
|
|
}
|
|
|
|
static int lvchange_alloc(struct cmd_context *cmd, struct logical_volume *lv)
|
|
{
|
|
int want_contiguous = 0;
|
|
alloc_policy_t alloc;
|
|
|
|
want_contiguous = strcmp(arg_str_value(cmd, contiguous_ARG, "n"), "n");
|
|
alloc = want_contiguous ? ALLOC_CONTIGUOUS : ALLOC_INHERIT;
|
|
alloc = (alloc_policy_t) arg_uint_value(cmd, alloc_ARG, alloc);
|
|
|
|
if (alloc == lv->alloc) {
|
|
log_error("Allocation policy of logical volume \"%s\" is "
|
|
"already %s", lv->name, get_alloc_string(alloc));
|
|
return 0;
|
|
}
|
|
|
|
lv->alloc = alloc;
|
|
|
|
/* FIXME If contiguous, check existing extents already are */
|
|
|
|
log_verbose("Setting contiguous allocation policy for \"%s\" to %s",
|
|
lv->name, get_alloc_string(alloc));
|
|
|
|
log_very_verbose("Updating logical volume \"%s\" on disk(s)", lv->name);
|
|
|
|
/* No need to suspend LV for this change */
|
|
if (!vg_write(lv->vg) || !vg_commit(lv->vg))
|
|
return_0;
|
|
|
|
backup(lv->vg);
|
|
|
|
return 1;
|
|
}
|
|
|
|
static int lvchange_readahead(struct cmd_context *cmd,
|
|
struct logical_volume *lv)
|
|
{
|
|
unsigned read_ahead = 0;
|
|
unsigned pagesize = (unsigned) lvm_getpagesize() >> SECTOR_SHIFT;
|
|
int r = 0;
|
|
|
|
read_ahead = arg_uint_value(cmd, readahead_ARG, 0);
|
|
|
|
if (read_ahead != DM_READ_AHEAD_AUTO &&
|
|
(lv->vg->fid->fmt->features & FMT_RESTRICTED_READAHEAD) &&
|
|
(read_ahead < 2 || read_ahead > 120)) {
|
|
log_error("Metadata only supports readahead values between 2 and 120.");
|
|
return 0;
|
|
}
|
|
|
|
if (read_ahead != DM_READ_AHEAD_AUTO &&
|
|
read_ahead != DM_READ_AHEAD_NONE && read_ahead % pagesize) {
|
|
if (read_ahead < pagesize)
|
|
read_ahead = pagesize;
|
|
else
|
|
read_ahead = (read_ahead / pagesize) * pagesize;
|
|
log_warn("WARNING: Overriding readahead to %u sectors, a multiple "
|
|
"of %uK page size.", read_ahead, pagesize >> 1);
|
|
}
|
|
|
|
if (lv->read_ahead == read_ahead) {
|
|
if (read_ahead == DM_READ_AHEAD_AUTO)
|
|
log_error("Read ahead is already auto for \"%s\"", lv->name);
|
|
else
|
|
log_error("Read ahead is already %u for \"%s\"",
|
|
read_ahead, lv->name);
|
|
return 0;
|
|
}
|
|
|
|
lv->read_ahead = read_ahead;
|
|
|
|
log_verbose("Setting read ahead to %u for \"%s\"", read_ahead,
|
|
lv->name);
|
|
|
|
log_very_verbose("Updating logical volume \"%s\" on disk(s)", lv->name);
|
|
if (!vg_write(lv->vg))
|
|
return_0;
|
|
|
|
if (!suspend_lv(cmd, lv)) {
|
|
log_error("Failed to lock %s", lv->name);
|
|
vg_revert(lv->vg);
|
|
goto out;
|
|
}
|
|
|
|
if (!vg_commit(lv->vg)) {
|
|
if (!resume_lv(cmd, lv))
|
|
stack;
|
|
goto_out;
|
|
}
|
|
|
|
log_very_verbose("Updating permissions for \"%s\" in kernel", lv->name);
|
|
if (!resume_lv(cmd, lv)) {
|
|
log_error("Problem reactivating %s", lv->name);
|
|
goto out;
|
|
}
|
|
|
|
r = 1;
|
|
out:
|
|
backup(lv->vg);
|
|
return r;
|
|
}
|
|
|
|
static int lvchange_persistent(struct cmd_context *cmd,
|
|
struct logical_volume *lv)
|
|
{
|
|
struct lvinfo info;
|
|
int active = 0;
|
|
int32_t major, minor;
|
|
|
|
if (!arg_uint_value(cmd, persistent_ARG, 0)) {
|
|
if (!(lv->status & FIXED_MINOR)) {
|
|
log_error("Minor number is already not persistent "
|
|
"for \"%s\"", lv->name);
|
|
return 0;
|
|
}
|
|
lv->status &= ~FIXED_MINOR;
|
|
lv->minor = -1;
|
|
lv->major = -1;
|
|
log_verbose("Disabling persistent device number for \"%s\"",
|
|
lv->name);
|
|
} else {
|
|
if (!arg_count(cmd, minor_ARG) && lv->minor < 0) {
|
|
log_error("Minor number must be specified with -My");
|
|
return 0;
|
|
}
|
|
if (arg_count(cmd, major_ARG) > 1) {
|
|
log_error("Option -j/--major may not be repeated.");
|
|
return 0;
|
|
}
|
|
if (arg_count(cmd, minor_ARG) > 1) {
|
|
log_error("Option --minor may not be repeated.");
|
|
return 0;
|
|
}
|
|
if (!arg_count(cmd, major_ARG) && lv->major < 0) {
|
|
log_error("Major number must be specified with -My");
|
|
return 0;
|
|
}
|
|
if (lv_info(cmd, lv, 0, &info, 0, 0) && info.exists)
|
|
active = 1;
|
|
|
|
major = arg_int_value(cmd, major_ARG, lv->major);
|
|
minor = arg_int_value(cmd, minor_ARG, lv->minor);
|
|
if (!major_minor_valid(cmd, lv->vg->fid->fmt, major, minor))
|
|
return 0;
|
|
|
|
if (active && !arg_count(cmd, force_ARG) &&
|
|
!arg_count(cmd, yes_ARG) &&
|
|
yes_no_prompt("Logical volume %s will be "
|
|
"deactivated temporarily. "
|
|
"Continue? [y/n]: ", lv->name) == 'n') {
|
|
log_error("%s device number not changed.",
|
|
lv->name);
|
|
return 0;
|
|
}
|
|
|
|
if (sigint_caught())
|
|
return_0;
|
|
|
|
log_verbose("Ensuring %s is inactive.", lv->name);
|
|
if (!deactivate_lv(cmd, lv)) {
|
|
log_error("%s: deactivation failed", lv->name);
|
|
return 0;
|
|
}
|
|
lv->status |= FIXED_MINOR;
|
|
lv->minor = minor;
|
|
lv->major = major;
|
|
log_verbose("Setting persistent device number to (%d, %d) "
|
|
"for \"%s\"", lv->major, lv->minor, lv->name);
|
|
|
|
}
|
|
|
|
log_very_verbose("Updating logical volume \"%s\" on disk(s)", lv->name);
|
|
if (!vg_write(lv->vg) || !vg_commit(lv->vg))
|
|
return_0;
|
|
|
|
backup(lv->vg);
|
|
|
|
if (active) {
|
|
log_verbose("Re-activating logical volume \"%s\"", lv->name);
|
|
if (!activate_lv(cmd, lv)) {
|
|
log_error("%s: reactivation failed", lv->name);
|
|
return 0;
|
|
}
|
|
}
|
|
|
|
return 1;
|
|
}
|
|
|
|
static int lvchange_tag(struct cmd_context *cmd, struct logical_volume *lv, int arg)
|
|
{
|
|
if (!change_tag(cmd, NULL, lv, NULL, arg))
|
|
return_0;
|
|
|
|
log_very_verbose("Updating logical volume \"%s\" on disk(s)", lv->name);
|
|
|
|
/* No need to suspend LV for this change */
|
|
if (!vg_write(lv->vg) || !vg_commit(lv->vg))
|
|
return_0;
|
|
|
|
backup(lv->vg);
|
|
|
|
return 1;
|
|
}
|
|
|
|
static int lvchange_writemostly(struct logical_volume *lv)
|
|
{
|
|
int s, pv_count, i = 0;
|
|
char **pv_names;
|
|
const char *tmp_str;
|
|
size_t tmp_str_len;
|
|
struct pv_list *pvl;
|
|
struct arg_value_group_list *group;
|
|
struct cmd_context *cmd = lv->vg->cmd;
|
|
struct lv_segment *raid_seg = first_seg(lv);
|
|
|
|
if (strcmp(raid_seg->segtype->name, "raid1")) {
|
|
log_error("--write%s can only be used with 'raid1' segment type",
|
|
arg_count(cmd, writemostly_ARG) ? "mostly" : "behind");
|
|
return 0;
|
|
}
|
|
|
|
if (arg_count(cmd, writebehind_ARG))
|
|
raid_seg->writebehind = arg_uint_value(cmd, writebehind_ARG, 0);
|
|
|
|
if (arg_count(cmd, writemostly_ARG)) {
|
|
/* writemostly can be specified more than once */
|
|
pv_count = arg_count(cmd, writemostly_ARG);
|
|
pv_names = dm_pool_alloc(lv->vg->vgmem, sizeof(char *) * pv_count);
|
|
if (!pv_names)
|
|
return_0;
|
|
|
|
dm_list_iterate_items(group, &cmd->arg_value_groups) {
|
|
if (!grouped_arg_is_set(group->arg_values,
|
|
writemostly_ARG))
|
|
continue;
|
|
|
|
if (!(tmp_str = grouped_arg_str_value(group->arg_values,
|
|
writemostly_ARG,
|
|
NULL)))
|
|
return_0;
|
|
|
|
/*
|
|
* Writemostly PV specifications can be:
|
|
* <PV> - Turn on writemostly
|
|
* <PV>:t - Toggle writemostly
|
|
* <PV>:n - Turn off writemostly
|
|
* <PV>:y - Turn on writemostly
|
|
*
|
|
* We allocate strlen + 3 to add our own ':{t|n|y}' if
|
|
* not present plus the trailing '\0'.
|
|
*/
|
|
tmp_str_len = strlen(tmp_str);
|
|
if (!(pv_names[i] = dm_pool_zalloc(lv->vg->vgmem, tmp_str_len + 3)))
|
|
return_0;
|
|
|
|
if (tmp_str_len < 3 ||
|
|
((tmp_str[tmp_str_len - 2] != ':') &&
|
|
((tmp_str[tmp_str_len - 1] != 't') ||
|
|
(tmp_str[tmp_str_len - 1] != 'y') ||
|
|
(tmp_str[tmp_str_len - 1] != 'n'))))
|
|
/* Default to 'y' if no mode specified */
|
|
sprintf(pv_names[i], "%s:y", tmp_str);
|
|
else
|
|
sprintf(pv_names[i], "%s", tmp_str);
|
|
i++;
|
|
}
|
|
|
|
for (i = 0; i < pv_count; i++)
|
|
pv_names[i][strlen(pv_names[i]) - 2] = '\0';
|
|
|
|
for (i = 0; i < pv_count; i++) {
|
|
if (!(pvl = find_pv_in_vg(lv->vg, pv_names[i]))) {
|
|
log_error("%s not found in volume group, %s",
|
|
pv_names[i], lv->vg->name);
|
|
return 0;
|
|
}
|
|
|
|
for (s = 0; s < raid_seg->area_count; s++) {
|
|
/*
|
|
* We don't bother checking the metadata area,
|
|
* since writemostly only affects the data areas.
|
|
*/
|
|
if ((seg_type(raid_seg, s) == AREA_UNASSIGNED))
|
|
continue;
|
|
|
|
if (lv_is_on_pv(seg_lv(raid_seg, s), pvl->pv)) {
|
|
if (pv_names[i][strlen(pv_names[i]) + 1] == 'y')
|
|
seg_lv(raid_seg, s)->status |=
|
|
LV_WRITEMOSTLY;
|
|
else if (pv_names[i][strlen(pv_names[i]) + 1] == 'n')
|
|
seg_lv(raid_seg, s)->status &=
|
|
~LV_WRITEMOSTLY;
|
|
else if (pv_names[i][strlen(pv_names[i]) + 1] == 't')
|
|
seg_lv(raid_seg, s)->status ^=
|
|
LV_WRITEMOSTLY;
|
|
else
|
|
return_0;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
if (!vg_write(lv->vg))
|
|
return_0;
|
|
|
|
if (!suspend_lv(cmd, lv)) {
|
|
vg_revert(lv->vg);
|
|
return_0;
|
|
}
|
|
|
|
if (!vg_commit(lv->vg)) {
|
|
if (!resume_lv(cmd, lv))
|
|
stack;
|
|
return_0;
|
|
}
|
|
|
|
log_very_verbose("Updating writemostly for \"%s\" in kernel", lv->name);
|
|
if (!resume_lv(cmd, lv)) {
|
|
log_error("Problem reactivating %s", lv->name);
|
|
return 0;
|
|
}
|
|
|
|
return 1;
|
|
}
|
|
|
|
static int lvchange_recovery_rate(struct logical_volume *lv)
|
|
{
|
|
struct cmd_context *cmd = lv->vg->cmd;
|
|
struct lv_segment *raid_seg = first_seg(lv);
|
|
|
|
if (!seg_is_raid(raid_seg)) {
|
|
log_error("Unable to change the recovery rate of non-RAID"
|
|
" logical volume.");
|
|
return 0;
|
|
}
|
|
|
|
if (arg_count(cmd, minrecoveryrate_ARG))
|
|
raid_seg->min_recovery_rate =
|
|
arg_uint_value(cmd, minrecoveryrate_ARG, 0) / 2;
|
|
if (arg_count(cmd, maxrecoveryrate_ARG))
|
|
raid_seg->max_recovery_rate =
|
|
arg_uint_value(cmd, maxrecoveryrate_ARG, 0) / 2;
|
|
|
|
if (raid_seg->max_recovery_rate &&
|
|
(raid_seg->max_recovery_rate < raid_seg->min_recovery_rate)) {
|
|
log_error("Minumum recovery rate cannot"
|
|
" be higher than maximum.");
|
|
return 0;
|
|
}
|
|
|
|
if (!vg_write(lv->vg))
|
|
return_0;
|
|
|
|
if (!suspend_lv(cmd, lv)) {
|
|
vg_revert(lv->vg);
|
|
return_0;
|
|
}
|
|
|
|
if (!vg_commit(lv->vg)) {
|
|
if (!resume_lv(cmd, lv))
|
|
stack;
|
|
return_0;
|
|
}
|
|
|
|
log_very_verbose("Updating recovery rate for \"%s\" in kernel",
|
|
lv->name);
|
|
if (!resume_lv(cmd, lv)) {
|
|
log_error("Problem reactivating %s", lv->name);
|
|
return 0;
|
|
}
|
|
|
|
return 1;
|
|
}
|
|
|
|
static int lvchange_profile(struct logical_volume *lv)
|
|
{
|
|
const char *old_profile_name, *new_profile_name;
|
|
struct profile *new_profile;
|
|
|
|
old_profile_name = lv->profile ? lv->profile->name : "(inherited)";
|
|
|
|
if (arg_count(lv->vg->cmd, detachprofile_ARG)) {
|
|
new_profile_name = "(inherited)";
|
|
lv->profile = NULL;
|
|
} else {
|
|
new_profile_name = arg_str_value(lv->vg->cmd, profile_ARG, NULL);
|
|
if (!(new_profile = add_profile(lv->vg->cmd, new_profile_name)))
|
|
return_0;
|
|
lv->profile = new_profile;
|
|
}
|
|
|
|
log_verbose("Changing configuration profile for LV %s: %s -> %s.",
|
|
lv->name, old_profile_name, new_profile_name);
|
|
|
|
if (!vg_write(lv->vg) || !vg_commit(lv->vg))
|
|
return_0;
|
|
|
|
backup(lv->vg);
|
|
|
|
return 1;
|
|
}
|
|
|
|
static int lvchange_activation_skip(struct logical_volume *lv)
|
|
{
|
|
int skip = arg_int_value(lv->vg->cmd, setactivationskip_ARG, 0);
|
|
|
|
lv_set_activation_skip(lv, 1, skip);
|
|
|
|
log_verbose("Changing activation skip flag to %s for LV %s.",
|
|
lv->name, skip ? "enabled" : "disabled");
|
|
|
|
if (!vg_write(lv->vg) || !vg_commit(lv->vg))
|
|
return_0;
|
|
|
|
backup(lv->vg);
|
|
|
|
return 1;
|
|
}
|
|
|
|
|
|
static int lvchange_single(struct cmd_context *cmd, struct logical_volume *lv,
|
|
void *handle __attribute__((unused)))
|
|
{
|
|
int doit = 0, docmds = 0;
|
|
struct logical_volume *origin;
|
|
char snaps_msg[128];
|
|
|
|
if (!(lv->vg->status & LVM_WRITE) &&
|
|
(arg_count(cmd, contiguous_ARG) || arg_count(cmd, permission_ARG) ||
|
|
arg_count(cmd, readahead_ARG) || arg_count(cmd, persistent_ARG) ||
|
|
arg_count(cmd, discards_ARG) || arg_count(cmd, zero_ARG) ||
|
|
arg_count(cmd, alloc_ARG) || arg_count(cmd, profile_ARG))) {
|
|
log_error("Only -a permitted with read-only volume "
|
|
"group \"%s\"", lv->vg->name);
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
|
|
if (lv_is_origin(lv) && !lv_is_thin_volume(lv) &&
|
|
(arg_count(cmd, contiguous_ARG) || arg_count(cmd, permission_ARG) ||
|
|
arg_count(cmd, readahead_ARG) || arg_count(cmd, persistent_ARG) ||
|
|
arg_count(cmd, alloc_ARG) || arg_count(cmd, profile_ARG))) {
|
|
log_error("Can't change logical volume \"%s\" under snapshot",
|
|
lv->name);
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
if (lv_is_cow(lv) && !lv_is_virtual_origin(origin = origin_from_cow(lv)) &&
|
|
arg_count(cmd, activate_ARG)) {
|
|
if (origin->origin_count < 2)
|
|
snaps_msg[0] = '\0';
|
|
else if (dm_snprintf(snaps_msg, sizeof(snaps_msg),
|
|
" and %u other snapshot(s)",
|
|
origin->origin_count - 1) < 0) {
|
|
log_error("Failed to prepare message.");
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
if (!arg_count(cmd, yes_ARG) &&
|
|
(yes_no_prompt("Change of snapshot %s will also change its"
|
|
" origin %s%s. Proceed? [y/n]: ", lv->name,
|
|
origin->name, snaps_msg) == 'n')) {
|
|
log_error("Logical volume %s not changed.", lv->name);
|
|
return ECMD_FAILED;
|
|
}
|
|
}
|
|
|
|
if (lv->status & PVMOVE) {
|
|
log_error("Unable to change pvmove LV %s", lv->name);
|
|
if (arg_count(cmd, activate_ARG))
|
|
log_error("Use 'pvmove --abort' to abandon a pvmove");
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
if (lv->status & MIRROR_LOG) {
|
|
log_error("Unable to change mirror log LV %s directly", lv->name);
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
if (lv->status & MIRROR_IMAGE) {
|
|
log_error("Unable to change mirror image LV %s directly",
|
|
lv->name);
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
/* If LV is sparse, activate origin instead */
|
|
if (arg_count(cmd, activate_ARG) && lv_is_cow(lv) &&
|
|
lv_is_virtual_origin(origin = origin_from_cow(lv)))
|
|
lv = origin;
|
|
|
|
if ((lv_is_thin_pool_data(lv) || lv_is_thin_pool_metadata(lv)) &&
|
|
!arg_count(cmd, activate_ARG) &&
|
|
!arg_count(cmd, permission_ARG) &&
|
|
!arg_count(cmd, setactivationskip_ARG))
|
|
/* Rest can be changed for stacked thin pool meta/data volumes */
|
|
;
|
|
else if (!(lv_is_visible(lv)) && !lv_is_virtual_origin(lv)) {
|
|
log_error("Unable to change internal LV %s directly",
|
|
lv->name);
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
/*
|
|
* FIXME: DEFAULT_BACKGROUND_POLLING should be "unspecified".
|
|
* If --poll is explicitly provided use it; otherwise polling
|
|
* should only be started if the LV is not already active. So:
|
|
* 1) change the activation code to say if the LV was actually activated
|
|
* 2) make polling of an LV tightly coupled with LV activation
|
|
*
|
|
* Do not initiate any polling if --sysinit option is used.
|
|
*/
|
|
init_background_polling(arg_count(cmd, sysinit_ARG) ? 0 :
|
|
arg_int_value(cmd, poll_ARG,
|
|
DEFAULT_BACKGROUND_POLLING));
|
|
|
|
/* access permission change */
|
|
if (arg_count(cmd, permission_ARG)) {
|
|
if (!archive(lv->vg))
|
|
return_ECMD_FAILED;
|
|
doit += lvchange_permission(cmd, lv);
|
|
docmds++;
|
|
}
|
|
|
|
/* allocation policy change */
|
|
if (arg_count(cmd, contiguous_ARG) || arg_count(cmd, alloc_ARG)) {
|
|
if (!archive(lv->vg))
|
|
return_ECMD_FAILED;
|
|
doit += lvchange_alloc(cmd, lv);
|
|
docmds++;
|
|
}
|
|
|
|
/* read ahead sector change */
|
|
if (arg_count(cmd, readahead_ARG)) {
|
|
if (!archive(lv->vg))
|
|
return_ECMD_FAILED;
|
|
doit += lvchange_readahead(cmd, lv);
|
|
docmds++;
|
|
}
|
|
|
|
/* persistent device number change */
|
|
if (arg_count(cmd, persistent_ARG)) {
|
|
if (!archive(lv->vg))
|
|
return_ECMD_FAILED;
|
|
doit += lvchange_persistent(cmd, lv);
|
|
docmds++;
|
|
if (sigint_caught())
|
|
return_ECMD_FAILED;
|
|
}
|
|
|
|
if (arg_count(cmd, discards_ARG) ||
|
|
arg_count(cmd, zero_ARG)) {
|
|
if (!archive(lv->vg))
|
|
return_ECMD_FAILED;
|
|
doit += lvchange_pool_update(cmd, lv);
|
|
docmds++;
|
|
}
|
|
|
|
/* add tag */
|
|
if (arg_count(cmd, addtag_ARG)) {
|
|
if (!archive(lv->vg))
|
|
return_ECMD_FAILED;
|
|
doit += lvchange_tag(cmd, lv, addtag_ARG);
|
|
docmds++;
|
|
}
|
|
|
|
/* del tag */
|
|
if (arg_count(cmd, deltag_ARG)) {
|
|
if (!archive(lv->vg))
|
|
return_ECMD_FAILED;
|
|
doit += lvchange_tag(cmd, lv, deltag_ARG);
|
|
docmds++;
|
|
}
|
|
|
|
/* change writemostly/writebehind */
|
|
if (arg_count(cmd, writemostly_ARG) || arg_count(cmd, writebehind_ARG)) {
|
|
if (!archive(lv->vg))
|
|
return_ECMD_FAILED;
|
|
doit += lvchange_writemostly(lv);
|
|
docmds++;
|
|
}
|
|
|
|
/* change [min|max]_recovery_rate */
|
|
if (arg_count(cmd, minrecoveryrate_ARG) ||
|
|
arg_count(cmd, maxrecoveryrate_ARG)) {
|
|
if (!archive(lv->vg))
|
|
return_ECMD_FAILED;
|
|
doit += lvchange_recovery_rate(lv);
|
|
docmds++;
|
|
}
|
|
|
|
/* change configuration profile */
|
|
if (arg_count(cmd, profile_ARG) || arg_count(cmd, detachprofile_ARG)) {
|
|
if (!archive(lv->vg))
|
|
return_ECMD_FAILED;
|
|
doit += lvchange_profile(lv);
|
|
docmds++;
|
|
}
|
|
|
|
if (arg_count(cmd, setactivationskip_ARG)) {
|
|
if (!archive(lv->vg))
|
|
return_ECMD_FAILED;
|
|
doit += lvchange_activation_skip(lv);
|
|
docmds++;
|
|
}
|
|
|
|
if (doit)
|
|
log_print_unless_silent("Logical volume \"%s\" changed.", lv->name);
|
|
|
|
if (arg_count(cmd, resync_ARG) &&
|
|
!lvchange_resync(cmd, lv))
|
|
return_ECMD_FAILED;
|
|
|
|
if (arg_count(cmd, syncaction_ARG) &&
|
|
!lv_raid_message(lv, arg_str_value(cmd, syncaction_ARG, NULL)))
|
|
return_ECMD_FAILED;
|
|
|
|
/* activation change */
|
|
if (arg_count(cmd, activate_ARG)) {
|
|
if (!_lvchange_activate(cmd, lv))
|
|
return_ECMD_FAILED;
|
|
} else if (arg_count(cmd, refresh_ARG)) {
|
|
if (!lvchange_refresh(cmd, lv))
|
|
return_ECMD_FAILED;
|
|
} else {
|
|
if (arg_count(cmd, monitor_ARG) &&
|
|
!lvchange_monitoring(cmd, lv))
|
|
return_ECMD_FAILED;
|
|
|
|
if (arg_count(cmd, poll_ARG) &&
|
|
!lvchange_background_polling(cmd, lv))
|
|
return_ECMD_FAILED;
|
|
}
|
|
|
|
if (doit != docmds)
|
|
return_ECMD_FAILED;
|
|
|
|
return ECMD_PROCESSED;
|
|
}
|
|
|
|
int lvchange(struct cmd_context *cmd, int argc, char **argv)
|
|
{
|
|
/*
|
|
* Options that update metadata should be listed in one of
|
|
* the two lists below (i.e. options other than -a, --refresh,
|
|
* --monitor or --poll).
|
|
*/
|
|
int update_partial_safe = /* options safe to update if partial */
|
|
arg_count(cmd, contiguous_ARG) ||
|
|
arg_count(cmd, permission_ARG) ||
|
|
arg_count(cmd, readahead_ARG) ||
|
|
arg_count(cmd, persistent_ARG) ||
|
|
arg_count(cmd, addtag_ARG) ||
|
|
arg_count(cmd, deltag_ARG) ||
|
|
arg_count(cmd, profile_ARG) ||
|
|
arg_count(cmd, detachprofile_ARG) ||
|
|
arg_count(cmd, setactivationskip_ARG);
|
|
int update_partial_unsafe =
|
|
arg_count(cmd, alloc_ARG) ||
|
|
arg_count(cmd, discards_ARG) ||
|
|
arg_count(cmd, minrecoveryrate_ARG) ||
|
|
arg_count(cmd, maxrecoveryrate_ARG) ||
|
|
arg_count(cmd, resync_ARG) ||
|
|
arg_count(cmd, syncaction_ARG) ||
|
|
arg_count(cmd, writebehind_ARG) ||
|
|
arg_count(cmd, writemostly_ARG) ||
|
|
arg_count(cmd, zero_ARG);
|
|
int update = update_partial_safe || update_partial_unsafe;
|
|
|
|
if (!update &&
|
|
!arg_count(cmd, activate_ARG) && !arg_count(cmd, refresh_ARG) &&
|
|
!arg_count(cmd, monitor_ARG) && !arg_count(cmd, poll_ARG)) {
|
|
log_error("Need 1 or more of -a, -C, -M, -p, -r, -Z, "
|
|
"--resync, --refresh, --alloc, --addtag, --deltag, "
|
|
"--monitor, --poll or --discards");
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
|
|
if (arg_count(cmd, profile_ARG) && arg_count(cmd, detachprofile_ARG)) {
|
|
log_error("Only one of --profile and --detachprofile permitted.");
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
|
|
if (arg_count(cmd, activate_ARG) && arg_count(cmd, refresh_ARG)) {
|
|
log_error("Only one of -a and --refresh permitted.");
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
|
|
if ((arg_count(cmd, ignorelockingfailure_ARG) ||
|
|
arg_count(cmd, sysinit_ARG)) && update) {
|
|
log_error("Only -a permitted with --ignorelockingfailure and --sysinit");
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
|
|
if (!update || !update_partial_unsafe)
|
|
cmd->handles_missing_pvs = 1;
|
|
|
|
if (!argc) {
|
|
log_error("Please give logical volume path(s)");
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
|
|
if ((arg_count(cmd, minor_ARG) || arg_count(cmd, major_ARG)) &&
|
|
!arg_count(cmd, persistent_ARG)) {
|
|
log_error("--major and --minor require -My");
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
|
|
if (arg_count(cmd, minor_ARG) && argc != 1) {
|
|
log_error("Only give one logical volume when specifying minor");
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
|
|
if (arg_count(cmd, contiguous_ARG) && arg_count(cmd, alloc_ARG)) {
|
|
log_error("Only one of --alloc and --contiguous permitted");
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
|
|
if (arg_count(cmd, poll_ARG) && arg_count(cmd, sysinit_ARG)) {
|
|
log_error("Only one of --poll and --sysinit permitted");
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
|
|
if (arg_count(cmd, sysinit_ARG) && lvmetad_active() &&
|
|
arg_uint_value(cmd, activate_ARG, 0) == CHANGE_AAY) {
|
|
log_warn("lvmetad is active while using --sysinit -a ay, "
|
|
"skipping manual activation");
|
|
return ECMD_PROCESSED;
|
|
}
|
|
|
|
return process_each_lv(cmd, argc, argv,
|
|
update ? READ_FOR_UPDATE : 0, NULL,
|
|
&lvchange_single);
|
|
}
|